[GitHub] spark issue #21146: [SPARK-23654][BUILD][WiP] remove jets3t as a dependency ...
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/21146 BTW, the activation framework (primariy used for some mime type stuff) is still being developed, now on github at @javaee [https://github.com/javaee/activation](https://github.com/javaee/activation). At least it is being maintained --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21146: [SPARK-23654][BUILD][WiP] remove jets3t as a dependency ...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/21146 I guess leave a note about why the activation artifact is managed there. Safer to keep it I guess. That artifact will almost surely not change. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21146: [SPARK-23654][BUILD][WiP] remove jets3t as a dependency ...
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/21146 There's usually good reasons for upgrading crypto stuff like bouncy castle; nothing to feel bad about. How about I take this patch & add the explicit activation 1.1.1 ref to reinstate it, leave the rest out? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21146: [SPARK-23654][BUILD][WiP] remove jets3t as a dependency ...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/21146 It seems reasonable to proceed to remove this, and just reflect the rest of the dep changes accordingly. I wonder if updating bcprov actually makes it work or something? Or, could one say that updating bouncy castle at some point was an error that caused this to stop working? if it was long ago, well, maybe no use in undoing it. But if it happened very recently maybe we need to revisit. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21146: [SPARK-23654][BUILD][WiP] remove jets3t as a dependency ...
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/21146 The transitive dependencies are a separate issue. Jets3t pulls in 3 JARs which nothing else seems to need, but which transitively go onto the spark CP downgraded * javax.activation : could/should be bumped up to 1.1.1 again; missing * bcprov-jdk15on-1.58.jar ? really part of bouncy castle * base64-2.3.8.jar, There are so many base-64 encoders on the average classpath nobody will be short of that one * [java-xmlbuilder-1.1.jar](https://mvnrepository.com/artifact/com.jamesmurty.utils/java-xmlbuilder) ? there are newer versions; removing it and letting recipients choose their own would be wiser --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21146: [SPARK-23654][BUILD][WiP] remove jets3t as a dependency ...
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/21146 It's not going to stop user code from working as the bouncy castle version on the classpath means that Jets3t doesn't actually work. The fact that nobody has complained about this must count as a metric of how many people use jets3t :) More of an issue is the fact that the httpclient in 2.3+ isn't compatible with the AWS SDK in Hadoop 2.8.x. ... --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21146: [SPARK-23654][BUILD][WiP] remove jets3t as a dependency ...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/21146 Seems OK to remove if it's really not being used, except that it means it's not leaking onto the user classpath anymore, right? that is, this can potentially cause user code to stop working if this goes in 2.4, or am I missing something? Could go in for 3.0. The other dependency changes seem OK. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21146: [SPARK-23654][BUILD][WiP] remove jets3t as a dependency ...
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/21146 As promised, dependencies fail ``` diff --git a/dev/deps/spark-deps-hadoop-2.6 b/dev/pr-deps/spark-deps-hadoop-2.6 index 32b2e4f..609eeb9 100644 --- a/dev/deps/spark-deps-hadoop-2.6 +++ b/dev/pr-deps/spark-deps-hadoop-2.6 @@ -1,7 +1,7 @@ JavaEWAH-0.3.2.jar RoaringBitmap-0.5.11.jar ST4-4.0.4.jar -activation-1.1.1.jar +activation-1.1.jar aircompressor-0.8.jar antlr-2.7.7.jar antlr-runtime-3.4.jar @@ -21,8 +21,6 @@ automaton-1.11-8.jar avro-1.7.7.jar avro-ipc-1.7.7.jar avro-mapred-1.7.7-hadoop2.jar -base64-2.3.8.jar -bcprov-jdk15on-1.58.jar bonecp-0.8.0.RELEASE.jar breeze-macros_2.11-0.13.2.jar breeze_2.11-0.13.2.jar @@ -101,7 +99,6 @@ jackson-module-paranamer-2.7.9.jar jackson-module-scala_2.11-2.6.7.1.jar jackson-xc-1.9.13.jar janino-3.0.8.jar -java-xmlbuilder-1.1.jar javassist-3.18.1-GA.jar javax.annotation-api-1.2.jar javax.inject-1.jar ``` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21146: [SPARK-23654][BUILD][WiP] remove jets3t as a dependency ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21146 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21146: [SPARK-23654][BUILD][WiP] remove jets3t as a dependency ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21146 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2640/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21146: [SPARK-23654][BUILD][WiP] remove jets3t as a dependency ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21146 **[Test build #89800 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89800/testReport)** for PR 21146 at commit [`c011acc`](https://github.com/apache/spark/commit/c011acc110e5de49a1215ad7bdb6054ba326013a). * This patch **fails build dependency tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21146: [SPARK-23654][BUILD][WiP] remove jets3t as a dependency ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21146 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89800/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21146: [SPARK-23654][BUILD][WiP] remove jets3t as a dependency ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21146 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21146: [SPARK-23654][BUILD][WiP] remove jets3t as a dependency ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21146 **[Test build #89800 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89800/testReport)** for PR 21146 at commit [`c011acc`](https://github.com/apache/spark/commit/c011acc110e5de49a1215ad7bdb6054ba326013a). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
