[GitHub] spark issue #21195: [Spark-23975][ML] Add support of array input for all clu...
Github user MrBago commented on the issue: https://github.com/apache/spark/pull/21195 Looking now. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21195: [Spark-23975][ML] Add support of array input for all clu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21195 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21195: [Spark-23975][ML] Add support of array input for all clu...
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/21195 add to whitelist --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21195: [Spark-23975][ML] Add support of array input for all clu...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21195 **[Test build #89981 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89981/testReport)** for PR 21195 at commit [`45e6e96`](https://github.com/apache/spark/commit/45e6e96e974607ed0526401d0fdbb4f1c8161dd6). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21195: [Spark-23975][ML] Add support of array input for all clu...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21195 **[Test build #89981 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89981/testReport)** for PR 21195 at commit [`45e6e96`](https://github.com/apache/spark/commit/45e6e96e974607ed0526401d0fdbb4f1c8161dd6). * This patch **fails SparkR unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21195: [Spark-23975][ML] Add support of array input for all clu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21195 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89981/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21195: [Spark-23975][ML] Add support of array input for all clu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21195 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21195: [Spark-23975][ML] Add support of array input for all clu...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21195 **[Test build #4166 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4166/testReport)** for PR 21195 at commit [`45e6e96`](https://github.com/apache/spark/commit/45e6e96e974607ed0526401d0fdbb4f1c8161dd6). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21195: [Spark-23975][ML] Add support of array input for all clu...
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/21195 Rerunning tests in case the R CRAN failure was from flakiness --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21195: [Spark-23975][ML] Add support of array input for all clu...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21195 **[Test build #4166 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4166/testReport)** for PR 21195 at commit [`45e6e96`](https://github.com/apache/spark/commit/45e6e96e974607ed0526401d0fdbb4f1c8161dd6). * This patch **fails SparkR unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21195: [Spark-23975][ML] Add support of array input for all clu...
Github user MrBago commented on the issue: https://github.com/apache/spark/pull/21195 Thanks Lu! I had a pass over this PR and it looks pretty straightforward. One thing I noticed is that there are two patterns that we keep repeating. I think we should add private APIs for these patterns and delegate to those. The first pattern is the validate schema method defined in terms of typeCandidates. I suggest we add something like `validateVectorCompatibleColumn` to `DatasetUtils`. In addition to helping with code reuse, this api would make it easier if we ever decide, for example, to support Arrays of Ints. The second pattern is going from a dataframe & column name to an rdd[OldVector]. Lets add a method that does this, maybe something like `(DataFrame, String) => RDD[OldVector]`. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21195: [Spark-23975][ML] Add support of array input for all clu...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21195 **[Test build #90160 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90160/testReport)** for PR 21195 at commit [`877c126`](https://github.com/apache/spark/commit/877c126ff493e43edb5a8bcf33e7dd1fe59503b0). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21195: [Spark-23975][ML] Add support of array input for all clu...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21195 **[Test build #90160 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90160/testReport)** for PR 21195 at commit [`877c126`](https://github.com/apache/spark/commit/877c126ff493e43edb5a8bcf33e7dd1fe59503b0). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21195: [Spark-23975][ML] Add support of array input for all clu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21195 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21195: [Spark-23975][ML] Add support of array input for all clu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21195 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90160/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21195: [Spark-23975][ML] Add support of array input for all clu...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21195 **[Test build #90233 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90233/testReport)** for PR 21195 at commit [`c7a14bb`](https://github.com/apache/spark/commit/c7a14bb14132ce8de084192b02fcdaa1922986a9). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21195: [Spark-23975][ML] Add support of array input for all clu...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21195 **[Test build #90233 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90233/testReport)** for PR 21195 at commit [`c7a14bb`](https://github.com/apache/spark/commit/c7a14bb14132ce8de084192b02fcdaa1922986a9). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21195: [Spark-23975][ML] Add support of array input for all clu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21195 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21195: [Spark-23975][ML] Add support of array input for all clu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21195 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90233/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21195: [Spark-23975][ML] Add support of array input for all clu...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21195 **[Test build #90335 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90335/testReport)** for PR 21195 at commit [`d065634`](https://github.com/apache/spark/commit/d065634ae70e5f0582eebcba84c90cc06e27e890). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21195: [Spark-23975][ML] Add support of array input for all clu...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21195 **[Test build #90335 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90335/testReport)** for PR 21195 at commit [`d065634`](https://github.com/apache/spark/commit/d065634ae70e5f0582eebcba84c90cc06e27e890). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21195: [Spark-23975][ML] Add support of array input for all clu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21195 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90335/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21195: [Spark-23975][ML] Add support of array input for all clu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21195 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21195: [Spark-23975][ML] Add support of array input for all clu...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21195 **[Test build #90344 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90344/testReport)** for PR 21195 at commit [`c9f478e`](https://github.com/apache/spark/commit/c9f478e990da34819828efc26c11149909e95ccc). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21195: [Spark-23975][ML] Add support of array input for all clu...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21195 **[Test build #90344 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90344/testReport)** for PR 21195 at commit [`c9f478e`](https://github.com/apache/spark/commit/c9f478e990da34819828efc26c11149909e95ccc). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21195: [Spark-23975][ML] Add support of array input for all clu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21195 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90344/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21195: [Spark-23975][ML] Add support of array input for all clu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21195 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21195: [Spark-23975][ML] Add support of array input for all clu...
Github user mengxr commented on the issue: https://github.com/apache/spark/pull/21195 LGTM. Merged into master. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
