[GitHub] spark issue #21213: [SPARK-24120] Show `Jobs` page when `jobId` is missing
Github user jongyoul commented on the issue: https://github.com/apache/spark/pull/21213 @gengliangwang Thanks. But changing URI format might make any incompatibility with other versions, thus we need to consider other aspects more. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21213: [SPARK-24120] Show `Jobs` page when `jobId` is missing
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/21213 @jongyoul @ajbozarth Personally I prefer to the current way, showing the error message:  If the problem is `yarn filter couldn't pass query strings`, can we consider changing the url from ``` /jobs/job?id=1 ``` to ``` /jobs/1 ``` which is more restful. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21213: [SPARK-24120] Show `Jobs` page when `jobId` is missing
Github user jongyoul commented on the issue: https://github.com/apache/spark/pull/21213 Thanks for reviewing this PR. Concerning your comments: 1. It makes sense. I'll prolong the time to wait for the current page. 1. Personally, I wondered if redirecting page would be better or not. I also need feedbacks for it. both look good. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21213: [SPARK-24120] Show `Jobs` page when `jobId` is missing
Github user ajbozarth commented on the issue: https://github.com/apache/spark/pull/21213 So I just ran it and have a couple minor issues: 1. The immediate refresh is a bit jarring, maybe put it on a few second delay (long enough to read the redirect message?) 2. The automatic refresh is also a maybe for me, it may make more sense to not refresh automatically but instead provide a link with a message, but I'll leave this up to others which make more sense. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21213: [SPARK-24120] Show `Jobs` page when `jobId` is missing
Github user ajbozarth commented on the issue: https://github.com/apache/spark/pull/21213 Code-wsie I think this looks fine, I'll check it out and test it later. But it seems the Utils file has some old style error that's making the GitHub diff crazy, mind just fixing it in this pr? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21213: [SPARK-24120] Show `Jobs` page when `jobId` is missing
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/21213 also cc @gengliangwang --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21213: [SPARK-24120] Show `Jobs` page when `jobId` is missing
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21213 cc @ajbozarth and @guoxiaolongzte who I believe are interested in this change. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21213: [SPARK-24120] Show `Jobs` page when `jobId` is missing
Github user jongyoul commented on the issue: https://github.com/apache/spark/pull/21213 Please review this PR --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21213: [SPARK-24120] Show `Jobs` page when `jobId` is missing
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21213 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90088/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21213: [SPARK-24120] Show `Jobs` page when `jobId` is missing
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21213 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21213: [SPARK-24120] Show `Jobs` page when `jobId` is missing
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21213 **[Test build #90088 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90088/testReport)** for PR 21213 at commit [`5e7d4a3`](https://github.com/apache/spark/commit/5e7d4a34cf4103300b4fd083ff709866edc8c2d4). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21213: [SPARK-24120] Show `Jobs` page when `jobId` is missing
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21213 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2835/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21213: [SPARK-24120] Show `Jobs` page when `jobId` is missing
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21213 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21213: [SPARK-24120] Show `Jobs` page when `jobId` is missing
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21213 **[Test build #90088 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90088/testReport)** for PR 21213 at commit [`5e7d4a3`](https://github.com/apache/spark/commit/5e7d4a34cf4103300b4fd083ff709866edc8c2d4). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21213: [SPARK-24120] Show `Jobs` page when `jobId` is missing
Github user jongyoul commented on the issue: https://github.com/apache/spark/pull/21213 test this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21213: [SPARK-24120] Show `Jobs` page when `jobId` is missing
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21213 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21213: [SPARK-24120] Show `Jobs` page when `jobId` is missing
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21213 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90036/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21213: [SPARK-24120] Show `Jobs` page when `jobId` is missing
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21213 **[Test build #90036 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90036/testReport)** for PR 21213 at commit [`5e7d4a3`](https://github.com/apache/spark/commit/5e7d4a34cf4103300b4fd083ff709866edc8c2d4). * This patch **fails SparkR unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21213: [SPARK-24120] Show `Jobs` page when `jobId` is missing
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21213 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2799/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21213: [SPARK-24120] Show `Jobs` page when `jobId` is missing
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21213 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21213: [SPARK-24120] Show `Jobs` page when `jobId` is missing
Github user jongyoul commented on the issue: https://github.com/apache/spark/pull/21213 As I described in issue description, yarn filter couldn't pass query strings when redirecting to yarn application. It's already fixed with the latest version of yarn, but some old versions still have the same problem. This PR helps users not to see 404 page only. instead, it returns `Jobs` page to find proper information --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21213: [SPARK-24120] Show `Jobs` page when `jobId` is missing
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21213 **[Test build #90036 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90036/testReport)** for PR 21213 at commit [`5e7d4a3`](https://github.com/apache/spark/commit/5e7d4a34cf4103300b4fd083ff709866edc8c2d4). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
