[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21252 can you change the PR title? otherwise LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90692/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21252 **[Test build #90692 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90692/testReport)** for PR 21252 at commit [`6fa3e58`](https://github.com/apache/spark/commit/6fa3e582582fafffdc469943177e47272ba4c8a0). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3271/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21252 **[Test build #90692 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90692/testReport)** for PR 21252 at commit [`6fa3e58`](https://github.com/apache/spark/commit/6fa3e582582fafffdc469943177e47272ba4c8a0). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/21252 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90670/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21252 **[Test build #90670 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90670/testReport)** for PR 21252 at commit [`6fa3e58`](https://github.com/apache/spark/commit/6fa3e582582fafffdc469943177e47272ba4c8a0). * This patch **fails due to an unknown error code, -9**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3250/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21252 **[Test build #90670 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90670/testReport)** for PR 21252 at commit [`6fa3e58`](https://github.com/apache/spark/commit/6fa3e582582fafffdc469943177e47272ba4c8a0). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21252 **[Test build #90630 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90630/testReport)** for PR 21252 at commit [`6953927`](https://github.com/apache/spark/commit/69539277f07e7d53dab03b3cc0342cdfc4ed619e). * This patch **fails to build**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90630/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3224/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21252 **[Test build #90630 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90630/testReport)** for PR 21252 at commit [`6953927`](https://github.com/apache/spark/commit/69539277f07e7d53dab03b3cc0342cdfc4ed619e). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/21252 Thanks! LGTM. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/21252 PR description updated. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/21252 > How was this patch tested? > Not added yet. Test is added. Can you update PR description? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90408/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21252 **[Test build #90408 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90408/testReport)** for PR 21252 at commit [`4b6476b`](https://github.com/apache/spark/commit/4b6476b39f6cc08970e7bf268e9c9c213dd24cea). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21252 **[Test build #90408 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90408/testReport)** for PR 21252 at commit [`4b6476b`](https://github.com/apache/spark/commit/4b6476b39f6cc08970e7bf268e9c9c213dd24cea). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3071/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/21252 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21252 **[Test build #90406 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90406/testReport)** for PR 21252 at commit [`4b6476b`](https://github.com/apache/spark/commit/4b6476b39f6cc08970e7bf268e9c9c213dd24cea). * This patch **fails MiMa tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90406/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3070/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21252 **[Test build #90406 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90406/testReport)** for PR 21252 at commit [`4b6476b`](https://github.com/apache/spark/commit/4b6476b39f6cc08970e7bf268e9c9c213dd24cea). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/21252 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90368/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21252 **[Test build #90368 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90368/testReport)** for PR 21252 at commit [`4a8a061`](https://github.com/apache/spark/commit/4a8a061c0dae5bdd433e15ac03c090beaf7db26e). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3039/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21252 **[Test build #90368 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90368/testReport)** for PR 21252 at commit [`4a8a061`](https://github.com/apache/spark/commit/4a8a061c0dae5bdd433e15ac03c090beaf7db26e). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90315/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21252 **[Test build #90315 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90315/testReport)** for PR 21252 at commit [`7528475`](https://github.com/apache/spark/commit/75284753961c87976f5740be1fd4646966bd797f). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/21252 I will add a suite tomorrow. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/21252 We can have a test to check the physical plan under different threshold. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/21252 The changes looks good to me, but it should also be great to have a test suite to cover this change. Seems we don't have a test suite for the rule `SpecialLimits` ? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2998/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21252 **[Test build #90315 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90315/testReport)** for PR 21252 at commit [`7528475`](https://github.com/apache/spark/commit/75284753961c87976f5740be1fd4646966bd797f). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/21252 @cloud-fan @viirya Thanks for comments. I refined accordingly. Please check~ --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90296/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21252 **[Test build #90296 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90296/testReport)** for PR 21252 at commit [`0cbacc3`](https://github.com/apache/spark/commit/0cbacc36fcb2cf965f0697effe1bb6f02db5fe8f). * This patch **fails due to an unknown error code, -9**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2979/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/21252 > Instead of touching inside of TakeOrderedAndProjectExec, how about we don't replace Sort + Limit with TakeOrderedAndProjectExec when reaching the threshold? Yes, the code will be much cleaner. I updated the change. Note that all data will still be sorted if above the threshold and all data will be within one partition after the limit operator --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21252 **[Test build #90296 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90296/testReport)** for PR 21252 at commit [`0cbacc3`](https://github.com/apache/spark/commit/0cbacc36fcb2cf965f0697effe1bb6f02db5fe8f). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21252
Instead of touching inside of `TakeOrderedAndProjectExec`, how about we
don't replace `Sort` + `Limit` with `TakeOrderedAndProjectExec` when reaching
the threshold? A.k.a:
```scala
object SpecialLimits extends Strategy {
override def apply(plan: LogicalPlan): Seq[SparkPlan] = plan match {
case ReturnAnswer(rootPlan) => rootPlan match {
case Limit(IntegerLiteral(limit), Sort(order, true, child)) if
limit < conf.sortInMemForLimitThreshold =>
TakeOrderedAndProjectExec(limit, order, child.output,
planLater(child)) :: Nil
...
}
```
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90282/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21252 **[Test build #90282 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90282/testReport)** for PR 21252 at commit [`522c374`](https://github.com/apache/spark/commit/522c374f2f757b384132b3227e82e9688b2c9ffd). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2967/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21252 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21252 **[Test build #90282 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90282/testReport)** for PR 21252 at commit [`522c374`](https://github.com/apache/spark/commit/522c374f2f757b384132b3227e82e9688b2c9ffd). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21252: [SPARK-24193] Sort by disk when number of limit is big i...
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/21252 cc @cloud-fan @viirya I'm not sure if you are interested in this config. Could you please give some advice? Thanks a lot ! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
