[GitHub] spark issue #21330: [SPARK-22234] Support distinct window functions

2018-09-02 Thread jinxing64
Github user jinxing64 commented on the issue:

https://github.com/apache/spark/pull/21330
  
If this feature is interested, could you please help start the review 
@jiangxb1987 
Thanks a lot.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21330: [SPARK-22234] Support distinct window functions

2018-08-27 Thread gatorsmile
Github user gatorsmile commented on the issue:

https://github.com/apache/spark/pull/21330
  
cc @jiangxb1987 


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21330: [SPARK-22234] Support distinct window functions

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21330
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21330: [SPARK-22234] Support distinct window functions

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21330
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 

https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2460/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21330: [SPARK-22234] Support distinct window functions

2018-05-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21330
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21330: [SPARK-22234] Support distinct window functions

2018-05-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21330
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90859/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21330: [SPARK-22234] Support distinct window functions

2018-05-20 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21330
  
**[Test build #90859 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90859/testReport)**
 for PR 21330 at commit 
[`d86ba76`](https://github.com/apache/spark/commit/d86ba76e3e55820c6eb4c859b33bdced7d84b595).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21330: [SPARK-22234] Support distinct window functions

2018-05-20 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21330
  
**[Test build #90859 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90859/testReport)**
 for PR 21330 at commit 
[`d86ba76`](https://github.com/apache/spark/commit/d86ba76e3e55820c6eb4c859b33bdced7d84b595).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21330: [SPARK-22234] Support distinct window functions

2018-05-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21330
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21330: [SPARK-22234] Support distinct window functions

2018-05-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21330
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 

https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3390/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21330: [SPARK-22234] Support distinct window functions

2018-05-20 Thread jinxing64
Github user jinxing64 commented on the issue:

https://github.com/apache/spark/pull/21330
  
Jenkins, retest this please.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21330: [SPARK-22234] Support distinct window functions

2018-05-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21330
  
Merged build finished. Test FAILed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21330: [SPARK-22234] Support distinct window functions

2018-05-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21330
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90855/
Test FAILed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21330: [SPARK-22234] Support distinct window functions

2018-05-20 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21330
  
**[Test build #90855 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90855/testReport)**
 for PR 21330 at commit 
[`d86ba76`](https://github.com/apache/spark/commit/d86ba76e3e55820c6eb4c859b33bdced7d84b595).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21330: [SPARK-22234] Support distinct window functions

2018-05-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21330
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21330: [SPARK-22234] Support distinct window functions

2018-05-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21330
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 

https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3386/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21330: [SPARK-22234] Support distinct window functions

2018-05-20 Thread jinxing64
Github user jinxing64 commented on the issue:

https://github.com/apache/spark/pull/21330
  
@hvanhovell 
Thanks for looking into this.
>So this only works for global window frames?
It's for entire-partition/global window frame, growing frame, shrinking 
frame and moving/sliding frame. And I added some more tests for different kinds 
of frames in current change.




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21330: [SPARK-22234] Support distinct window functions

2018-05-20 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21330
  
**[Test build #90855 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90855/testReport)**
 for PR 21330 at commit 
[`d86ba76`](https://github.com/apache/spark/commit/d86ba76e3e55820c6eb4c859b33bdced7d84b595).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21330: [SPARK-22234] Support distinct window functions

2018-05-17 Thread jinxing64
Github user jinxing64 commented on the issue:

https://github.com/apache/spark/pull/21330
  
Also cc @kiszk @HyukjinKwon 
Really appreciate if you can leave some comments :)


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21330: [SPARK-22234] Support distinct window functions

2018-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21330
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90640/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21330: [SPARK-22234] Support distinct window functions

2018-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21330
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21330: [SPARK-22234] Support distinct window functions

2018-05-15 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21330
  
**[Test build #90640 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90640/testReport)**
 for PR 21330 at commit 
[`65ad074`](https://github.com/apache/spark/commit/65ad0740e21ffb16cfe6d9ee076f36d93a9aaaea).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21330: [SPARK-22234] Support distinct window functions

2018-05-15 Thread gatorsmile
Github user gatorsmile commented on the issue:

https://github.com/apache/spark/pull/21330
  
cc @hvanhovell 


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21330: [SPARK-22234] Support distinct window functions

2018-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21330
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 

https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3231/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21330: [SPARK-22234] Support distinct window functions

2018-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21330
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21330: [SPARK-22234] Support distinct window functions

2018-05-15 Thread jinxing64
Github user jinxing64 commented on the issue:

https://github.com/apache/spark/pull/21330
  
@cloud-fan @jiangxb1987 @cenyuhai 
Do you think this change makes sense? 
I can keep working on this.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21330: [SPARK-22234] Support distinct window functions

2018-05-15 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21330
  
**[Test build #90640 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90640/testReport)**
 for PR 21330 at commit 
[`65ad074`](https://github.com/apache/spark/commit/65ad0740e21ffb16cfe6d9ee076f36d93a9aaaea).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org