[GitHub] spark issue #21367: [SPARK-24321][SQL] Extract common code from Divide/Remai...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21367 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21367: [SPARK-24321][SQL] Extract common code from Divide/Remai...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21367 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21367: [SPARK-24321][SQL] Extract common code from Divide/Remai...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21367 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90940/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21367: [SPARK-24321][SQL] Extract common code from Divide/Remai...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21367 **[Test build #90940 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90940/testReport)** for PR 21367 at commit [`951b5bd`](https://github.com/apache/spark/commit/951b5bd073015a187cc78e5be1bd70f241fb952c). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21367: [SPARK-24321][SQL] Extract common code from Divide/Remai...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21367 **[Test build #90940 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90940/testReport)** for PR 21367 at commit [`951b5bd`](https://github.com/apache/spark/commit/951b5bd073015a187cc78e5be1bd70f241fb952c). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21367: [SPARK-24321][SQL] Extract common code from Divide/Remai...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21367 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21367: [SPARK-24321][SQL] Extract common code from Divide/Remai...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21367 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3446/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21367: [SPARK-24321][SQL] Extract common code from Divide/Remai...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/21367 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21367: [SPARK-24321][SQL] Extract common code from Divide/Remai...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21367 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90938/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21367: [SPARK-24321][SQL] Extract common code from Divide/Remai...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21367 **[Test build #90938 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90938/testReport)** for PR 21367 at commit [`951b5bd`](https://github.com/apache/spark/commit/951b5bd073015a187cc78e5be1bd70f241fb952c). * This patch **fails due to an unknown error code, -9**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21367: [SPARK-24321][SQL] Extract common code from Divide/Remai...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21367 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21367: [SPARK-24321][SQL] Extract common code from Divide/Remai...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21367 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3444/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21367: [SPARK-24321][SQL] Extract common code from Divide/Remai...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21367 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21367: [SPARK-24321][SQL] Extract common code from Divide/Remai...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21367 **[Test build #90938 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90938/testReport)** for PR 21367 at commit [`951b5bd`](https://github.com/apache/spark/commit/951b5bd073015a187cc78e5be1bd70f241fb952c). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21367: [SPARK-24321][SQL] Extract common code from Divide/Remai...
Github user rednaxelafx commented on the issue: https://github.com/apache/spark/pull/21367 Updated PR, addressed @cloud-fan and @viirya 's comments. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21367: [SPARK-24321][SQL] Extract common code from Divide/Remai...
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/21367 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21367: [SPARK-24321][SQL] Extract common code from Divide/Remai...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21367 LGTM, also cc @viirya @kiszk --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21367: [SPARK-24321][SQL] Extract common code from Divide/Remai...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21367 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90812/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21367: [SPARK-24321][SQL] Extract common code from Divide/Remai...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21367 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21367: [SPARK-24321][SQL] Extract common code from Divide/Remai...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21367 **[Test build #90812 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90812/testReport)** for PR 21367 at commit [`026531c`](https://github.com/apache/spark/commit/026531c70bfb7e06f8586010fc48a8666ff4df04). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `trait DivModLike extends BinaryArithmetic ` * `case class Divide(left: Expression, right: Expression) extends DivModLike ` * `case class Remainder(left: Expression, right: Expression) extends DivModLike ` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21367: [SPARK-24321][SQL] Extract common code from Divide/Remai...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21367 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3348/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21367: [SPARK-24321][SQL] Extract common code from Divide/Remai...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21367 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21367: [SPARK-24321][SQL] Extract common code from Divide/Remai...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21367 **[Test build #90812 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90812/testReport)** for PR 21367 at commit [`026531c`](https://github.com/apache/spark/commit/026531c70bfb7e06f8586010fc48a8666ff4df04). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
