[GitHub] spark issue #21400: [SPARK-24351][SS]offsetLog/commitLog purge thresholdBatc...
Github user ivoson commented on the issue: https://github.com/apache/spark/pull/21400 @jose-torres @xuanyuanking @zsxwing Thanks for reviewing this. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21400: [SPARK-24351][SS]offsetLog/commitLog purge thresholdBatc...
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/21400 Thanks! Merging to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21400: [SPARK-24351][SS]offsetLog/commitLog purge thresholdBatc...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21400 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21400: [SPARK-24351][SS]offsetLog/commitLog purge thresholdBatc...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21400 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91367/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21400: [SPARK-24351][SS]offsetLog/commitLog purge thresholdBatc...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21400 **[Test build #91367 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91367/testReport)** for PR 21400 at commit [`79c03e1`](https://github.com/apache/spark/commit/79c03e18106db3f61e83534bb6554dc3c7e5c841). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class ContinuousMetaSuite extends ContinuousSuiteBase ` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21400: [SPARK-24351][SS]offsetLog/commitLog purge thresholdBatc...
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/21400 LGTM pending tests --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21400: [SPARK-24351][SS]offsetLog/commitLog purge thresholdBatc...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21400 **[Test build #91367 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91367/testReport)** for PR 21400 at commit [`79c03e1`](https://github.com/apache/spark/commit/79c03e18106db3f61e83534bb6554dc3c7e5c841). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21400: [SPARK-24351][SS]offsetLog/commitLog purge thresholdBatc...
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/21400 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21400: [SPARK-24351][SS]offsetLog/commitLog purge thresholdBatc...
Github user jose-torres commented on the issue: https://github.com/apache/spark/pull/21400 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21400: [SPARK-24351][SS]offsetLog/commitLog purge thresholdBatc...
Github user ivoson commented on the issue: https://github.com/apache/spark/pull/21400 cc @jose-torres Thanks for the review. The last commit addresses the comments you left. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21400: [SPARK-24351][SS]offsetLog/commitLog purge thresholdBatc...
Github user jose-torres commented on the issue: https://github.com/apache/spark/pull/21400 LGTM other than the one comment. Sorry it took me so long to get to this. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21400: [SPARK-24351][SS]offsetLog/commitLog purge thresholdBatc...
Github user ivoson commented on the issue: https://github.com/apache/spark/pull/21400 hi @jose-torres, the last commit add a unit test for this. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21400: [SPARK-24351][SS]offsetLog/commitLog purge thresholdBatc...
Github user ivoson commented on the issue: https://github.com/apache/spark/pull/21400 @jose-torres thanks for reply. I will try to add a unit test for this. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21400: [SPARK-24351][SS]offsetLog/commitLog purge thresholdBatc...
Github user jose-torres commented on the issue: https://github.com/apache/spark/pull/21400 Nice catch! Consider adding a unit test for this. I'm not sure how easy it'd be off the top of my head to test what the offset log is retaining, and I think it's a simple enough change to do without if needed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21400: [SPARK-24351][SS]offsetLog/commitLog purge thresholdBatc...
Github user ivoson commented on the issue: https://github.com/apache/spark/pull/21400 hi, @xuanyuanking @jose-torres can you take a look at this pr please? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21400: [SPARK-24351][SS]offsetLog/commitLog purge thresholdBatc...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21400 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21400: [SPARK-24351][SS]offsetLog/commitLog purge thresholdBatc...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21400 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
