[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...
Github user xueyumusic commented on the issue: https://github.com/apache/spark/pull/21567 I see, thanks for your review and guidance, @jiangxb1987 @maropu , I will try to add related config to doc and close this PR, thank you --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/21567 Overall I don't think the current logic shall be modified. However, it shall be useful to document some the configs mentioned in this PR. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21567 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92008/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21567 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21567 **[Test build #92008 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92008/testReport)** for PR 21567 at commit [`0dd57ea`](https://github.com/apache/spark/commit/0dd57ea193cc4c3282961cea63ecf36b1d6a7e95). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21567 **[Test build #92008 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92008/testReport)** for PR 21567 at commit [`0dd57ea`](https://github.com/apache/spark/commit/0dd57ea193cc4c3282961cea63ecf36b1d6a7e95). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21567 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21567 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21567 **[Test build #91984 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91984/testReport)** for PR 21567 at commit [`0dd57ea`](https://github.com/apache/spark/commit/0dd57ea193cc4c3282961cea63ecf36b1d6a7e95). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21567 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91971/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21567 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21567 **[Test build #91971 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91971/testReport)** for PR 21567 at commit [`a69df11`](https://github.com/apache/spark/commit/a69df1137f9918670523120a2a0516b855833e84). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21567 **[Test build #91971 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91971/testReport)** for PR 21567 at commit [`a69df11`](https://github.com/apache/spark/commit/a69df1137f9918670523120a2a0516b855833e84). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21567 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21567 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91964/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21567 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21567 **[Test build #91964 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91964/testReport)** for PR 21567 at commit [`a69df11`](https://github.com/apache/spark/commit/a69df1137f9918670523120a2a0516b855833e84). * This patch **fails due to an unknown error code, -9**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21567 **[Test build #91964 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91964/testReport)** for PR 21567 at commit [`a69df11`](https://github.com/apache/spark/commit/a69df1137f9918670523120a2a0516b855833e84). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21567 @xueyumusic Can you fix the error first? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21567 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21567 cc @jiangxb1987 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21567 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91959/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21567 **[Test build #91959 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91959/testReport)** for PR 21567 at commit [`a8dc241`](https://github.com/apache/spark/commit/a8dc241d0d9a0c0a2fef1b09bad2ac52fe4f9dd9). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21567 **[Test build #91959 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91959/testReport)** for PR 21567 at commit [`a8dc241`](https://github.com/apache/spark/commit/a8dc241d0d9a0c0a2fef1b09bad2ac52fe4f9dd9). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21567 ok to test. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...
Github user xueyumusic commented on the issue: https://github.com/apache/spark/pull/21567 I have made some modification, @maropu please review the code, thanks --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21567 Can you add tests in `SparkConfSuite`? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org