[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user Fokko commented on the issue:
https://github.com/apache/spark/pull/21596
@gatorsmile Are you completely sure about that? The Spark REST API `null`
values are always omitted. Where is this behaviour different?
`mapper.setSerializationInclusion(Include.NON_ABSENT)`:
```
scala> println(mapper.writeValueAsString(Map("abc" -> null)))
{}
```
`mapper.setSerializationInclusion(Include.ALWAYS)`:
```
scala> println(mapper.writeValueAsString(Map("abc" -> null)))
{"abc":null}
```
If you're doing proper Scala and try to avoid the `null`'s in general, with
`None` in combination with
`mapper.setSerializationInclusion(Include.NON_ABSENT)` you'll get:
```
scala> println(mapper.writeValueAsString(Map("abc" -> None)))
{"abc":null}
```
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21596
It sounds like Jackson have an important behavior change that might impact
us.
```Scala
import com.fasterxml.jackson.annotation.JsonInclude.Include
import com.fasterxml.jackson.databind.{DeserializationFeature, ObjectMapper}
import com.fasterxml.jackson.module.scala.DefaultScalaModule
import com.fasterxml.jackson.module.scala.experimental.ScalaObjectMapper
val mapper = new ObjectMapper with ScalaObjectMapper
mapper.setSerializationInclusion(Include.NON_NULL)
mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false)
mapper.registerModule(DefaultScalaModule)
println(mapper.writeValueAsString(Map("abc" -> null)))
```
Previously, it outputs `{"abc":null}`, but now it is `{}`, unless we
explicitly set it to `Include.ALWAYS`. The upgrade looks risky to me.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21596 Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21596 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96928/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21596 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21596 **[Test build #96928 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96928/testReport)** for PR 21596 at commit [`b53c8f2`](https://github.com/apache/spark/commit/b53c8f2ddb949d25f09fdc3588aa0880666776f4). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21596 **[Test build #96928 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96928/testReport)** for PR 21596 at commit [`b53c8f2`](https://github.com/apache/spark/commit/b53c8f2ddb949d25f09fdc3588aa0880666776f4). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21596 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21596 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96926/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21596 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21596 **[Test build #96926 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96926/testReport)** for PR 21596 at commit [`b53c8f2`](https://github.com/apache/spark/commit/b53c8f2ddb949d25f09fdc3588aa0880666776f4). * This patch **fails due to an unknown error code, -9**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21596 **[Test build #96926 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96926/testReport)** for PR 21596 at commit [`b53c8f2`](https://github.com/apache/spark/commit/b53c8f2ddb949d25f09fdc3588aa0880666776f4). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user Fokko commented on the issue: https://github.com/apache/spark/pull/21596 Rebased onto master. @HyukjinKwon can we target this for 2.5? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21596 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96413/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21596 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21596 **[Test build #96413 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96413/testReport)** for PR 21596 at commit [`2bab06f`](https://github.com/apache/spark/commit/2bab06f8e73be0e2724bbd5c836360ab5f107d44). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21596 **[Test build #96413 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96413/testReport)** for PR 21596 at commit [`2bab06f`](https://github.com/apache/spark/commit/2bab06f8e73be0e2724bbd5c836360ab5f107d44). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21596 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96377/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21596 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21596 **[Test build #96377 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96377/testReport)** for PR 21596 at commit [`f4d294c`](https://github.com/apache/spark/commit/f4d294ce9ff4676ece2253d48ecadeec36363476). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21596 **[Test build #96377 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96377/testReport)** for PR 21596 at commit [`f4d294c`](https://github.com/apache/spark/commit/f4d294ce9ff4676ece2253d48ecadeec36363476). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21596 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96335/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21596 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21596 **[Test build #96335 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96335/testReport)** for PR 21596 at commit [`0b0b8fc`](https://github.com/apache/spark/commit/0b0b8fc2dc725e77525690f88d0236c627464a26). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21596 I think we're (at least i am) not clear on 2.5 vs 3.0 now (correct me if im mistaken). The change itself looks okay but I think it's targeted to 3.0.0 as discussed. I can take an action here when I'm clear on this. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21596 **[Test build #96335 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96335/testReport)** for PR 21596 at commit [`0b0b8fc`](https://github.com/apache/spark/commit/0b0b8fc2dc725e77525690f88d0236c627464a26). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21596 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96330/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21596 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21596 **[Test build #96330 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96330/testReport)** for PR 21596 at commit [`44b8d1b`](https://github.com/apache/spark/commit/44b8d1b73cf2cc83b4ebfcc11ccf12951878f2d6). * This patch **fails due to an unknown error code, -9**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user Fokko commented on the issue: https://github.com/apache/spark/pull/21596 @HyukjinKwon Any idea if this has any change of getting merged? The 2.4 branch has been cut a while ago. The number of merge conflicts are minimal in all the times I've rebased onto master. I think this should be done some time to bump the Jackson version, since old version of Jackson aren't compatible with the newer ones. Please let me know. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21596 **[Test build #96330 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96330/testReport)** for PR 21596 at commit [`44b8d1b`](https://github.com/apache/spark/commit/44b8d1b73cf2cc83b4ebfcc11ccf12951878f2d6). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21596 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21596 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96142/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21596 **[Test build #96142 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96142/testReport)** for PR 21596 at commit [`b889a9d`](https://github.com/apache/spark/commit/b889a9d4355bbf0eccf81a22fcca7caeb9970c74). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user Fokko commented on the issue: https://github.com/apache/spark/pull/21596 I've rebased onto master ð --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21596: [SPARK-24601] Update Jackson to 2.9.6
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21596 **[Test build #96142 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96142/testReport)** for PR 21596 at commit [`b889a9d`](https://github.com/apache/spark/commit/b889a9d4355bbf0eccf81a22fcca7caeb9970c74). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
