[GitHub] spark issue #21664: [SPARK-24687][CORE] NoClassDefFoundError will not be cat...

2018-08-25 Thread srowen
Github user srowen commented on the issue:

https://github.com/apache/spark/pull/21664
  
@caneGuy can you help me see why returning from this method aborts the job 
but throwing an error doesn't? If so, yeah that's not good. Why not just catch 
all exceptions instead of NonFatal only? that would cover all problems of this 
type.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21664: [SPARK-24687][CORE] NoClassDefFoundError will not be cat...

2018-07-17 Thread caneGuy
Github user caneGuy commented on the issue:

https://github.com/apache/spark/pull/21664
  
I think this patch will fix 'job hanging' problem @jerryshao @jiangxb1987 


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21664: [SPARK-24687][CORE] NoClassDefFoundError will not be cat...

2018-07-15 Thread jiangxb1987
Github user jiangxb1987 commented on the issue:

https://github.com/apache/spark/pull/21664
  
I agree we shall fall the job instead of let the job stay hanging.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21664: [SPARK-24687][CORE] NoClassDefFoundError will not be cat...

2018-07-12 Thread caneGuy
Github user caneGuy commented on the issue:

https://github.com/apache/spark/pull/21664
  
The problem is that the job hanging,and user will be misleading since no 
more information print.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21664: [SPARK-24687][CORE] NoClassDefFoundError will not be cat...

2018-07-12 Thread jerryshao
Github user jerryshao commented on the issue:

https://github.com/apache/spark/pull/21664
  
You already got an uncaught exception, there's no need to add warning log. 
Besides, this is a fatal error, how will let the job continue with such error?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21664: [SPARK-24687][CORE] NoClassDefFoundError will not be cat...

2018-07-12 Thread caneGuy
Github user caneGuy commented on the issue:

https://github.com/apache/spark/pull/21664
  
@jerryshao I think at least we should print a warning,not let job 
hanging?Thanks


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21664: [SPARK-24687][CORE] NoClassDefFoundError will not be cat...

2018-07-12 Thread jerryshao
Github user jerryshao commented on the issue:

https://github.com/apache/spark/pull/21664
  
The issue is not introduced by Spark itself, it is introduced by user code, 
is it better to fix in the user side rather than in Spark? Besides, I'm not so 
sure that Spark should take responsibility for user issue.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21664: [SPARK-24687][CORE] NoClassDefFoundError will not be cat...

2018-07-12 Thread caneGuy
Github user caneGuy commented on the issue:

https://github.com/apache/spark/pull/21664
  
@jiangxb1987  Thanks, i update the description of this pr.Stage 33 never be 
scheduled.and job not abort


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21664: [SPARK-24687][CORE] NoClassDefFoundError will not be cat...

2018-07-10 Thread jiangxb1987
Github user jiangxb1987 commented on the issue:

https://github.com/apache/spark/pull/21664
  
Unfortunately, I can't even track which line in Spark have hit the 
exception from the image you posted.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21664: [SPARK-24687][CORE] NoClassDefFoundError will not be cat...

2018-07-10 Thread caneGuy
Github user caneGuy commented on the issue:

https://github.com/apache/spark/pull/21664
  
I have post an image on the jira @jiangxb1987 


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org