[GitHub] spark issue #21667: [SPARK-24691][SQL]Add new API `supportDataType` in FileF...
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/21667 Sure, I am actually OK if we can have a different approach other than API. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21667: [SPARK-24691][SQL]Add new API `supportDataType` in FileF...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21667 The fixes about the bug look all okay but the API thing. Mind if I ask to proceed separately for the API change if that's possible? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21667: [SPARK-24691][SQL]Add new API `supportDataType` in FileF...
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/21667 I agree that making it an API is a bit over. But current there are problems(bug) as I listed in PR description. Maybe we can create another separate Trait? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21667: [SPARK-24691][SQL]Add new API `supportDataType` in FileF...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21667 Reading it again closely, I am actually not super happy on the proposal about introducing API change if the purpose of this is just to check the type and throw an exception. Apparently, it looks so. I am less sure how useful it is by looking the current change. It reduces the size of codes because it blacklists. I would suggest to make the API change separate with this. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21667: [SPARK-24691][SQL]Add new API `supportDataType` in FileF...
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/21667 @hvanhovell --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21667: [SPARK-24691][SQL]Add new API `supportDataType` in FileF...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21667 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92465/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21667: [SPARK-24691][SQL]Add new API `supportDataType` in FileF...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21667 **[Test build #92465 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92465/testReport)** for PR 21667 at commit [`7fdf603`](https://github.com/apache/spark/commit/7fdf6033b6778d06850e6ae5a0fd6e3fde76a5c2). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21667: [SPARK-24691][SQL]Add new API `supportDataType` in FileF...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21667 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21667: [SPARK-24691][SQL]Add new API `supportDataType` in FileF...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21667 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21667: [SPARK-24691][SQL]Add new API `supportDataType` in FileF...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21667 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/579/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21667: [SPARK-24691][SQL]Add new API `supportDataType` in FileF...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21667 **[Test build #92465 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92465/testReport)** for PR 21667 at commit [`7fdf603`](https://github.com/apache/spark/commit/7fdf6033b6778d06850e6ae5a0fd6e3fde76a5c2). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21667: [SPARK-24691][SQL]Add new API `supportDataType` in FileF...
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21667 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21667: [SPARK-24691][SQL]Add new API `supportDataType` in FileF...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21667 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21667: [SPARK-24691][SQL]Add new API `supportDataType` in FileF...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21667 **[Test build #92459 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92459/testReport)** for PR 21667 at commit [`7fdf603`](https://github.com/apache/spark/commit/7fdf6033b6778d06850e6ae5a0fd6e3fde76a5c2). * This patch **fails due to an unknown error code, -9**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21667: [SPARK-24691][SQL]Add new API `supportDataType` in FileF...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21667 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92459/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21667: [SPARK-24691][SQL]Add new API `supportDataType` in FileF...
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/21667 @maropu @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21667: [SPARK-24691][SQL]Add new API `supportDataType` in FileF...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21667 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21667: [SPARK-24691][SQL]Add new API `supportDataType` in FileF...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21667 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/571/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21667: [SPARK-24691][SQL]Add new API `supportDataType` in FileF...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21667 **[Test build #92459 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92459/testReport)** for PR 21667 at commit [`7fdf603`](https://github.com/apache/spark/commit/7fdf6033b6778d06850e6ae5a0fd6e3fde76a5c2). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
