[GitHub] spark issue #21692: [SPARK-24715][Build] Override jline version as 2.14.3 in...

2018-07-02 Thread viirya
Github user viirya commented on the issue:

https://github.com/apache/spark/pull/21692
  
Thanks @srowen for explanation. As I can tell, `-verbose:class` shows jline 
classes come from `jline-2.12.jar`, though `sbt dependency-tree` shows 
`jline:jline:0.9.94`. After this overriding, jline classes come from 
`jline-2.14.3.jar`.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21692: [SPARK-24715][Build] Override jline version as 2.14.3 in...

2018-07-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue:

https://github.com/apache/spark/pull/21692
  
Thank you all!


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21692: [SPARK-24715][Build] Override jline version as 2.14.3 in...

2018-07-02 Thread srowen
Github user srowen commented on the issue:

https://github.com/apache/spark/pull/21692
  
I haven't looked into this particular issue thoroughly, but, I'm aware that 
SBT and Maven don't actually resolve dependencies in quite the same way. I 
think the resolve conflicts with different rules -- most recent wins vs 
'nearest' wins. Could be it.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21692: [SPARK-24715][Build] Override jline version as 2.14.3 in...

2018-07-02 Thread dbtsai
Github user dbtsai commented on the issue:

https://github.com/apache/spark/pull/21692
  
@viirya thanks for this PR. I thought SBT always uses pom for dependencies, 
and I wonder why there is a discrepancy so we need to manually override it?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21692: [SPARK-24715][Build] Override jline version as 2.14.3 in...

2018-07-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/21692
  
Merged to master.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21692: [SPARK-24715][Build] Override jline version as 2.14.3 in...

2018-07-02 Thread viirya
Github user viirya commented on the issue:

https://github.com/apache/spark/pull/21692
  
@maropu Thanks. Version number is in the description now.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org