[GitHub] spark issue #22221: [SPARK-25231] : Fix synchronization of executor heartbea...

2018-09-05 Thread tgravescs 
Github user tgravescs commented on the issue:

https://github.com/apache/spark/pull/1
  
merged to master and 2.3, thanks @pgandhi999 


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22221: [SPARK-25231] : Fix synchronization of executor heartbea...

2018-09-04 Thread tgravescs 
Github user tgravescs commented on the issue:

https://github.com/apache/spark/pull/1
  
+1 


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22221: [SPARK-25231] : Fix synchronization of executor heartbea...

2018-09-01 Thread kiszk 
Github user kiszk commented on the issue:

https://github.com/apache/spark/pull/1
  
@pgandhi999 thank you for your comments.
LGTM, then let me ask @zsxwing and @JoshRosen for their comments


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22221: [SPARK-25231] : Fix synchronization of executor heartbea...

2018-08-27 Thread pgandhi999 
Github user pgandhi999 commented on the issue:

https://github.com/apache/spark/pull/1
  
@kiszk I have added some more details in the PR description. Thank you.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22221: [SPARK-25231] : Fix synchronization of executor heartbea...

2018-08-26 Thread kiszk 
Github user kiszk commented on the issue:

https://github.com/apache/spark/pull/1
  
We would appreciate it if you would describe some detail on `further 
analysis` for removing lock on the whole object. 

> On further analysis of the heartbeat receiver method, it turns out there 
is no need to hold the lock on the whole object



---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22221: [SPARK-25231] : Fix synchronization of executor heartbea...

2018-08-24 Thread AmplabJenkins 
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/1
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22221: [SPARK-25231] : Fix synchronization of executor heartbea...

2018-08-24 Thread AmplabJenkins 
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/1
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95216/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22221: [SPARK-25231] : Fix synchronization of executor heartbea...

2018-08-24 Thread SparkQA 
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/1
  
**[Test build #95216 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95216/testReport)**
 for PR 1 at commit 
[`a0dcde5`](https://github.com/apache/spark/commit/a0dcde583c76cb96f5112f4ff863874415ec9140).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org