[GitHub] spark issue #22239: [SPARK-19355][SQL][Followup] Remove the child.outputPart...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22239 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22239: [SPARK-19355][SQL][Followup] Remove the child.outputPart...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22239 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95272/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22239: [SPARK-19355][SQL][Followup] Remove the child.outputPart...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22239 **[Test build #95272 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95272/testReport)** for PR 22239 at commit [`b57634b`](https://github.com/apache/spark/commit/b57634bea6213b67eae896489e913fac685d5a75). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22239: [SPARK-19355][SQL][Followup] Remove the child.outputPart...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/22239 Shall we rename it to: **[SPARK-19355][SQL][Followup] Remove the child.outputOrdering check in global limit**? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22239: [SPARK-19355][SQL][Followup] Remove the child.outputPart...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22239 @maropu Thanks. I just added it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22239: [SPARK-19355][SQL][Followup] Remove the child.outputPart...
Github user maropu commented on the issue: https://github.com/apache/spark/pull/22239 Better to add `in global limit` in the title? Anyway, LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22239: [SPARK-19355][SQL][Followup] Remove the child.outputPart...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22239 Sure, thank you @hvanhovell --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22239: [SPARK-19355][SQL][Followup] Remove the child.outputPart...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/22239 LGTM - Let's wait a little bit with merging to allow others to comment. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22239: [SPARK-19355][SQL][Followup] Remove the child.outputPart...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22239 **[Test build #95273 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95273/testReport)** for PR 22239 at commit [`67ed97d`](https://github.com/apache/spark/commit/67ed97d0ab9ba34c4fef344cbd01a2d20566b70f). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22239: [SPARK-19355][SQL][Followup] Remove the child.outputPart...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22239 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2560/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22239: [SPARK-19355][SQL][Followup] Remove the child.outputPart...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22239 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22239: [SPARK-19355][SQL][Followup] Remove the child.outputPart...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/22239 Setting `spark.sql.limit.flatGlobalLimit` to `false` works for me. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22239: [SPARK-19355][SQL][Followup] Remove the child.outputPart...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22239 @hvanhovell I can set `spark.sql.limit.flatGlobalLimit` to false to match `TakeOrderedAndProjectExec` semantics at the beginning of `TakeOrderedAndProjectSuite`. Or you prefer to add an explicit flag in `GlobalLimitExec` as you mentioned in https://github.com/apache/spark/pull/16677#discussion_r212830045? I think it may not necessarily to add the flag for now. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22239: [SPARK-19355][SQL][Followup] Remove the child.outputPart...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22239 > @viirya did you try to run TakeOrderedAndProjectSuite? I am pretty sure that will fail now ;)... Not yet. Let me try. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22239: [SPARK-19355][SQL][Followup] Remove the child.outputPart...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/22239 cc @cloud-fan for a sanity check. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22239: [SPARK-19355][SQL][Followup] Remove the child.outputPart...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/22239 @viirya did you try to run `TakeOrderedAndProjectSuite`? I am pretty sure that will fail now ;)... --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22239: [SPARK-19355][SQL][Followup] Remove the child.outputPart...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22239 **[Test build #95272 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95272/testReport)** for PR 22239 at commit [`b57634b`](https://github.com/apache/spark/commit/b57634bea6213b67eae896489e913fac685d5a75). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22239: [SPARK-19355][SQL][Followup] Remove the child.outputPart...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22239 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22239: [SPARK-19355][SQL][Followup] Remove the child.outputPart...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22239 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2559/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22239: [SPARK-19355][SQL][Followup] Remove the child.outputPart...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22239 cc @hvanhovell --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
