[GitHub] spark issue #22264: [SPARK-25256][SQL][TEST] Plan mismatch errors in Hive te...
Github user sadhen commented on the issue: https://github.com/apache/spark/pull/22264 @srowen A PR for this "bug" is proposed: https://github.com/scala/scala/pull/7156 Hopefully, Scala 2.12.7 will fix it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22264: [SPARK-25256][SQL][TEST] Plan mismatch errors in Hive te...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22264 Yeah, OK. I think this is acceptable as a potential "known issue" for Scala 2.12 support, which we can accept for a beta release of 2.12 support with Spark 2.4. I think I'd merge this and then see where we are. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22264: [SPARK-25256][SQL][TEST] Plan mismatch errors in Hive te...
Github user sadhen commented on the issue: https://github.com/apache/spark/pull/22264 scala/bug#11123 had been added into https://github.com/scala/bug/milestone/93 . I will spare some time working on it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22264: [SPARK-25256][SQL][TEST] Plan mismatch errors in Hive te...
Github user sadhen commented on the issue:
https://github.com/apache/spark/pull/22264
```
Welcome to
__
/ __/__ ___ _/ /__
_\ \/ _ \/ _ `/ __/ '_/
/___/ .__/\_,_/_/ /_/\_\ version 2.4.0-SNAPSHOT
/_/
Using Scala version 2.12.6 (Java HotSpot(TM) 64-Bit Server VM, Java
1.8.0_112)
Type in expressions to have them evaluated.
Type :help for more information.
scala> val rowOfDoubleWrappedArray = spark.sql("select array(cast (1.0 as
double) , cast(1.0 as double))").collect.head
rowOfDoubleWrappedArray: org.apache.spark.sql.Row = [WrappedArray(1.0, 1.0)]
scala> val rowOfIntWrappedArray = spark.sql("select array(1,
1)").collect.head
rowOfIntWrappedArray: org.apache.spark.sql.Row = [WrappedArray(1, 1)]
scala> rowOfDoubleWrappedArray == rowOfIntWrappedArray
res5: Boolean = false
```
And for Scala 2.11, the result is true.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22264: [SPARK-25256][SQL][TEST] Plan mismatch errors in Hive te...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22264 @sadhen this looks plausible. The fact that it only touches tests makes it low-risk to merge. My only larger concern is: is there a behavior change that will impact user code, that we are merely working around in tests here? I'm OK with getting to a passing 2.12 build that we can release as a 'beta' with some known issues, so this is probably fine to merge as it won't affect 2.11 core functionality. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22264: [SPARK-25256][SQL][TEST] Plan mismatch errors in Hive te...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22264 **[Test build #4309 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4309/testReport)** for PR 22264 at commit [`d7f2e37`](https://github.com/apache/spark/commit/d7f2e3763cfd03f537eaef98a34a5e7eac5d3d6d). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22264: [SPARK-25256][SQL][TEST] Plan mismatch errors in Hive te...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22264 **[Test build #4309 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4309/testReport)** for PR 22264 at commit [`d7f2e37`](https://github.com/apache/spark/commit/d7f2e3763cfd03f537eaef98a34a5e7eac5d3d6d). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22264: [SPARK-25256][SQL][TEST] Plan mismatch errors in Hive te...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22264 **[Test build #4304 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4304/testReport)** for PR 22264 at commit [`d7f2e37`](https://github.com/apache/spark/commit/d7f2e3763cfd03f537eaef98a34a5e7eac5d3d6d). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22264: [SPARK-25256][SQL][TEST] Plan mismatch errors in Hive te...
Github user sadhen commented on the issue: https://github.com/apache/spark/pull/22264 Comment resolved, please review. @srowen @maropu --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22264: [SPARK-25256][SQL][TEST] Plan mismatch errors in Hive te...
Github user maropu commented on the issue: https://github.com/apache/spark/pull/22264 `in 2.12` -> `in Scala 2.12` in the title? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22264: [SPARK-25256][SQL][TEST] Plan mismatch errors in Hive te...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22264 **[Test build #4304 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4304/testReport)** for PR 22264 at commit [`d7f2e37`](https://github.com/apache/spark/commit/d7f2e3763cfd03f537eaef98a34a5e7eac5d3d6d). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22264: [SPARK-25256][SQL][TEST] Plan mismatch errors in Hive te...
Github user sadhen commented on the issue: https://github.com/apache/spark/pull/22264 The fix works for both 2.11 and 2.12. And I reported a bug: https://github.com/scala/bug/issues/11123 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
