[GitHub] spark issue #22359: [SPARK-25313][SQL][FOLLOW-UP] Fix InsertIntoHiveDirComma...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22359 thanks, merging to master/2.4! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22359: [SPARK-25313][SQL][FOLLOW-UP] Fix InsertIntoHiveDirComma...
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/22359 cc @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22359: [SPARK-25313][SQL][FOLLOW-UP] Fix InsertIntoHiveDirComma...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22359 Since this is related to Parquet behavior only, can we have `in Parquet` at the end of title specifically? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22359: [SPARK-25313][SQL][FOLLOW-UP] Fix InsertIntoHiveDirComma...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22359 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95818/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22359: [SPARK-25313][SQL][FOLLOW-UP] Fix InsertIntoHiveDirComma...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22359 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22359: [SPARK-25313][SQL][FOLLOW-UP] Fix InsertIntoHiveDirComma...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22359 **[Test build #95818 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95818/testReport)** for PR 22359 at commit [`71f382b`](https://github.com/apache/spark/commit/71f382bd7c9fdfda38b1bc8063b2a55dd56c00b4). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22359: [SPARK-25313][SQL][FOLLOW-UP] Fix InsertIntoHiveDirComma...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22359 Oh, I it seems to be the Parquet behavior from the beginning of this command at 2.3.0. I was confused because it's different from ORC. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22359: [SPARK-25313][SQL][FOLLOW-UP] Fix InsertIntoHiveDirComma...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22359 @wangyum @gengliangwang Does this PR aim a correct behavior for `INSERT OVERWRITE LOCAL DIRECTORY`? In SPARK-25313, it may make sense because the generated file are under the table and respects the table definition. However, in this PR, this accidentally introduces **case-sensitivity** in SQL SELECT statement. ``` The schema should be StructType(StructField(ID,LongType,true)) as we SELECT ID FROM view1. ``` This case seems to require a new SPARK JIRA issue and more discussion on the goal. Also, this should be allowed only when `spark.sql.caseSensitivity=true`. cc @gatorsmile @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22359: [SPARK-25313][SQL][FOLLOW-UP] Fix InsertIntoHiveDirComma...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22359 **[Test build #95818 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95818/testReport)** for PR 22359 at commit [`71f382b`](https://github.com/apache/spark/commit/71f382bd7c9fdfda38b1bc8063b2a55dd56c00b4). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22359: [SPARK-25313][SQL][FOLLOW-UP] Fix InsertIntoHiveDirComma...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22359 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22359: [SPARK-25313][SQL][FOLLOW-UP] Fix InsertIntoHiveDirComma...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22359 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2941/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org