[GitHub] spark issue #22397: [SPARK-25170][DOC] Add list and short description of Spa...
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/22397 Yes, time unit looks confusing, but not a problem. In general, due to APIs, elapsed time is `ms`, and CPU time is `ns`. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22397: [SPARK-25170][DOC] Add list and short description of Spa...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22397 Merged to master/2.4 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22397: [SPARK-25170][DOC] Add list and short description of Spa...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22397 **[Test build #4340 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4340/testReport)** for PR 22397 at commit [`27130ba`](https://github.com/apache/spark/commit/27130bac74fda2a21dc1443b613c0aee4df1e17a). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22397: [SPARK-25170][DOC] Add list and short description of Spa...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22397 **[Test build #4340 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4340/testReport)** for PR 22397 at commit [`27130ba`](https://github.com/apache/spark/commit/27130bac74fda2a21dc1443b613c0aee4df1e17a). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22397: [SPARK-25170][DOC] Add list and short description of Spa...
Github user LucaCanali commented on the issue: https://github.com/apache/spark/pull/22397 Thanks @srowen for reviewing this. The metrics are commented in the source code of TaskMetrics class, I took most of the descriptions from there, adding some additional explanations where needed. Indeed I agree that the fact that time units are not uniform is a bit incovenient. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22397: [SPARK-25170][DOC] Add list and short description of Spa...
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/22397 LGTM cc @jiangxb1987 @srowen --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22397: [SPARK-25170][DOC] Add list and short description of Spa...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22397 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22397: [SPARK-25170][DOC] Add list and short description of Spa...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22397 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22397: [SPARK-25170][DOC] Add list and short description of Spa...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22397 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
