[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22544 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22544 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3430/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22544 **[Test build #96544 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96544/testReport)** for PR 22544 at commit [`4d32f2c`](https://github.com/apache/spark/commit/4d32f2ce2ff4d5e13c693053041d3111526662cb). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22544 @dilipbiswal The two examples shown in the PR description are allowed in current and this proposes to disallow them? I'm a bit confused by the description. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22544 **[Test build #96544 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96544/testReport)** for PR 22544 at commit [`4d32f2c`](https://github.com/apache/spark/commit/4d32f2ce2ff4d5e13c693053041d3111526662cb). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22544 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96544/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22544 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22544 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3467/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22544 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22544 **[Test build #96603 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96603/testReport)** for PR 22544 at commit [`48eb0ff`](https://github.com/apache/spark/commit/48eb0ff996f48cae49a0ece90160ac5a1251b4b8). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22544 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22544 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96603/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22544 **[Test build #96603 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96603/testReport)** for PR 22544 at commit [`48eb0ff`](https://github.com/apache/spark/commit/48eb0ff996f48cae49a0ece90160ac5a1251b4b8). * This patch **fails due to an unknown error code, -9**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22544 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22544 **[Test build #96611 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96611/testReport)** for PR 22544 at commit [`48eb0ff`](https://github.com/apache/spark/commit/48eb0ff996f48cae49a0ece90160ac5a1251b4b8). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22544 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22544 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3474/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/22544 cc @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22544 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3481/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22544 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22544 **[Test build #96620 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96620/testReport)** for PR 22544 at commit [`2f224f2`](https://github.com/apache/spark/commit/2f224f2710c6adcdf88725a1aef02a2d96437d49). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22544 **[Test build #96611 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96611/testReport)** for PR 22544 at commit [`48eb0ff`](https://github.com/apache/spark/commit/48eb0ff996f48cae49a0ece90160ac5a1251b4b8). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22544 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22544 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96611/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22544 **[Test build #96620 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96620/testReport)** for PR 22544 at commit [`2f224f2`](https://github.com/apache/spark/commit/2f224f2710c6adcdf88725a1aef02a2d96437d49). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22544 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22544 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96620/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22544 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22544 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3498/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22544 **[Test build #96644 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96644/testReport)** for PR 22544 at commit [`9b12969`](https://github.com/apache/spark/commit/9b129698d95c14151b560f16942bda1f06cb4749). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22544 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3511/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22544 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22544 **[Test build #96660 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96660/testReport)** for PR 22544 at commit [`69c78d7`](https://github.com/apache/spark/commit/69c78d7655d0f730f0a72cb8fc98b1491de53da1). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22544 **[Test build #96644 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96644/testReport)** for PR 22544 at commit [`9b12969`](https://github.com/apache/spark/commit/9b129698d95c14151b560f16942bda1f06cb4749). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22544 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96644/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22544 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22544 **[Test build #96660 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96660/testReport)** for PR 22544 at commit [`69c78d7`](https://github.com/apache/spark/commit/69c78d7655d0f730f0a72cb8fc98b1491de53da1). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22544 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22544 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96660/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/22544 @cloud-fan Are we targeting this for 2.4 ? If so, i was wondering if we should make a restricted fix that affects only this function by adding a case in `FunctionArgumentConversion` for 2.4 while keeping this fix for master. Pl. let me know what you think. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22544 I'm merging it to master, please send another PR to 2.4, without touching the `findTightestCommonType`. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/22544 @cloud-fan @ueshin @viirya Thank you very much. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22544 After thinking more, I'm going it to merge it to 2.4 directly, because: 1. `ImplicitTypeCasts` handles array type but not map type, which looks a bug to me 2. I checked all the implementations of `ImplicitCastInputTypes`, `ElementAt` is the only one that sets a concrete map type as the input type. So this change only affects `ElementAt` 3. the test cases added in this PR iterate all the cases and have a very good converage. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/22544 @cloud-fan Sounds good Wenchen. Thanks for the detailed analysis. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
