[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22602 Thank you, @mgaido91 and all. According to the all review comments, I'll merge this to `master` and `branch-2.4`. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22602 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96893/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22602 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22602 **[Test build #96893 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96893/testReport)** for PR 22602 at commit [`be38c4c`](https://github.com/apache/spark/commit/be38c4c47524605c4661333900d7b6f83ae2ce5a). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22602 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96892/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22602 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22602 **[Test build #96892 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96892/testReport)** for PR 22602 at commit [`d7d17d8`](https://github.com/apache/spark/commit/d7d17d8362912978851a55726ed2154435bebb2c). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class UnsafeRowWriterSuite extends SparkFunSuite ` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22602 **[Test build #96893 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96893/testReport)** for PR 22602 at commit [`be38c4c`](https://github.com/apache/spark/commit/be38c4c47524605c4661333900d7b6f83ae2ce5a). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22602 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22602 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3655/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22602 two minor comments. LGTM and good catch! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22602 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3654/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22602 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22602 **[Test build #96892 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96892/testReport)** for PR 22602 at commit [`d7d17d8`](https://github.com/apache/spark/commit/d7d17d8362912978851a55726ed2154435bebb2c). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22602 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96859/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22602 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22602 **[Test build #96859 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96859/testReport)** for PR 22602 at commit [`72b7c5c`](https://github.com/apache/spark/commit/72b7c5c16b33368bb332b168a99e99e13d4636cf). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22602 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96857/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22602 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22602 **[Test build #96857 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96857/testReport)** for PR 22602 at commit [`64f4ed0`](https://github.com/apache/spark/commit/64f4ed0e286d1a01192400203e167d046cb800f5). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/22602 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22602 LGTM, pending jenkins --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22602 **[Test build #96859 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96859/testReport)** for PR 22602 at commit [`72b7c5c`](https://github.com/apache/spark/commit/72b7c5c16b33368bb332b168a99e99e13d4636cf). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22602 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3630/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22602 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22602 **[Test build #96857 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96857/testReport)** for PR 22602 at commit [`64f4ed0`](https://github.com/apache/spark/commit/64f4ed0e286d1a01192400203e167d046cb800f5). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22602 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22602 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3629/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22602 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22602 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96852/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22602 **[Test build #96852 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96852/testReport)** for PR 22602 at commit [`6b84b41`](https://github.com/apache/spark/commit/6b84b41915ae184912922bb820a147060ac13afc). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22602 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22602 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3625/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22602 **[Test build #96852 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96852/testReport)** for PR 22602 at commit [`6b84b41`](https://github.com/apache/spark/commit/6b84b41915ae184912922bb820a147060ac13afc). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22602 thank you all for the reviews! I added the UT according to @cloud-fan's suggestion as I was unable to set up a reasonable the end-to-end UT. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22602 I think we can create a `UnsafeWriterSuite` to do some low-level checking. We can leave the end-to-end test if it's too hard to write. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22602 good catch! LGTM, waiting for the UT. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/22602 Thank you. The first option looks good. Let me think about a good UT, too. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22602 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22602 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96822/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22602 **[Test build #96822 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96822/testReport)** for PR 22602 at commit [`851d723`](https://github.com/apache/spark/commit/851d7235cb2d60af95da3cde6420fea6e63c52d3). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22602: [SPARK-25538][SQL] Zero-out all bytes when writing decim...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/22602 @mgaido91 Could you change the title to [WIP] before you add the test case? Also cc @hvanhovell @kiszk who are the best person to review these code. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
