[GitHub] spark issue #22668: [SPARK-25675] [Spark Job History] Job UI page does not s...

2018-10-23 Thread srowen
Github user srowen commented on the issue:

https://github.com/apache/spark/pull/22668
  
(I did the same thing 2 weeks ago)


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22668: [SPARK-25675] [Spark Job History] Job UI page does not s...

2018-10-23 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/spark/pull/22668
  
ouch sorry


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22668: [SPARK-25675] [Spark Job History] Job UI page does not s...

2018-10-23 Thread gengliangwang
Github user gengliangwang commented on the issue:

https://github.com/apache/spark/pull/22668
  
@srowen I think it is easy fix, let me fix it now.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22668: [SPARK-25675] [Spark Job History] Job UI page does not s...

2018-10-23 Thread srowen
Github user srowen commented on the issue:

https://github.com/apache/spark/pull/22668
  
@shivusondur @felixcheung looks like this test fails: 
https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-master-test-sbt-hadoop-2.7/5070/testReport/org.apache.spark.ui/PagedTableSuite/pageNavigation/

Looks like we didn't get a PR builder test on this one. Easy to fix or 
should we revert temporarily?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22668: [SPARK-25675] [Spark Job History] Job UI page does not s...

2018-10-21 Thread shivusondur
Github user shivusondur commented on the issue:

https://github.com/apache/spark/pull/22668
  
@felixcheung 
Thanks for merging.
My account name in jira is : shivuson...@gmail.com
This issue is assigned to me.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22668: [SPARK-25675] [Spark Job History] Job UI page does not s...

2018-10-21 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/spark/pull/22668
  
@shivusondur 
what's your account name on https://issues.apache.org?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22668: [SPARK-25675] [Spark Job History] Job UI page does not s...

2018-10-21 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/spark/pull/22668
  
merged to master



---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22668: [SPARK-25675] [Spark Job History] Job UI page does not s...

2018-10-14 Thread shivusondur
Github user shivusondur commented on the issue:

https://github.com/apache/spark/pull/22668
  
@felixcheung
OK. Thank you.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22668: [SPARK-25675] [Spark Job History] Job UI page does not s...

2018-10-11 Thread shivusondur
Github user shivusondur commented on the issue:

https://github.com/apache/spark/pull/22668
  
@gengliangwang @felixcheung If everything okay, can you please  merge the 
PR.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22668: [SPARK-25675] [Spark Job History] Job UI page does not s...

2018-10-11 Thread gengliangwang
Github user gengliangwang commented on the issue:

https://github.com/apache/spark/pull/22668
  
LGTM


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22668: [SPARK-25675] [Spark Job History] Job UI page does not s...

2018-10-08 Thread shivusondur
Github user shivusondur commented on the issue:

https://github.com/apache/spark/pull/22668
  
@felixcheung If the user inputs  **rowcount** in **Show** tab such that all 
the rows comes in one page, 
From here on user can't see the pagination and he will not able to inputs 
**rowcount** again to see pagination.
To see pagination, he has to refresh the entire page again.


![1](https://user-images.githubusercontent.com/7912929/46596339-dee4bc80-caf9-11e8-860b-dc5703e49677.PNG)

In the Executors page even in one page it is showing the pagination

![2](https://user-images.githubusercontent.com/7912929/46596468-3f73f980-cafa-11e8-87a0-04b7934b5cdf.PNG)




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22668: [SPARK-25675] [Spark Job History] Job UI page does not s...

2018-10-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22668
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22668: [SPARK-25675] [Spark Job History] Job UI page does not s...

2018-10-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22668
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22668: [SPARK-25675] [Spark Job History] Job UI page does not s...

2018-10-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22668
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org