[GitHub] spark issue #22681: [SPARK-25682][k8s] Package example jars in same target f...

2018-10-18 Thread vanzin
Github user vanzin commented on the issue:

https://github.com/apache/spark/pull/22681
  
Since no one seems interested in actually merging this, merging to master.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22681: [SPARK-25682][k8s] Package example jars in same target f...

2018-10-18 Thread vanzin
Github user vanzin commented on the issue:

https://github.com/apache/spark/pull/22681
  
> I have patched the tests locally to make this configurable

I think it's better to keep the images consistent... either solution still 
lacks the how to enforce that things are working, though, and I don't have a 
solution for that.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22681: [SPARK-25682][k8s] Package example jars in same target f...

2018-10-18 Thread rvesse
Github user rvesse commented on the issue:

https://github.com/apache/spark/pull/22681
  
I actually just got bit by this today while trying to run K8S integration 
tests with custom images.  The integration tests assume the runnable 
distribution layout for `/opt/spark/examples` in the image so if you have built 
your images from a working copy the examples JAR is in the wrong place and the 
integration tests will fail.

Tracking this down is made extra hard by the integration tests deleting 
pods after the tests run so you have to catch the pod status and grab its logs 
before they get cleaned up.

I have patched the tests locally to make this configurable but looks like 
this change should render that unnecessary though I can still submit that patch 
if it sounds like it would be useful?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22681: [SPARK-25682][k8s] Package example jars in same target f...

2018-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22681
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97180/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22681: [SPARK-25682][k8s] Package example jars in same target f...

2018-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22681
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22681: [SPARK-25682][k8s] Package example jars in same target f...

2018-10-09 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/22681
  
**[Test build #97180 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97180/testReport)**
 for PR 22681 at commit 
[`1e0c081`](https://github.com/apache/spark/commit/1e0c08129d697280a646df42cded7c2d1bad8d4d).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22681: [SPARK-25682][k8s] Package example jars in same target f...

2018-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22681
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97178/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22681: [SPARK-25682][k8s] Package example jars in same target f...

2018-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22681
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22681: [SPARK-25682][k8s] Package example jars in same target f...

2018-10-09 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/22681
  
**[Test build #97178 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97178/testReport)**
 for PR 22681 at commit 
[`97e0fe2`](https://github.com/apache/spark/commit/97e0fe2b847e96518f8aeb4cdf6ab7efcdd08dba).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22681: [SPARK-25682][k8s] Package example jars in same target f...

2018-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22681
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22681: [SPARK-25682][k8s] Package example jars in same target f...

2018-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22681
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 

https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3838/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22681: [SPARK-25682][k8s] Package example jars in same target f...

2018-10-09 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/22681
  
Kubernetes integration test status success
URL: 
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/3838/



---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22681: [SPARK-25682][k8s] Package example jars in same target f...

2018-10-09 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/22681
  
Kubernetes integration test starting
URL: 
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/3838/



---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22681: [SPARK-25682][k8s] Package example jars in same target f...

2018-10-09 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/22681
  
**[Test build #97180 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97180/testReport)**
 for PR 22681 at commit 
[`1e0c081`](https://github.com/apache/spark/commit/1e0c08129d697280a646df42cded7c2d1bad8d4d).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22681: [SPARK-25682][k8s] Package example jars in same target f...

2018-10-09 Thread vanzin
Github user vanzin commented on the issue:

https://github.com/apache/spark/pull/22681
  
Ok, looks like this will be a little more complicated. The integration 
tests have references such as `CONTAINER_LOCAL_PYSPARK` which seem to rely on 
the old dev image layout. That might have to change.

I'll look at this later.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22681: [SPARK-25682][k8s] Package example jars in same target f...

2018-10-09 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/22681
  
Kubernetes integration test status failure
URL: 
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/3837/



---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22681: [SPARK-25682][k8s] Package example jars in same target f...

2018-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22681
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 

https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3837/
Test FAILed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22681: [SPARK-25682][k8s] Package example jars in same target f...

2018-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22681
  
Merged build finished. Test FAILed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22681: [SPARK-25682][k8s] Package example jars in same target f...

2018-10-09 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/22681
  
Kubernetes integration test starting
URL: 
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/3837/



---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22681: [SPARK-25682][k8s] Package example jars in same target f...

2018-10-09 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/22681
  
**[Test build #97178 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97178/testReport)**
 for PR 22681 at commit 
[`97e0fe2`](https://github.com/apache/spark/commit/97e0fe2b847e96518f8aeb4cdf6ab7efcdd08dba).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org