[GitHub] spark issue #22794: [SPARK-24570][SQL] Implement Spark own GetTablesOperatio...
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22794 I am not sure what Hive 1.2 exposes, but we might have more, it needs to be checked. Anyway, yes, those have to be overridden for sure. When I referred to the current approach, I meant the one described in the PR description, which seems to be outdated tough. May you please update it? Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22794: [SPARK-24570][SQL] Implement Spark own GetTablesOperatio...
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/22794 @mgaido91 You are right. But may be we only override `newExecuteStatementOperation`, `newGetSchemasOperation`, `newGetTablesOperation`, `newGetTableTypesOperation`,`newGetColumnsOperation` and `newGetFunctionsOperation` is enough. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22794: [SPARK-24570][SQL] Implement Spark own GetTablesOperatio...
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22794 @wangyum the point is that what I meant in the previous comment is that the current approach is not good IMHO. Now you fixed it for the tables, but the same is true for functions: currently you'd be returning Hive's functions, not Spark's right? You should override all of them IMHO... --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22794: [SPARK-24570][SQL] Implement Spark own GetTablesOperatio...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22794 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22794: [SPARK-24570][SQL] Implement Spark own GetTablesOperatio...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22794 **[Test build #98002 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98002/testReport)** for PR 22794 at commit [`80a8d21`](https://github.com/apache/spark/commit/80a8d2153ab5c96fdb9fe7cf54f9f8c60cf930b3). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22794: [SPARK-24570][SQL] Implement Spark own GetTablesOperatio...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22794 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98002/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22794: [SPARK-24570][SQL] Implement Spark own GetTablesOperatio...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22794 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4464/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22794: [SPARK-24570][SQL] Implement Spark own GetTablesOperatio...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22794 **[Test build #98002 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98002/testReport)** for PR 22794 at commit [`80a8d21`](https://github.com/apache/spark/commit/80a8d2153ab5c96fdb9fe7cf54f9f8c60cf930b3). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22794: [SPARK-24570][SQL] Implement Spark own GetTablesOperatio...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22794 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22794: [SPARK-24570][SQL] Implement Spark own GetTablesOperatio...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/22794 cc @srinathshankar --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22794: [SPARK-24570][SQL] Implement Spark own GetTablesOperatio...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22794 **[Test build #97980 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97980/testReport)** for PR 22794 at commit [`e9a2a93`](https://github.com/apache/spark/commit/e9a2a93e47927b26a57b4f62627345ad6cf3d5ed). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22794: [SPARK-24570][SQL] Implement Spark own GetTablesOperatio...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22794 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22794: [SPARK-24570][SQL] Implement Spark own GetTablesOperatio...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22794 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97980/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22794: [SPARK-24570][SQL] Implement Spark own GetTablesOperatio...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22794 **[Test build #97980 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97980/testReport)** for PR 22794 at commit [`e9a2a93`](https://github.com/apache/spark/commit/e9a2a93e47927b26a57b4f62627345ad6cf3d5ed). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22794: [SPARK-24570][SQL] Implement Spark own GetTablesOperatio...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22794 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22794: [SPARK-24570][SQL] Implement Spark own GetTablesOperatio...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22794 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified// Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22794: [SPARK-24570][SQL] Implement Spark own GetTablesOperatio...
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/22794 cc @gatorsmile @srowen @dongjoon-hyun --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22794: [SPARK-24570][SQL] Implement Spark own GetTablesOperatio...
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/22794 Thanks @mgaido91 Changed to `sqlContext.sessionState.catalog` to obtain table names now. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
