[GitHub] spark issue #23130: [SPARK-26161][SQL] Ignore empty files in load
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/23130 We don't need to block it, but @MaxGekk if you have time, it would great to answer https://github.com/apache/spark/pull/23130#issuecomment-442491582 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23130: [SPARK-26161][SQL] Ignore empty files in load
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23130 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99465/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23130: [SPARK-26161][SQL] Ignore empty files in load
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23130 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23130: [SPARK-26161][SQL] Ignore empty files in load
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23130 **[Test build #99465 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99465/testReport)** for PR 23130 at commit [`1f58cc1`](https://github.com/apache/spark/commit/1f58cc1f8265d3f06500870a7e8f8ba3cd0b0872). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23130: [SPARK-26161][SQL] Ignore empty files in load
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23130 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5534/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23130: [SPARK-26161][SQL] Ignore empty files in load
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23130 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23130: [SPARK-26161][SQL] Ignore empty files in load
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23130 **[Test build #99465 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99465/testReport)** for PR 23130 at commit [`1f58cc1`](https://github.com/apache/spark/commit/1f58cc1f8265d3f06500870a7e8f8ba3cd0b0872). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23130: [SPARK-26161][SQL] Ignore empty files in load
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/23130 I think this change makes sense, at least it's good for performance. My only concern is, shall we ask all the parsers to return Nil for empty files? AFAIK JSON doesn't follow it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23130: [SPARK-26161][SQL] Ignore empty files in load
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23130 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23130: [SPARK-26161][SQL] Ignore empty files in load
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23130 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99335/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23130: [SPARK-26161][SQL] Ignore empty files in load
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23130 **[Test build #99335 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99335/testReport)** for PR 23130 at commit [`7057f8b`](https://github.com/apache/spark/commit/7057f8b57223a092241f7b0ecf284b17ca883f6d). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23130: [SPARK-26161][SQL] Ignore empty files in load
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23130 **[Test build #99335 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99335/testReport)** for PR 23130 at commit [`7057f8b`](https://github.com/apache/spark/commit/7057f8b57223a092241f7b0ecf284b17ca883f6d). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23130: [SPARK-26161][SQL] Ignore empty files in load
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23130 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5413/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23130: [SPARK-26161][SQL] Ignore empty files in load
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23130 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23130: [SPARK-26161][SQL] Ignore empty files in load
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/23130 The code change LGTM. There is a mistake in PR description: we updated `FileSourceScanExec` not `DataSourceScanExec`. Let's also mention that this fixed a behavior change introduced by https://github.com/apache/spark/pull/22938 mistakenly. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23130: [SPARK-26161][SQL] Ignore empty files in load
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23130 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23130: [SPARK-26161][SQL] Ignore empty files in load
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23130 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99239/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23130: [SPARK-26161][SQL] Ignore empty files in load
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23130 **[Test build #99239 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99239/testReport)** for PR 23130 at commit [`e7871f3`](https://github.com/apache/spark/commit/e7871f3037591523b7849569cb5f53e916206e8d). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23130: [SPARK-26161][SQL] Ignore empty files in load
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23130 **[Test build #99239 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99239/testReport)** for PR 23130 at commit [`e7871f3`](https://github.com/apache/spark/commit/e7871f3037591523b7849569cb5f53e916206e8d). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23130: [SPARK-26161][SQL] Ignore empty files in load
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23130 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5327/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23130: [SPARK-26161][SQL] Ignore empty files in load
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23130 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23130: [SPARK-26161][SQL] Ignore empty files in load
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23130 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23130: [SPARK-26161][SQL] Ignore empty files in load
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23130 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99227/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23130: [SPARK-26161][SQL] Ignore empty files in load
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23130 **[Test build #99227 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99227/testReport)** for PR 23130 at commit [`b200a50`](https://github.com/apache/spark/commit/b200a50de58641d297381bec45687317bd21dfb7). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23130: [SPARK-26161][SQL] Ignore empty files in load
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23130 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23130: [SPARK-26161][SQL] Ignore empty files in load
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/23130 @cloud-fan @HyukjinKwon Please, take a look at the PR. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23130: [SPARK-26161][SQL] Ignore empty files in load
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23130 **[Test build #99227 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99227/testReport)** for PR 23130 at commit [`b200a50`](https://github.com/apache/spark/commit/b200a50de58641d297381bec45687317bd21dfb7). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23130: [SPARK-26161][SQL] Ignore empty files in load
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23130 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5317/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23130: [SPARK-26161][SQL] Ignore empty files in load
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23130 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
