[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/9571 Could you close this PR please? @steveloughran --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/9571 I'm going to close this PR and start one based on a reapplication of this patch onto master; gets rid of all the merge pain and is intended to be more minimal. The latest comments of this one will be applied --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/9571 > if you'd merged this in earlier: no merge conflicts Well, if you're going to follow that route, if you had addressed feedback earlier, the patch would have been merged long ago... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/9571 > I was secretly hoping you'd just give up on this patch, since it will generate a lot of conflicts with the code I'm working on in parallel.. No. Sorry I do suspect the reviewers of my other outstanding patches are of the same mind "if we ignore him, he'll go away". which is why I'm effectively giving up filing new patches and bug reports related to Spark. However, that doesn't mean that I'm going to stop updating and reminding people of my current set of patches. It's easier to accept them and hope I'll go away afterwards. After all, if you'd merged this in earlier: no merge conflicts. Better all round. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/9571 Line lengths fixed, tests all happy. @vanzin âany chance of adding this to your review list? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9571 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75708/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9571 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9571 **[Test build #75708 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75708/testReport)** for PR 9571 at commit [`8903dcf`](https://github.com/apache/spark/commit/8903dcfe2b927c8fc3fed9df3e9939670a016944). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9571 **[Test build #75708 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75708/testReport)** for PR 9571 at commit [`8903dcf`](https://github.com/apache/spark/commit/8903dcfe2b927c8fc3fed9df3e9939670a016944). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9571 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9571 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75704/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9571 **[Test build #75704 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75704/testReport)** for PR 9571 at commit [`ec1f2d7`](https://github.com/apache/spark/commit/ec1f2d7f8743ce6de3e83f2f9a82f1c940c8be52). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9571 **[Test build #75704 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75704/testReport)** for PR 9571 at commit [`ec1f2d7`](https://github.com/apache/spark/commit/ec1f2d7f8743ce6de3e83f2f9a82f1c940c8be52). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9571 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/9571 Style police. FWIW I think the lines that failed were already >100 chars, it was just they got indented slightly more. ``` Scalastyle checks failed at following occurrences: [error] /home/jenkins/workspace/SparkPullRequestBuilder/core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala:275: File line length exceeds 100 characters [error] /home/jenkins/workspace/SparkPullRequestBuilder/core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala:283: File line length exceeds 100 characters [error] /home/jenkins/workspace/SparkPullRequestBuilder/core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala:284: File line length exceeds 100 characters [error] /home/jenkins/workspace/SparkPullRequestBuilder/core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala:498: File line length exceeds 100 characters ``` will fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9571 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73695/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9571 **[Test build #73695 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73695/testReport)** for PR 9571 at commit [`d8ae876`](https://github.com/apache/spark/commit/d8ae876505de9599480929905f88612dcbc3905b). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9571 **[Test build #73695 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73695/testReport)** for PR 9571 at commit [`d8ae876`](https://github.com/apache/spark/commit/d8ae876505de9599480929905f88612dcbc3905b). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9571 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9571 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64651/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9571 **[Test build #64651 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64651/consoleFull)** for PR 9571 at commit [`1c750b5`](https://github.com/apache/spark/commit/1c750b50cca7e17ebe5950592732ff4ceae7cf2b). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9571 **[Test build #64651 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64651/consoleFull)** for PR 9571 at commit [`1c750b5`](https://github.com/apache/spark/commit/1c750b50cca7e17ebe5950592732ff4ceae7cf2b). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/9571 sorry, didn't see that one. Will fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9571 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9571 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64586/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9571 **[Test build #64586 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64586/consoleFull)** for PR 9571 at commit [`d39996a`](https://github.com/apache/spark/commit/d39996aaabcc0de873bf410eeed6448d6d259c42). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/9571 @steveloughran you still have not addressed my comment about `appUiLoadTimer`. The metric is still being registered even though it doesn't make any sense to the user. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9571 **[Test build #64586 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64586/consoleFull)** for PR 9571 at commit [`d39996a`](https://github.com/apache/spark/commit/d39996aaabcc0de873bf410eeed6448d6d259c42). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/9571 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/9571 Test failures timeout related; unlikely to be due to this patch ``` Test Result (2 failures / +2) org.apache.spark.sql.hive.HiveSparkSubmitSuite.dir org.apache.spark.sql.hive.HiveSparkSubmitSuite.dir ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9571 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64531/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9571 **[Test build #64531 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64531/consoleFull)** for PR 9571 at commit [`d39996a`](https://github.com/apache/spark/commit/d39996aaabcc0de873bf410eeed6448d6d259c42). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9571 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9571 **[Test build #64531 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64531/consoleFull)** for PR 9571 at commit [`d39996a`](https://github.com/apache/spark/commit/d39996aaabcc0de873bf410eeed6448d6d259c42). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9571 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9571 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64359/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9571 **[Test build #64359 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64359/consoleFull)** for PR 9571 at commit [`745d532`](https://github.com/apache/spark/commit/745d532b67b64149e86d2fdf0464cab616023eac). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/9571 Looks ok but there's one comment you haven't addressed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9571 **[Test build #64359 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64359/consoleFull)** for PR 9571 at commit [`745d532`](https://github.com/apache/spark/commit/745d532b67b64149e86d2fdf0464cab616023eac). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9571 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63864/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9571 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9571 **[Test build #63864 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63864/consoleFull)** for PR 9571 at commit [`745d532`](https://github.com/apache/spark/commit/745d532b67b64149e86d2fdf0464cab616023eac). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9571 **[Test build #63864 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63864/consoleFull)** for PR 9571 at commit [`745d532`](https://github.com/apache/spark/commit/745d532b67b64149e86d2fdf0464cab616023eac). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/9571 A few minor things left. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9571 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62321/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9571 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9571 **[Test build #62321 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62321/consoleFull)** for PR 9571 at commit [`4b2046f`](https://github.com/apache/spark/commit/4b2046fd47d58bc5814f6271aa1d67a6cdd0918c). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9571 **[Test build #62321 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62321/consoleFull)** for PR 9571 at commit [`4b2046f`](https://github.com/apache/spark/commit/4b2046fd47d58bc5814f6271aa1d67a6cdd0918c). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/9571 This patch adds separate average values of the load times vs merge times per event; this shows ~2x difference in replay from load in the test case., These `.time` gauges are little lambda expressions evaluated whenever the gauge value is extracted; they divide the total load/merge durations by the event count. The Timer metrics don't provide enough data here, because they support various decaying reservoirs/windows for their time values, not whole-life-of-app durations. There's some base class metric support for registration (everything is prefixed) and testability. There's now tests in `HistoryServerSuite."incomplete apps get refreshed"` for metrics being in the dumped list, and for specific values, especially averages (that they increase, that they don't trigger division-by-0 exceptions before there have been any loads) This is what the metrics look like after the tests (from a log of the toString value). The `.last.attempted` values are `System.currentTimeMillis` timestamps of the operations. I'd considered a "time-since" gauge, but after some offline discussion with Allen Wittenauer, went for the absolute values; I'll leave to to the management tooling to work out elapsed times from absolute values if they want to use that for alerts or UIs. ``` 16/07/14 14:17:03.837 ScalaTest-main-running-HistoryServerSuite INFO HistoryServerSuite: Metrics: Metrics for history: Counters Gauges Metrics for history.fs: Counters history.provider.appui.event.count = 103 history.provider.appui.load.count = 6 history.provider.appui.load.duration = 38244482 history.provider.appui.load.failure.count = 0 history.provider.appui.load.not-found.count = 0 history.provider.history.merge.duration = 16138193 history.provider.history.merge.event.count = 83 history.provider.update.count = 5 history.provider.update.failure.count = 0 Gauges history.provider.appui.event.replay.time = 371305 history.provider.history.merge.event.time = 194436 history.provider.update.last.attempted = 1468502223726 history.provider.update.last.succeeded = 1468502223000 Metrics for application.cache: Counters history.cache.eviction.count = 3 history.cache.load.count = 4 history.cache.lookup.count = 58 history.cache.lookup.failure.count = 0 history.cache.update.probe.count = 57 history.cache.update.triggered.count = 3 Gauges ``` One thing to consider: gauges of the number of complete and incomplete applications? I know the REST UI gives this, but only indirectly (you call, you count the size of the lists). Doing it in the metrics provides something that could be monitored or probed in tests without making REST calls. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9571 **[Test build #62320 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62320/consoleFull)** for PR 9571 at commit [`0b8db8b`](https://github.com/apache/spark/commit/0b8db8b285bfcc73e861a92303206f670ea40de1). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9571 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62320/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9571 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9571 **[Test build #62320 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62320/consoleFull)** for PR 9571 at commit [`0b8db8b`](https://github.com/apache/spark/commit/0b8db8b285bfcc73e861a92303206f670ea40de1). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9571 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62319/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9571 **[Test build #62319 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62319/consoleFull)** for PR 9571 at commit [`3971241`](https://github.com/apache/spark/commit/39712419d463bface2027fb7888f2c40f26fa412). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9571 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9571 **[Test build #62319 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62319/consoleFull)** for PR 9571 at commit [`3971241`](https://github.com/apache/spark/commit/39712419d463bface2027fb7888f2c40f26fa412). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9571 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9571 **[Test build #62318 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62318/consoleFull)** for PR 9571 at commit [`6e7f466`](https://github.com/apache/spark/commit/6e7f466da0681af2c40a6842ed6c542ca44c7bd5). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9571 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62318/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9571 **[Test build #62318 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62318/consoleFull)** for PR 9571 at commit [`6e7f466`](https://github.com/apache/spark/commit/6e7f466da0681af2c40a6842ed6c542ca44c7bd5). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/9571 One other metric set I'm thinking of relates to a JIRA on app UIs not being visible: making the time of last scan a metric, both as an epoch time and diff from current time. That would let a management tool keep track of the scan history, maybe even show alerts if things are out of date. At the very least, if there are support calls, *and someone were to add the coda hale metrics servlets* then users could point their browsers at the metrics page and get a lump of JSON to paste into JIRAs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9571 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9571 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60296/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9571 **[Test build #60296 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60296/consoleFull)** for PR 9571 at commit [`5eb5360`](https://github.com/apache/spark/commit/5eb536023c0d363728911487942d47fec2e99fb7). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user steveloughran commented on the issue:
https://github.com/apache/spark/pull/9571
Updated patch. Addresses indentation, found and eliminated one more call to
{{initialize()}} outside of constructor.
Adds a whole new counter, `event.replay.count`, which counts the number of
events replayed during load or attempt merge. I'm not trying to be clever about
deriving playback rate or anything, as it could get complex with the
merge/update listings being included. However, including those playback events
could be useful in identifying why startup was slow, or why updates are taking
a while to surface.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #9571: [SPARK-11373] [CORE] Add metrics to the History Server an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9571 **[Test build #60296 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60296/consoleFull)** for PR 9571 at commit [`5eb5360`](https://github.com/apache/spark/commit/5eb536023c0d363728911487942d47fec2e99fb7). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
