[GitHub] spark pull request: [CORE][minor] enhance the `toArray` method in ...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4825#issuecomment-76921315 It's really minor, but if you wouldn't mind making a JIRA, that'd be a little more by-the-book here. I can resolve it rapidly. We usually skip JIRAs where the problem and solution are all but identical. That's almost true here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [CORE][minor] enhance the `toArray` method in ...
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/4825#issuecomment-76874814 hi @srowen , is it ready to go? or should I create a JIRA for it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [CORE][minor] enhance the `toArray` method in ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4825#issuecomment-76717563 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28170/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [CORE][minor] enhance the `toArray` method in ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4825#issuecomment-76717549 [Test build #28170 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28170/consoleFull) for PR 4825 at commit [`c933ee5`](https://github.com/apache/spark/commit/c933ee58048f8cfb9d4ad30531a285b94f6eb163). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [CORE][minor] enhance the `toArray` method in ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4825#issuecomment-76706002 [Test build #28170 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28170/consoleFull) for PR 4825 at commit [`c933ee5`](https://github.com/apache/spark/commit/c933ee58048f8cfb9d4ad30531a285b94f6eb163). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [CORE][minor] enhance the `toArray` method in ...
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4825#discussion_r25585834
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/SizeTrackingVector.scala
---
@@ -41,6 +41,6 @@ private[spark] class SizeTrackingVector[T: ClassTag]
* Return a trimmed version of the underlying array.
*/
def toArray: Array[T] = {
-super.iterator.toArray
+super.copyArrayWithLength(size)
--- End diff --
Hm, could this method also just be in the parent? it doesn't seem specific
to the subclass even.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [CORE][minor] enhance the `toArray` method in ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4825#issuecomment-76523388 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28126/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [CORE][minor] enhance the `toArray` method in ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4825#issuecomment-76523385 [Test build #28126 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28126/consoleFull) for PR 4825 at commit [`946a35b`](https://github.com/apache/spark/commit/946a35bfef2a746a4e4fa44c62df70031677d217). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [CORE][minor] enhance the `toArray` method in ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4825#issuecomment-76521108 [Test build #28126 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28126/consoleFull) for PR 4825 at commit [`946a35b`](https://github.com/apache/spark/commit/946a35bfef2a746a4e4fa44c62df70031677d217). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [CORE][minor] enhance the `toArray` method in ...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4825#issuecomment-76521065 Seems fine, though I am wondering if this is of a significance that needs a quick JIRA to track. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [CORE][minor] enhance the `toArray` method in ...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4825#issuecomment-76521039 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [CORE][minor] enhance the `toArray` method in ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4825#issuecomment-76512123 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [CORE][minor] enhance the `toArray` method in ...
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/4825 [CORE][minor] enhance the `toArray` method in `SizeTrackingVector` Use array copy instead of `Iterator#toArray` to make it more efficient. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloud-fan/spark minor Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/4825.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4825 commit 946a35bfef2a746a4e4fa44c62df70031677d217 Author: Wenchen Fan Date: 2015-02-16T09:42:38Z minor enhance --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
