[GitHub] spark pull request: [Core] whitespace fixes in RangePartitioner
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/8480#issuecomment-135366372 Yes, I think that commit was to pass style checks though. I assume this doesn't fail anything? I mean, I don't mind just merging this, but in my personal opinion I'd like to lightly push back on very small non-functional changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Core] whitespace fixes in RangePartitioner
GitHub user ihainan opened a pull request: https://github.com/apache/spark/pull/8480 [Core] whitespace fixes in RangePartitioner Just a trivial change so I didn't create a corresponding JIRA issue. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ihainan/spark whitespace_fixes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/8480.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #8480 commit b6f25cd1a32a28da19f37940e3874ca66dd545d1 Author: ihainan ihaina...@gmail.com Date: 2015-08-27T09:07:49Z whitespace fixes in RangePartitioner --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Core] whitespace fixes in RangePartitioner
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8480#issuecomment-135362602 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Core] whitespace fixes in RangePartitioner
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/8480#issuecomment-135363484 I think this is too trivial even for a PR. This doesn't fail style checks right? this isn't worth everyone's cycles. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Core] whitespace fixes in RangePartitioner
Github user ihainan commented on the pull request: https://github.com/apache/spark/pull/8480#issuecomment-135365303 @srowen Thanks for your suggestion. There was a [similar commit](https://github.com/apache/spark/commit/7f7505d8db7759ea46e904f767c23130eff1104a) before and I just want to make the code more consistent. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
