[GitHub] spark pull request: [ML][Minor] update transformSchema methods of ...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6433#issuecomment-168112843 I'm going to close this pull request. If this is still relevant and you are interested in pushing it forward, please open a new pull request. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [ML][Minor] update transformSchema methods of ...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/6433 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [ML][Minor] update transformSchema methods of ...
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/6433#issuecomment-121718182 Ping @RoyGao --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [ML][Minor] update transformSchema methods of ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6433#issuecomment-121072404 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [ML][Minor] update transformSchema methods of ...
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/6433#issuecomment-117799019 @RoyGao Could you please create a JIRA and add it to this PR's title? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [ML][Minor] update transformSchema methods of ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6433#issuecomment-105827412 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [ML][Minor] update transformSchema methods of ...
GitHub user RoyGao opened a pull request: https://github.com/apache/spark/pull/6433 [ML][Minor] update transformSchema methods of StandardScaler When I wrote unit test for StandScaler, I found transformSchema method of StandardScaler different from other algorithm such IDF\StringIndexer and so on. Then I add validateAndTransformSchema method like other estimator. You can merge this pull request into a Git repository by running: $ git pull https://github.com/RoyGao/spark temp Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/6433.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6433 commit 5b93a11e4b107a8f5923dd232f44d0f877cafdd4 Author: RoyGaoVLIS roy...@zju.edu.cn Date: 2015-05-27T08:36:30Z update transformSchema methods of standardScaler --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [ML][Minor] update transformSchema methods of ...
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/6433#discussion_r31171364
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StandardScaler.scala ---
@@ -48,6 +48,16 @@ private[feature] trait StandardScalerParams extends
Params with HasInputCol with
* @group param
*/
val withStd: BooleanParam = new BooleanParam(this, withStd, Scale to
unit standard deviation)
+
+ protected def validateAndTransformSchema(schema: StructType): StructType
= {
+val inputType = schema($(inputCol)).dataType
--- End diff --
This could be further simplified by using the SchemaUtils from `ml.util`.
See:
https://github.com/apache/spark/blob/836a75898fdc4b10d4d00676ef29e24cc96f09fd/mllib/src/main/scala/org/apache/spark/ml/feature/IDF.scala#L55
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
