[GitHub] spark pull request: [SPARK-10012][ML] Missing test case for Params...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/8223#issuecomment-132495472 I like the caution on 1.5; master should be safe in any event. It's my impression that in the QA period new tests (which pass) are pretty freely mergeable. Maybe I should send around an email about the consensus on that to make sure we're operating similarly. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10012][ML] Missing test case for Params...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8223 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10012][ML] Missing test case for Params...
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/8223#issuecomment-132375517 No, just trying not merge stuff which isn't critical, but sure, I'll merge it with master and branch-1.5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10012][ML] Missing test case for Params...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/8223#issuecomment-132365457 @jkbradley do we need to wait for something here? things can go into `master` safely; this looks safe for `branch-1.5` too regardless of whether it makes this RC or another release. Did I miss some email about an RC and not merging? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10012][ML] Missing test case for Params...
Github user Lewuathe commented on the pull request: https://github.com/apache/spark/pull/8223#issuecomment-132174680 @jkbradley OK, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10012][ML] Missing test case for Params...
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/8223#issuecomment-131994568 LGTM, but I'll wait to merge with master until after the RC is cut --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10012][ML] Missing test case for Params...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8223#issuecomment-131489901 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10012][ML] Missing test case for Params...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8223#issuecomment-131489903 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40981/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10012][ML] Missing test case for Params...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8223#issuecomment-131489891 [Test build #40981 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40981/console) for PR 8223 at commit [`5da7c34`](https://github.com/apache/spark/commit/5da7c3493fb7c6e31f974c78a2226f5ee96bfeae). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10012][ML] Missing test case for Params...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8223#issuecomment-131487366 [Test build #40981 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40981/consoleFull) for PR 8223 at commit [`5da7c34`](https://github.com/apache/spark/commit/5da7c3493fb7c6e31f974c78a2226f5ee96bfeae). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10012][ML] Missing test case for Params...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8223#issuecomment-131485801 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10012][ML] Missing test case for Params...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8223#issuecomment-131485769 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10012][ML] Missing test case for Params...
GitHub user Lewuathe opened a pull request: https://github.com/apache/spark/pull/8223 [SPARK-10012][ML] Missing test case for Params#arrayLengthGt Currently there is no test case for `Params#arrayLengthGt`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Lewuathe/spark SPARK-10012 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/8223.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #8223 commit 5da7c3493fb7c6e31f974c78a2226f5ee96bfeae Author: lewuathe Date: 2015-08-16T03:21:52Z Missing test case for Params#arrayLengthGt --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
