[GitHub] spark pull request: [SPARK-10019][MLlib]: ML model broadcasts shou...

2015-09-11 Thread sabhyankar
Github user sabhyankar closed the pull request at:

https://github.com/apache/spark/pull/8248


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-10019][MLlib]: ML model broadcasts shou...

2015-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/8248#issuecomment-135469126
  
Merged build started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-10019][MLlib]: ML model broadcasts shou...

2015-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/8248#issuecomment-135469085
  
 Merged build triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-10019][MLlib]: ML model broadcasts shou...

2015-08-27 Thread sabhyankar
Github user sabhyankar commented on the pull request:

https://github.com/apache/spark/pull/8248#issuecomment-135506704
  
@mengxr I am going to update PRs #8248 #8247 #8243 #8241 and #8249 after PR 
#8241 is merged to trunk. This is needed because we want to use the common 
trait (Broadcastable) that is added in #8241 for the other PRs. 

FYI @feynmanliang @jkbradley 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-10019][MLlib]: ML model broadcasts shou...

2015-08-27 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/8248#issuecomment-135469762
  
  [Test build #41694 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41694/consoleFull)
 for   PR 8248 at commit 
[`98fa159`](https://github.com/apache/spark/commit/98fa1595360c511555b7183b811387204975e46f).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-10019][MLlib]: ML model broadcasts shou...

2015-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/8248#issuecomment-135481463
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41694/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-10019][MLlib]: ML model broadcasts shou...

2015-08-27 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/8248#issuecomment-135481244
  
  [Test build #41694 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41694/console)
 for   PR 8248 at commit 
[`98fa159`](https://github.com/apache/spark/commit/98fa1595360c511555b7183b811387204975e46f).
 * This patch **passes all tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-10019][MLlib]: ML model broadcasts shou...

2015-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/8248#issuecomment-135481460
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-10019][MLlib]: ML model broadcasts shou...

2015-08-27 Thread mengxr
Github user mengxr commented on the pull request:

https://github.com/apache/spark/pull/8248#issuecomment-135468837
  
ok to test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-10019][MLlib]: ML model broadcasts shou...

2015-08-24 Thread feynmanliang
Github user feynmanliang commented on the pull request:

https://github.com/apache/spark/pull/8248#issuecomment-134410452
  
Can you close this and include changes with #8249 ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-10019][MLlib]: ML model broadcasts shou...

2015-08-17 Thread sabhyankar
GitHub user sabhyankar opened a pull request:

https://github.com/apache/spark/pull/8248

[SPARK-10019][MLlib]: ML model broadcasts should be stored in private vars: 
mllib IDFModel

ML model broadcasts should be stored in private vars: mllib IDFModel.
Applies to: spark.mllib.feature.IDFModel

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sabhyankar/spark spark_10019

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/8248.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #8248


commit 6bf0bec3b2c511622e259c5bed21fdb4e015dda6
Author: Sameer Abhyankar sabhyankar@sabhyankar-mbp.samavihome
Date:   2015-08-17T20:13:21Z

Add private var to store broadcast variable




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-10019][MLlib]: ML model broadcasts shou...

2015-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/8248#issuecomment-131947771
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org