[GitHub] spark pull request: [SPARK-10172][core]Fix for HistoryServer webUI...

[josiahsams]

Github user josiahsams closed the pull request at:

https://github.com/apache/spark/pull/8506


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-10172][core]Fix for HistoryServer webUI...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/8506#issuecomment-140697603
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-10172][core]Fix for HistoryServer webUI...

[josiahsams]

Github user josiahsams commented on the pull request:

https://github.com/apache/spark/pull/8506#issuecomment-140697439
  
I pushed a wrong commit and I'm reopening the pull request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-10172][core]Fix for HistoryServer webUI...

[josiahsams]

GitHub user josiahsams reopened a pull request:

https://github.com/apache/spark/pull/8506

[SPARK-10172][core]Fix for HistoryServer webUI mess up during sorting

This pull request is to address the JIRA SPARK-10172 (History Server web UI 
gets messed up when sorting on any column). 
The fix will avoid the use of rowspan during table creation in the web UI, 
when there are multiple attempts for a job. 
By avoiding the rowspan, the table won't get messed up during the column 
sort. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ibmsoe/spark SPARK-10172

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/8506.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #8506


commit 70eeabd74e211aa11c9188e350e24e6ba21cb66e
Author: Josiah Samuel 
Date:   2015-09-16T10:18:15Z

[SPARK-10172] [core]disable sort in HistoryServer webUI




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-10172][core]Fix for HistoryServer webUI...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/8506#issuecomment-140800364
  
  [Test build #42537 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42537/consoleFull)
 for   PR 8506 at commit 
[`1c59089`](https://github.com/apache/spark/commit/1c59089f2bf04a6d4acae1cc7a05322077786e82).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-10172][core]Fix for HistoryServer webUI...

[vanzin]

Github user vanzin commented on the pull request:

https://github.com/apache/spark/pull/8506#issuecomment-140797672
  
ok to test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-10172][core]Fix for HistoryServer webUI...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/8506#issuecomment-140798087
  
 Merged build triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-10172][core]Fix for HistoryServer webUI...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/8506#issuecomment-140798129
  
Merged build started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-10172][core]Fix for HistoryServer webUI...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/8506#issuecomment-140855596
  
  [Test build #42537 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42537/console)
 for   PR 8506 at commit 
[`1c59089`](https://github.com/apache/spark/commit/1c59089f2bf04a6d4acae1cc7a05322077786e82).
 * This patch **fails PySpark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-10172][core]Fix for HistoryServer webUI...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/8506#issuecomment-140855760
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42537/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-10172][core]Fix for HistoryServer webUI...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/8506#issuecomment-140855754
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-10172][core]Fix for HistoryServer webUI...

[vanzin]

Github user vanzin commented on the pull request:

https://github.com/apache/spark/pull/8506#issuecomment-140813980
  
LGTM after tests. Could you update the title and description of the PR to 
reflect the new changes?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-10172][core]Fix for HistoryServer webUI...

[josiahsams]

Github user josiahsams commented on the pull request:

https://github.com/apache/spark/pull/8506#issuecomment-140344311
  
@vanzin, I tried tablesorter jquery plugin and figured out there are no way 
to sort the childrows out of the box. Still exploring all the customization. In 
this approach, I'm suspecting lot of code changes and new scripts and css 
additions as the table creation in Spark UI is done in a generic way. 

But we need to take a decision whether its worth putting that much effort 
for this issue (or) simply make the table non-sortable(only in case of multiple 
attempts) as suggested by you. 

Waiting for your reply for this one.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-10172][core]Fix for HistoryServer webUI...

[vanzin]

Github user vanzin commented on the pull request:

https://github.com/apache/spark/pull/8506#issuecomment-140459166
  
I'm wondering if there's much benefit from having sorting at all in this 
table, regardless of multiple attempts or not. There are limited entries per 
page (20 I think), which is not bad. Sorting is not maintained across pages; 
and is not really aware that there are multiple pages. So it sorts only the 
current list, not the complete list of applications. The behavior ends up being 
a little weird.

Personally I wouldn't miss sorting in the current implementation. It might 
be worth it to refactor this page so that it's more dynamic instead of relying 
on the HTML code embedded in Scala, and then have better sorting, but that's a 
much bigger effort.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-10172][core]Fix for HistoryServer webUI...

[vanzin]

Github user vanzin commented on the pull request:

https://github.com/apache/spark/pull/8506#issuecomment-140177002
  
Hi @josiahsams,

I played a little with this and it seems like it would be rather easy to 
get both rowspan and sorting working using jQuery's table sorter plugin: 
https://mottie.github.io/tablesorter/docs/index.html

After I added the necessary code, all I needed to do was add 
`class="tablesorter-childRow"` to the child rows and the plugin sorts things 
correctly.

Would you be willing to take a stab at using that to sort the table 
instead? I really don't like losing the link between the app and its attempts.

There might be some added complexity to do things correctly; for example, 
if I understand correctly, my quick hack only sorts based on the most recent 
attempt's information, so for example when sorting based on start time, the 
sort order wouldn't be correct.

Another approach is to remove sorting altogether. Since sorting is based on 
just the current page, and the current page doesn't really have that many 
entries, sorting isn't super useful to start with.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-10172][core]Fix for HistoryServer webUI...

[josiahsams]

Github user josiahsams commented on the pull request:

https://github.com/apache/spark/pull/8506#issuecomment-140018832
  
@vanzin , As you rightly pointed out, I have removed the row level grouping 
(rowspan) based on the Attempt ID, as the current javascript library used for 
sorting table "sorttable.js" messes up the table data during sorting. For that 
matter, as far as I know, no stable table sort logic out there that can support 
rowspan. 

But we can definitely try out workarounds like, creating inner tables 
inside the cells for each column and make that table data non-sortable. This 
will call for more code  changes but will result in having more non-sortable 
fields.

So in order to keep things simple, I removed "rowspan" from the equation, 
and made the "App ID" field to show values(links will be different based on the 
attempt ID) for every attempt made.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-10172][core]Fix for HistoryServer webUI...

[vanzin]

Github user vanzin commented on the pull request:

https://github.com/apache/spark/pull/8506#issuecomment-139051150
  
@josiahsams sorry for the delay. Do you have a screenshot of this? From the 
code it seems like the app information will be repeated, and there will be no 
visual aid indicating that the different attempts belong to the same app (which 
is what the rowspan did).

I'm not sure how the sorting is done on the javascript side, but is there a 
rowspan-aware sort that could be used instead?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-10172][core]Fix for HistoryServer webUI...

[andrewor14]

Github user andrewor14 commented on the pull request:

https://github.com/apache/spark/pull/8506#issuecomment-136838302
  
@vanzin could you take a look?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-10172][core]Fix for HistoryServer webUI...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/8506#issuecomment-135745326
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-10172][core]Fix for HistoryServer webUI...

[josiahsams]

GitHub user josiahsams opened a pull request:

https://github.com/apache/spark/pull/8506

[SPARK-10172][core]Fix for HistoryServer webUI mess up during sorting

This pull request is to address the JIRA SPARK-10172 (History Server web UI 
gets messed up when sorting on any column). 
The fix will avoid the use of rowspan during table creation in the web UI, 
when there are multiple attempts for a job. 
By avoiding the rowspan, the table won't get messed up during the column 
sort. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ibmsoe/spark SPARK-10172

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/8506.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #8506


commit 521f1d6130261e84ba37d6c96f459f6219a3973d
Author: Josiah Samuel josiah_s...@in.ibm.com
Date:   2015-08-26T11:08:46Z

[SPARK-10172][core]Fix for HistoryServer webUI mess up during sorting




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org