[GitHub] spark pull request: [SPARK-10254][ML]Removes Guava dependencies in...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8445 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10254][ML]Removes Guava dependencies in...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8445#issuecomment-134850439 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10254][ML]Removes Guava dependencies in...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8445#issuecomment-134850445 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41600/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10254][ML]Removes Guava dependencies in...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8445#issuecomment-134850117 [Test build #41600 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41600/console) for PR 8445 at commit [`24f9282`](https://github.com/apache/spark/commit/24f9282ac1751a3a354bacd7ae15bcab119e8448). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10254][ML]Removes Guava dependencies in...
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/8445#discussion_r37951330 --- Diff: mllib/src/test/java/org/apache/spark/ml/feature/JavaBucketizerSuite.java --- @@ -17,7 +17,8 @@ package org.apache.spark.ml.feature; -import com.google.common.collect.Lists; +import java.util.Arrays; --- End diff -- organize imports --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10254][ML]Removes Guava dependencies in...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8445#issuecomment-134869361 LGTM except that imports needs to be organized. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10254][ML]Removes Guava dependencies in...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8445#issuecomment-135113230 [Test build #41637 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41637/consoleFull) for PR 8445 at commit [`ad78585`](https://github.com/apache/spark/commit/ad78585c51b0e9c9508b09e14311f0128764a419). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10254][ML]Removes Guava dependencies in...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8445#issuecomment-135124514 [Test build #41637 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41637/console) for PR 8445 at commit [`ad78585`](https://github.com/apache/spark/commit/ad78585c51b0e9c9508b09e14311f0128764a419). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10254][ML]Removes Guava dependencies in...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8445#issuecomment-135112314 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10254][ML]Removes Guava dependencies in...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8445#issuecomment-135112289 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10254][ML]Removes Guava dependencies in...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8445#issuecomment-135124777 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41637/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10254][ML]Removes Guava dependencies in...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8445#issuecomment-135124774 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10254][ML]Removes Guava dependencies in...
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8445#discussion_r38008456 --- Diff: mllib/src/test/java/org/apache/spark/ml/feature/JavaTokenizerSuite.java --- @@ -29,6 +29,8 @@ import org.apache.spark.sql.Row; import org.apache.spark.sql.SQLContext; +import java.util.Arrays; --- End diff -- Thanks, fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10254][ML]Removes Guava dependencies in...
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8445#discussion_r37953240 --- Diff: mllib/src/test/java/org/apache/spark/ml/feature/JavaBucketizerSuite.java --- @@ -17,7 +17,8 @@ package org.apache.spark.ml.feature; -import com.google.common.collect.Lists; +import java.util.Arrays; --- End diff -- What is the correct import order for java? I followed the scala import guidelines here --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10254][ML]Removes Guava dependencies in...
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/8445#discussion_r37993752 --- Diff: mllib/src/test/java/org/apache/spark/ml/feature/JavaTokenizerSuite.java --- @@ -29,6 +29,8 @@ import org.apache.spark.sql.Row; import org.apache.spark.sql.SQLContext; +import java.util.Arrays; --- End diff -- Sorry, I meant this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10254][ML]Removes Guava dependencies in...
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/8445#discussion_r37993802 --- Diff: mllib/src/test/java/org/apache/spark/ml/feature/JavaBucketizerSuite.java --- @@ -17,7 +17,8 @@ package org.apache.spark.ml.feature; -import com.google.common.collect.Lists; +import java.util.Arrays; --- End diff -- Sorry, wrong line. See my comment below. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10254][ML]Removes Guava dependencies in...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8445#issuecomment-134813519 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10254][ML]Removes Guava dependencies in...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8445#issuecomment-134834688 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10254][ML]Removes Guava dependencies in...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8445#issuecomment-134825032 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10254][ML]Removes Guava dependencies in...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8445#issuecomment-134834703 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10254][ML]Removes Guava dependencies in...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8445#issuecomment-134835295 [Test build #41600 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41600/consoleFull) for PR 8445 at commit [`24f9282`](https://github.com/apache/spark/commit/24f9282ac1751a3a354bacd7ae15bcab119e8448). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10254][ML]Removes Guava dependencies in...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8445#issuecomment-134813472 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10254][ML]Removes Guava dependencies in...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8445#issuecomment-134814967 [Test build #41585 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41585/consoleFull) for PR 8445 at commit [`a0a4dca`](https://github.com/apache/spark/commit/a0a4dca944cab07c44ca865db5253ed73069d91d). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10254][ML]Removes Guava dependencies in...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8445#issuecomment-134825014 [Test build #41585 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41585/console) for PR 8445 at commit [`a0a4dca`](https://github.com/apache/spark/commit/a0a4dca944cab07c44ca865db5253ed73069d91d). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10254][ML]Removes Guava dependencies in...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8445#issuecomment-134825033 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41585/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
