[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-159074173 @martinbrown It looks like it's been a while since there has been activity. Sorry! Could you please fix the conflicts, and we can see about merging this for 1.6? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-154272750 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-154272751 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45189/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-154272663 **[Test build #45189 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45189/consoleFull)** for PR 8505 at commit [`b2cc944`](https://github.com/apache/spark/commit/b2cc944273e60d1e61322feb6949754aeecf8ddc). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_:\n * `final class Binarizer @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)`\n * `final class Bucketizer @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)`\n * `class CountVectorizer @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String)`\n * `class CountVectorizerModel @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid:`\n * `class DCT @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String)`\n * `class ElementwiseProduct @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)`\n * `class HashingTF @Since(\"1.2.0\") (@Since(\"1.4.0\") override val uid: String) extends Transformer`\n * `final class IDF @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String) extends`\n * `class MinMaxScaler @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String)`\n * `class NGram @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String)`\n * `class Norm alizer @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String) extends`\n * `class OneHotEncoder @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String) extends Transformer`\n * `class PCA @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String) extends Estimator[PCAModel]`\n * `class PolynomialExpansion @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)`\n * `class RFormula @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String) extends`\n * `class StandardScaler @Since(\"1.2.0\") (@Since(\"1.4.0\") override val uid: String) extends`\n * `class StopWordsRemover @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String)`\n * `class StringIndexer @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String) extends`\n * `class Tokenizer @Since(\"1.2.0\") (@Since(\"1.4.0\") override val uid: String) extends`\n * `class RegexTokenizer @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)`\n * `class VectorAssembler @Since(\ "1.4.0\") (@Since(\"1.4.0\") override val uid: String)`\n * `class VectorIndexer @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String) extends`\n * `final class VectorSlicer @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String)`\n * `final class Word2Vec @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String) extends`\n --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-154265876 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45184/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-154265875 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-154265789 **[Test build #45184 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45184/consoleFull)** for PR 8505 at commit [`b0881a3`](https://github.com/apache/spark/commit/b0881a30c82da80cbf0facac9c4732b45b1e7b48). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_:\n * `final class Binarizer @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)`\n * `final class Bucketizer @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)`\n * `class CountVectorizer @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String)`\n * `class CountVectorizerModel @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid:`\n * `class DCT @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String)`\n * `class ElementwiseProduct @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)`\n * `class HashingTF @Since(\"1.2.0\") (@Since(\"1.4.0\") override val uid: String) extends Transformer`\n * `final class IDF @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String) extends`\n * `class MinMaxScaler @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String)`\n * `class NGram @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String)`\n * `class Norm alizer @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String) extends`\n * `class OneHotEncoder @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String) extends Transformer`\n * `class PCA @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String) extends Estimator[PCAModel]`\n * `class PolynomialExpansion @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)`\n * `class RFormula @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String) extends`\n * `class StandardScaler @Since(\"1.2.0\") (@Since(\"1.4.0\") override val uid: String) extends`\n * `class StopWordsRemover @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String)`\n * `class StringIndexer @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String) extends`\n * `class Tokenizer @Since(\"1.2.0\") (@Since(\"1.4.0\") override val uid: String) extends`\n * `class RegexTokenizer @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)`\n * `class VectorAssembler @Since(\ "1.4.0\") (@Since(\"1.4.0\") override val uid: String)`\n * `class VectorIndexer @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String) extends`\n * `final class VectorSlicer @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String)`\n * `final class Word2Vec @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String) extends`\n * `final class DecisionTreeRegressor @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)`\n * `final class GBTRegressor @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)`\n * `class IsotonicRegression @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String)`\n * `class LinearRegression @Since(\"1.3.0\") (@Since(\"1.3.0\") override val uid: String)`\n * `final class RandomForestRegressor @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)`\n --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-154265454 **[Test build #45189 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45189/consoleFull)** for PR 8505 at commit [`b2cc944`](https://github.com/apache/spark/commit/b2cc944273e60d1e61322feb6949754aeecf8ddc). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-154264808 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-154264794 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user martinbrown commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-154264615 @mengxr responded --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user martinbrown commented on a diff in the pull request:
https://github.com/apache/spark/pull/8505#discussion_r44097390
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Binarizer.scala
---
@@ -31,10 +31,12 @@ import org.apache.spark.sql.types.{DoubleType,
StructType}
* :: Experimental ::
* Binarize a column of continuous features given a threshold.
*/
+@Since("1.4.0")
@Experimental
-final class Binarizer(override val uid: String)
+final class Binarizer @Since("1.4.0") (@Since("1.4.0") override val uid:
String)
extends Transformer with HasInputCol with HasOutputCol {
+ @Since("1.4.0")
--- End diff --
Hey @mengxr I'm a little confused here because Binarizer wasn't added until
1.4.0. I did correct the default constructor to 1.2.0 for the original classes
from that version (HashingTF, StandardScaler, Tokenizer).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-15426 **[Test build #45184 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45184/consoleFull)** for PR 8505 at commit [`b0881a3`](https://github.com/apache/spark/commit/b0881a30c82da80cbf0facac9c4732b45b1e7b48). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-154259868 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-154259886 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-153411351 @martinbrown Do you have time to address my comments? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-144259091 LGTM except some minor issues with constructor versions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8505#discussion_r40752797
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/HashingTF.scala
---
@@ -32,15 +32,20 @@ import org.apache.spark.sql.types.{ArrayType,
StructType}
* :: Experimental ::
* Maps a sequence of terms to their term frequencies using the hashing
trick.
*/
+@Since("1.2.0")
@Experimental
-class HashingTF(override val uid: String) extends Transformer with
HasInputCol with HasOutputCol {
+class HashingTF @Since("1.2.0") (@Since("1.4.0") override val uid: String)
extends Transformer
--- End diff --
The constructor with `uid` should be since `1.4.0`. The default constructor
below is since `1.2.0`. Please check others as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8505#discussion_r40752769
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Binarizer.scala
---
@@ -31,10 +31,12 @@ import org.apache.spark.sql.types.{DoubleType,
StructType}
* :: Experimental ::
* Binarize a column of continuous features given a threshold.
*/
+@Since("1.4.0")
@Experimental
-final class Binarizer(override val uid: String)
+final class Binarizer @Since("1.4.0") (@Since("1.4.0") override val uid:
String)
extends Transformer with HasInputCol with HasOutputCol {
+ @Since("1.4.0")
--- End diff --
The default constructor should be since 1.2.0. Please check others as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8505#issuecomment-144116109
[Test build #43088 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43088/console)
for PR 8505 at commit
[`aaa2376`](https://github.com/apache/spark/commit/aaa23766e712628ef169726ae98422cccabbba3b).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `final class Binarizer @Since("1.4.0") (@Since("1.4.0") override val
uid: String)`
* `final class Bucketizer @Since("1.4.0") (@Since("1.4.0") override val
uid: String)`
* `class CountVectorizer @Since("1.5.0") (@Since("1.5.0") override val
uid: String)`
* `class CountVectorizerModel @Since("1.5.0") (@Since("1.5.0") override
val uid:`
* `class DCT @Since("1.5.0") (@Since("1.5.0") override val uid: String)`
* `class ElementwiseProduct @Since("1.4.0") (@Since("1.4.0") override val
uid: String)`
* `class HashingTF @Since("1.2.0") (@Since("1.4.0") override val uid:
String) extends Transformer`
* `final class IDF @Since("1.4.0") (@Since("1.4.0") override val uid:
String) extends`
* `class MinMaxScaler @Since("1.5.0") (@Since("1.5.0") override val uid:
String)`
* `class NGram @Since("1.5.0") (@Since("1.5.0") override val uid: String)`
* `class Normalizer @Since("1.4.0") (@Since("1.4.0") override val uid:
String) extends`
* `class OneHotEncoder @Since("1.4.0") (@Since("1.4.0") override val uid:
String) extends Transformer`
* `class PCA @Since("1.5.0") (@Since("1.5.0") override val uid: String)
extends Estimator[PCAModel]`
* `class PolynomialExpansion @Since("1.4.0") (@Since("1.4.0") override
val uid: String)`
* `class RFormula @Since("1.5.0") (@Since("1.5.0") override val uid:
String) extends`
* `class StandardScaler @Since("1.2.0") (@Since("1.4.0") override val
uid: String) extends`
* `class StopWordsRemover @Since("1.5.0") (@Since("1.5.0") override val
uid: String)`
* `class StringIndexer @Since("1.4.0") (@Since("1.4.0") override val uid:
String) extends`
* `class Tokenizer @Since("1.2.0") (@Since("1.4.0") override val uid:
String) extends`
* `class RegexTokenizer @Since("1.4.0") (@Since("1.4.0") override val
uid: String)`
* `class VectorAssembler @Since("1.4.0") (@Since("1.4.0") override val
uid: String)`
* `class VectorIndexer @Since("1.4.0") (@Since("1.4.0") override val uid:
String) extends`
* `final class VectorSlicer @Since("1.5.0") (@Since("1.5.0") override val
uid: String)`
* `final class Word2Vec @Since("1.4.0") (@Since("1.4.0") override val
uid: String) extends`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-144116565 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43088/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-144116560 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-144101926 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-144101954 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-144102210 [Test build #43088 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43088/consoleFull) for PR 8505 at commit [`aaa2376`](https://github.com/apache/spark/commit/aaa23766e712628ef169726ae98422cccabbba3b). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-143951301 @martinbrown I think initially it was some Jenkins caching problem, then a flaky test. Let's try again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-143951236 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-143383961 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43040/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-143383960 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8505#issuecomment-143383944
[Test build #43040 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43040/console)
for PR 8505 at commit
[`aaa2376`](https://github.com/apache/spark/commit/aaa23766e712628ef169726ae98422cccabbba3b).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `final class Binarizer @Since("1.4.0") (@Since("1.4.0") override val
uid: String)`
* `final class Bucketizer @Since("1.4.0") (@Since("1.4.0") override val
uid: String)`
* `class CountVectorizer @Since("1.5.0") (@Since("1.5.0") override val
uid: String)`
* `class CountVectorizerModel @Since("1.5.0") (@Since("1.5.0") override
val uid:`
* `class DCT @Since("1.5.0") (@Since("1.5.0") override val uid: String)`
* `class ElementwiseProduct @Since("1.4.0") (@Since("1.4.0") override val
uid: String)`
* `class HashingTF @Since("1.2.0") (@Since("1.4.0") override val uid:
String) extends Transformer`
* `final class IDF @Since("1.4.0") (@Since("1.4.0") override val uid:
String) extends`
* `class MinMaxScaler @Since("1.5.0") (@Since("1.5.0") override val uid:
String)`
* `class NGram @Since("1.5.0") (@Since("1.5.0") override val uid: String)`
* `class Normalizer @Since("1.4.0") (@Since("1.4.0") override val uid:
String) extends`
* `class OneHotEncoder @Since("1.4.0") (@Since("1.4.0") override val uid:
String) extends Transformer`
* `class PCA @Since("1.5.0") (@Since("1.5.0") override val uid: String)
extends Estimator[PCAModel]`
* `class PolynomialExpansion @Since("1.4.0") (@Since("1.4.0") override
val uid: String)`
* `class RFormula @Since("1.5.0") (@Since("1.5.0") override val uid:
String) extends`
* `class StandardScaler @Since("1.2.0") (@Since("1.4.0") override val
uid: String) extends`
* `class StopWordsRemover @Since("1.5.0") (@Since("1.5.0") override val
uid: String)`
* `class StringIndexer @Since("1.4.0") (@Since("1.4.0") override val uid:
String) extends`
* `class Tokenizer @Since("1.2.0") (@Since("1.4.0") override val uid:
String) extends`
* `class RegexTokenizer @Since("1.4.0") (@Since("1.4.0") override val
uid: String)`
* `class VectorAssembler @Since("1.4.0") (@Since("1.4.0") override val
uid: String)`
* `class VectorIndexer @Since("1.4.0") (@Since("1.4.0") override val uid:
String) extends`
* `final class VectorSlicer @Since("1.5.0") (@Since("1.5.0") override val
uid: String)`
* `final class Word2Vec @Since("1.4.0") (@Since("1.4.0") override val
uid: String) extends`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-143381217 [Test build #43040 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43040/consoleFull) for PR 8505 at commit [`aaa2376`](https://github.com/apache/spark/commit/aaa23766e712628ef169726ae98422cccabbba3b). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-143380513 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-143379506 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user martinbrown commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-143051613 @mengxr ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user martinbrown commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-142730616 Trying again in case it was a transitory download error. Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user martinbrown commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-142130231 @mengxr any insight on this failure? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-142127347 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42779/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-142127346 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8505#issuecomment-142127269
[Test build #42779 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42779/console)
for PR 8505 at commit
[`d81b8c7`](https://github.com/apache/spark/commit/d81b8c75b575d002902881f8ff802e09accfa88b).
* This patch **fails MiMa tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `final class Binarizer @Since("1.4.0") (@Since("1.4.0") override val
uid: String)`
* `final class Bucketizer @Since("1.4.0") (@Since("1.4.0") override val
uid: String)`
* `class CountVectorizer @Since("1.5.0") (@Since("1.5.0") override val
uid: String)`
* `class CountVectorizerModel @Since("1.5.0") (@Since("1.5.0") override
val uid:`
* `class DCT @Since("1.5.0") (@Since("1.5.0") override val uid: String)`
* `class ElementwiseProduct @Since("1.4.0") (@Since("1.4.0") override val
uid: String)`
* `class HashingTF @Since("1.2.0") (@Since("1.4.0") override val uid:
String) extends Transformer`
* `final class IDF @Since("1.4.0") (@Since("1.4.0") override val uid:
String) extends`
* `class MinMaxScaler @Since("1.5.0") (@Since("1.5.0") override val uid:
String)`
* `class NGram @Since("1.5.0") (@Since("1.5.0") override val uid: String)`
* `class Normalizer @Since("1.4.0") (@Since("1.4.0") override val uid:
String) extends`
* `class OneHotEncoder @Since("1.4.0") (@Since("1.4.0") override val uid:
String) extends Transformer`
* `class PCA @Since("1.5.0") (@Since("1.5.0") override val uid: String)
extends Estimator[PCAModel]`
* `class PolynomialExpansion @Since("1.4.0") (@Since("1.4.0") override
val uid: String)`
* `class RFormula @Since("1.5.0") (@Since("1.5.0") override val uid:
String) extends`
* `class StandardScaler @Since("1.2.0") (@Since("1.4.0") override val
uid: String) extends`
* `class StopWordsRemover @Since("1.5.0") (@Since("1.5.0") override val
uid: String)`
* `class StringIndexer @Since("1.4.0") (@Since("1.4.0") override val uid:
String) extends`
* `class Tokenizer @Since("1.2.0") (@Since("1.4.0") override val uid:
String) extends`
* `class RegexTokenizer @Since("1.4.0") (@Since("1.4.0") override val
uid: String)`
* `class VectorAssembler @Since("1.4.0") (@Since("1.4.0") override val
uid: String)`
* `class VectorIndexer @Since("1.4.0") (@Since("1.4.0") override val uid:
String) extends`
* `final class VectorSlicer @Since("1.5.0") (@Since("1.5.0") override val
uid: String)`
* `final class Word2Vec @Since("1.4.0") (@Since("1.4.0") override val
uid: String) extends`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-142121465 [Test build #42779 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42779/consoleFull) for PR 8505 at commit [`d81b8c7`](https://github.com/apache/spark/commit/d81b8c75b575d002902881f8ff802e09accfa88b). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-142119703 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-142119751 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8505#issuecomment-141724597
[Test build #42720 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42720/console)
for PR 8505 at commit
[`d5c6ad8`](https://github.com/apache/spark/commit/d5c6ad8b2fce1272b5f4217ba0bed014bc00673c).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `final class Binarizer @Since("1.4.0") (@Since("1.4.0") override val
uid: String)`
* `final class Bucketizer @Since("1.4.0") (@Since("1.4.0") override val
uid: String)`
* `class CountVectorizer @Since("1.5.0") (@Since("1.5.0") override val
uid: String)`
* `class CountVectorizerModel @Since("1.5.0") (@Since("1.5.0") override
val uid:`
* `class DCT @Since("1.5.0") (@Since("1.5.0") override val uid: String)`
* `class ElementwiseProduct @Since("1.4.0") (@Since("1.4.0") override val
uid: String)`
* `class HashingTF @Since("1.2.0") (@Since("1.4.0") override val uid:
String) extends Transformer`
* `final class IDF @Since("1.4.0") (@Since("1.4.0") override val uid:
String) extends`
* `class MinMaxScaler @Since("1.5.0") (@Since("1.5.0") override val uid:
String)`
* `class NGram @Since("1.5.0") (@Since("1.5.0") override val uid: String)`
* `class Normalizer @Since("1.4.0") (@Since("1.4.0") override val uid:
String) extends`
* `class OneHotEncoder @Since("1.4.0") (@Since("1.4.0") override val uid:
String) extends Transformer`
* `class PCA @Since("1.5.0") (@Since("1.5.0") override val uid: String)
extends Estimator[PCAModel]`
* `class PolynomialExpansion @Since("1.4.0") (@Since("1.4.0") override
val uid: String)`
* `class RFormula @Since("1.5.0") (@Since("1.5.0") override val uid:
String) extends`
* `class StandardScaler @Since("1.2.0") (@Since("1.4.0") override val
uid: String) extends`
* `class StopWordsRemover @Since("1.5.0") (@Since("1.5.0") override val
uid: String)`
* `class StringIndexer @Since("1.4.0") (@Since("1.4.0") override val uid:
String) extends`
* `class Tokenizer @Since("1.2.0") (@Since("1.4.0") override val uid:
String) extends`
* `class RegexTokenizer @Since("1.4.0") (@Since("1.4.0") override val
uid: String)`
* `class VectorAssembler @Since("1.4.0") (@Since("1.4.0") override val
uid: String)`
* `class VectorIndexer @Since("1.4.0") (@Since("1.4.0") override val uid:
String) extends`
* `final class VectorSlicer @Since("1.5.0") (@Since("1.5.0") override val
uid: String)`
* `final class Word2Vec @Since("1.4.0") (@Since("1.4.0") override val
uid: String) extends`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-141724601 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-141724602 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42720/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-141724454 [Test build #42720 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42720/consoleFull) for PR 8505 at commit [`d5c6ad8`](https://github.com/apache/spark/commit/d5c6ad8b2fce1272b5f4217ba0bed014bc00673c). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-141724275 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-141724280 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user martinbrown commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-141724075 @mengxr Can you kick off another Jenkins run? It looks like the last run had a fault unrelated to the code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-141607192 [Test build #42707 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42707/consoleFull) for PR 8505 at commit [`31bf4dd`](https://github.com/apache/spark/commit/31bf4dd7323d8dc83da2557e7825f13b12efe9e7). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-141607033 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-141607040 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-141143436 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42609/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8505#issuecomment-141143429
[Test build #42609 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42609/console)
for PR 8505 at commit
[`fc98720`](https://github.com/apache/spark/commit/fc9872099fe325d345d979ee987ecef11afcb246).
* This patch **fails Scala style tests**.
* This patch **does not merge cleanly**.
* This patch adds the following public classes _(experimental)_:
* `final class Binarizer @Since("1.4.0") (@Since("1.4.0") override val
uid: String)`
* `final class Bucketizer @Since("1.4.0") (@Since("1.4.0") override val
uid: String)`
* `class CountVectorizer @Since("1.5.0") (@Since("1.5.0") override val
uid: String)`
* `class CountVectorizerModel @Since("1.5.0") (@Since("1.5.0") override
val uid:`
* `class DCT @Since("1.5.0") (@Since("1.5.0") override val uid: String)`
* `class ElementwiseProduct @Since("1.4.0") (@Since("1.4.0") override val
uid: String)`
* `class HashingTF @Since("1.2.0") (@Since("1.4.0") override val uid:
String) extends Transformer with HasInputCol with HasOutputCol `
* `final class IDF @Since("1.4.0") (@Since("1.4.0") override val uid:
String) extends Estimator[IDFModel] with IDFBase `
* `class MinMaxScaler @Since("1.5.0") (@Since("1.5.0") override val uid:
String)`
* `class NGram @Since("1.5.0") (@Since("1.5.0") override val uid: String)`
* `class Normalizer @Since("1.4.0") (@Since("1.4.0") override val uid:
String) extends UnaryTransformer[Vector, Vector, Normalizer] `
* `class OneHotEncoder @Since("1.4.0") (@Since("1.4.0") override val uid:
String) extends Transformer`
* `class PCA @Since("1.5.0") (@Since("1.5.0") override val uid: String)
extends Estimator[PCAModel] with PCAParams `
* `class PolynomialExpansion @Since("1.4.0") (@Since("1.4.0") override
val uid: String)`
* `class RFormula @Since("1.5.0") (@Since("1.5.0") override val uid:
String) extends Estimator[RFormulaModel] with RFormulaBase `
* `class StandardScaler @Since("1.2.0") (@Since("1.4.0") override val
uid: String) extends Estimator[StandardScalerModel]`
* `class StopWordsRemover @Since("1.5.0") (@Since("1.5.0") override val
uid: String)`
* `class StringIndexer @Since("1.4.0") (@Since("1.4.0") override val uid:
String) extends Estimator[StringIndexerModel]`
* `class Tokenizer @Since("1.2.0") (@Since("1.4.0") override val uid:
String) extends UnaryTransformer[String, Seq[String], Tokenizer] `
* `class RegexTokenizer @Since("1.4.0") (@Since("1.4.0") override val
uid: String)`
* `class VectorAssembler @Since("1.4.0") (@Since("1.4.0") override val
uid: String)`
* `class VectorIndexer @Since("1.4.0") (@Since("1.4.0") override val uid:
String) extends Estimator[VectorIndexerModel]`
* `final class VectorSlicer @Since("1.5.0") (@Since("1.5.0") override val
uid: String)`
* `final class Word2Vec @Since("1.4.0") (@Since("1.4.0") override val
uid: String) extends Estimator[Word2VecModel] with Word2VecBase `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-141143435 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-141141205 [Test build #42609 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42609/consoleFull) for PR 8505 at commit [`fc98720`](https://github.com/apache/spark/commit/fc9872099fe325d345d979ee987ecef11afcb246). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-141138756 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-141138681 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-141137776 @martinbrown there are some merge conflicts. could you rebase master? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-141137687 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user martinbrown commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-140795638 Ready for another look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-140726459 ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-136523546 Okay. @martinbrown Could you add `@Since` to the constructor and public params in it as well? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-136491737 I'm for adding them always -- easier to track down which methods don't have them this way. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-136093636 The downside would be if we forget since tags in some new methods, it might cause confusions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-135942369 We might as well do it. (Any downside?) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-135802592 Looking at the changes, I wonder whether we need to annotate original public methods/variables that have the same since version as the class. Java doesn't do this (http://docs.oracle.com/javase/7/docs/api/java/util/Arrays.html). Please don't remove them now. Just want to discuss and see which approach is more appropriate. + @rxin since this also applies to `DataFrame`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8505#discussion_r38209961
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Binarizer.scala
---
@@ -31,10 +31,12 @@ import org.apache.spark.sql.types.{DoubleType,
StructType}
* :: Experimental ::
* Binarize a column of continuous features given a threshold.
*/
+@Since("1.4.0")
@Experimental
final class Binarizer(override val uid: String)
--- End diff --
Also annotate the constructor and the public variables in the constructor,
e.g.,
https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/mllib/feature/IDF.scala#L42.
Same for other constructors.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-135727723 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...
GitHub user martinbrown opened a pull request: https://github.com/apache/spark/pull/8505 [SPARK-10258] [DOCUMENTATION, ML] Adding Since() Annotations to ml/feature Unsure what to do for SQLTransformer since it's in master but not in any tagged release. You can merge this pull request into a Git repository by running: $ git pull https://github.com/martinbrown/spark ml_since_tagging Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/8505.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #8505 commit 2b9c63a9e2f28eb615a97ae46f6375d90d17703d Author: Martin Brown Date: 2015-08-27T07:27:13Z @Since() annotations for spark/ml/feature --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
