[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user taishi-oss commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-162819270 Thank you for merging! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8534 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-162803003 Merged into master and branch-1.6. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-162447927 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47260/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-162447923 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-162447816 **[Test build #47260 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47260/consoleFull)** for PR 8534 at commit [`6831e7a`](https://github.com/apache/spark/commit/6831e7a4578541791a87ea5944dbe6f7f13069c6). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_:\n * `final class DecisionTreeClassifier @Since(\"1.4.0\") (`\n * `final class GBTClassifier @Since(\"1.4.0\") (`\n * `class LogisticRegression @Since(\"1.2.0\") (`\n * `class MultilayerPerceptronClassifier @Since(\"1.5.0\") (`\n * `class NaiveBayes @Since(\"1.5.0\") (`\n * `final class OneVsRest @Since(\"1.4.0\") (`\n * `final class RandomForestClassifier @Since(\"1.4.0\") (`\n * ` public abstract static class PrefixComputer `\n --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user taishi-oss commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-162440255 I modified the code that was pointed out. @sarutak @yu-iskw Thank you for reviewing! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-162440197 **[Test build #47260 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47260/consoleFull)** for PR 8534 at commit [`6831e7a`](https://github.com/apache/spark/commit/6831e7a4578541791a87ea5944dbe6f7f13069c6). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-161952892 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-161952894 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47196/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-161952784 **[Test build #47196 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47196/consoleFull)** for PR 8534 at commit [`3743123`](https://github.com/apache/spark/commit/3743123b58b50e36b560ed0be5d613a84bbd3b6d). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_:\n * `final class DecisionTreeClassifier (`\n * `final class GBTClassifier(`\n * `class LogisticRegression(`\n * `class MultilayerPerceptronClassifier(`\n * `class NaiveBayes(`\n * `final class OneVsRest(`\n * `final class RandomForestClassifier(`\n --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-161946643 @sarutak thank you for your help! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-161943059 **[Test build #47196 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47196/consoleFull)** for PR 8534 at commit [`3743123`](https://github.com/apache/spark/commit/3743123b58b50e36b560ed0be5d613a84bbd3b6d). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user taishi-oss commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-161939914 Thank you for reviewing. I'm modifying. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user taishi-oss commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46671245
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -155,10 +155,13 @@ private[classification] trait
LogisticRegressionParams extends ProbabilisticClas
* in the future.
*/
@Experimental
-class LogisticRegression(override val uid: String)
+@Since("1.4.0")
+class LogisticRegression(
+@Since("1.4.0") override val uid: String)
extends ProbabilisticClassifier[Vector, LogisticRegression,
LogisticRegressionModel]
with LogisticRegressionParams with DefaultParamsWritable with Logging {
+ @Since("1.4.0")
--- End diff --
"git show" says it was introduced in v.1.4.0.
```
hiro [spark] (master) > git show
v1.2.0:mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
| grep "def this"
hiro [spark] (master) > git show
v1.3.0:mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
| grep "def this"
hiro [spark] (master) > git show
v1.4.0:mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
| grep "def this"
def this() = this(Identifiable.randomUID("logreg"))
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-161777363 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47153/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-161777359 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-161776987 **[Test build #47153 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47153/consoleFull)** for PR 8534 at commit [`4e0a925`](https://github.com/apache/spark/commit/4e0a925960db9934d5506e864f6fe36997bb1828). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_:\n * `final class DecisionTreeClassifier (`\n * `final class GBTClassifier(`\n * `class LogisticRegression(`\n * `class MultilayerPerceptronClassifier(`\n * `class NaiveBayes(`\n * `final class OneVsRest(`\n * `final class RandomForestClassifier(`\n --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-161750998 **[Test build #47152 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47152/consoleFull)** for PR 8534 at commit [`4e0a925`](https://github.com/apache/spark/commit/4e0a925960db9934d5506e864f6fe36997bb1828). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_:\n * `final class DecisionTreeClassifier (`\n * `final class GBTClassifier(`\n * `class LogisticRegression(`\n * `class MultilayerPerceptronClassifier(`\n * `class NaiveBayes(`\n * `final class OneVsRest(`\n * `final class RandomForestClassifier(`\n --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-161751179 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47152/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-161751178 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-161742016 **[Test build #47153 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47153/consoleFull)** for PR 8534 at commit [`4e0a925`](https://github.com/apache/spark/commit/4e0a925960db9934d5506e864f6fe36997bb1828). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-161739529 **[Test build #47152 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47152/consoleFull)** for PR 8534 at commit [`4e0a925`](https://github.com/apache/spark/commit/4e0a925960db9934d5506e864f6fe36997bb1828). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-161738178 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-161736518 I've left some comments, otherwise it's LGTM but It's good if @jkbradley or @mengxr can take a look at. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-161735995 ok to test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46588189
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -397,22 +413,27 @@ object LogisticRegression extends
DefaultParamsReadable[LogisticRegression] {
* Model produced by [[LogisticRegression]].
*/
@Experimental
+@Since("1.4.0")
--- End diff --
reordering.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46588122
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -105,11 +119,12 @@ object DecisionTreeClassifier {
* features.
*/
@Experimental
+@Since("1.4.0")
--- End diff --
reordering.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46588154
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -165,11 +187,12 @@ object GBTClassifier {
* @param _treeWeights Weights for the decision trees in the ensemble.
*/
@Experimental
+@Since("1.6.0")
--- End diff --
reordering.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46588033
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/NaiveBayes.scala ---
@@ -120,10 +126,11 @@ object NaiveBayes extends
DefaultParamsReadable[NaiveBayes] {
* by D (number of features)
*/
@Experimental
+@Since("1.5.0")
--- End diff --
reordering.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46587975
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala
---
@@ -121,11 +138,12 @@ object RandomForestClassifier {
* Warning: These have null parents.
*/
@Experimental
+@Since("1.4.0")
--- End diff --
reordering.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46588072
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -71,16 +71,19 @@ private[ml] trait OneVsRestParams extends
PredictorParams {
* (taking label 0).
*/
@Experimental
+@Since("1.4.0")
--- End diff --
reordering.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46588007
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -174,13 +182,15 @@ class MultilayerPerceptronClassifier(override val
uid: String)
* @return prediction model
*/
@Experimental
+@Since("1.5.0")
--- End diff --
reordering.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46587835
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala
---
@@ -99,10 +114,12 @@ final class RandomForestClassifier(override val uid:
String)
new RandomForestClassificationModel(trees, numFeatures, numClasses)
}
+ @Since("1.4.1")
override def copy(extra: ParamMap): RandomForestClassifier =
defaultCopy(extra)
}
@Experimental
+@Since("1.4.0")
object RandomForestClassifier {
/** Accessor for supported impurity settings: entropy, gini */
final val supportedImpurities: Array[String] =
TreeClassifierParams.supportedImpurities
--- End diff --
Should we add `Since` annotation here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46587538
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/NaiveBayes.scala ---
@@ -73,10 +73,13 @@ private[ml] trait NaiveBayesParams extends
PredictorParams {
* The input feature values must be nonnegative.
*/
@Experimental
-class NaiveBayes(override val uid: String)
+@Since("1.5.0")
+class NaiveBayes(
--- End diff --
Please reorder annotations and add a Since tag to the primary constructor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46587664
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala
---
@@ -39,43 +39,58 @@ import org.apache.spark.sql.functions._
* features.
*/
@Experimental
-final class RandomForestClassifier(override val uid: String)
+@Since("1.4.0")
+final class RandomForestClassifier(
--- End diff --
Please reorder annotations and add a Since tag to the primary constructor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46587620
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -151,29 +155,38 @@ final class OneVsRestModel private[ml] (
* is picked to label the example.
*/
@Experimental
-final class OneVsRest(override val uid: String)
+@Since("1.4.0")
+final class OneVsRest(
--- End diff --
Please reorder annotations and add a Since tag to the primary constructor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46587368
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -104,19 +104,23 @@ private object LabelConverter {
* Each layer has sigmoid activation function, output layer has softmax.
* Number of inputs has to be equal to the size of feature vectors.
* Number of outputs has to be equal to the total number of labels.
- *
*/
@Experimental
-class MultilayerPerceptronClassifier(override val uid: String)
+@Since("1.5.0")
+class MultilayerPerceptronClassifier(
--- End diff --
Please reorder annotations and add a `Since` tag to the primary constructor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user sarutak commented on a diff in the pull request: https://github.com/apache/spark/pull/8534#discussion_r46586993 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -229,8 +240,10 @@ class LogisticRegression(override val uid: String) def setWeightCol(value: String): this.type = set(weightCol, value) --- End diff -- Please add a `Since` tag, maybe `1.6.0`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46586698
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -155,10 +155,13 @@ private[classification] trait
LogisticRegressionParams extends ProbabilisticClas
* in the future.
*/
@Experimental
-class LogisticRegression(override val uid: String)
+@Since("1.4.0")
+class LogisticRegression(
+@Since("1.4.0") override val uid: String)
extends ProbabilisticClassifier[Vector, LogisticRegression,
LogisticRegressionModel]
with LogisticRegressionParams with DefaultParamsWritable with Logging {
+ @Since("1.4.0")
--- End diff --
1.2.0?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46586740
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -166,6 +169,7 @@ class LogisticRegression(override val uid: String)
* Default is 0.0.
* @group setParam
*/
+ @Since("1.4.0")
def setRegParam(value: Double): this.type = set(regParam, value)
--- End diff --
1.2.0?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46586328
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -37,31 +37,43 @@ import org.apache.spark.sql.DataFrame
* features.
*/
@Experimental
-final class DecisionTreeClassifier(override val uid: String)
+@Since("1.4.0")
+final class DecisionTreeClassifier (
--- End diff --
Please add a `Since` tag to the primary constructor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46586171
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -45,35 +45,46 @@ import org.apache.spark.sql.types.DoubleType
* Note: Multiclass labels are not currently supported.
*/
@Experimental
-final class GBTClassifier(override val uid: String)
+@Since("1.4.0")
+final class GBTClassifier(
--- End diff --
Please add a `Since` tag to the primary constructor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46586016
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -155,10 +155,13 @@ private[classification] trait
LogisticRegressionParams extends ProbabilisticClas
* in the future.
*/
@Experimental
-class LogisticRegression(override val uid: String)
+@Since("1.4.0")
+class LogisticRegression(
--- End diff --
Also, please add `Since` tag to the primary constructor here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46585444
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -155,10 +155,13 @@ private[classification] trait
LogisticRegressionParams extends ProbabilisticClas
* in the future.
*/
@Experimental
-class LogisticRegression(override val uid: String)
+@Since("1.4.0")
+class LogisticRegression(
--- End diff --
Since `1.2.0` right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46583262
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -145,13 +163,17 @@ final class GBTClassifier(override val uid: String)
GBTClassificationModel.fromOld(oldModel, this, categoricalFeatures,
numFeatures)
}
+ @Since("1.4.1")
override def copy(extra: ParamMap): GBTClassifier = defaultCopy(extra)
}
+
--- End diff --
Please remove an extra blank line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46582947
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -89,10 +101,12 @@ final class DecisionTreeClassifier(override val uid:
String)
subsamplingRate = 1.0)
}
+ @Since("1.4.1")
override def copy(extra: ParamMap): DecisionTreeClassifier =
defaultCopy(extra)
}
@Experimental
+@Since("1.4.0")
object DecisionTreeClassifier {
/** Accessor for supported impurities: entropy, gini */
final val supportedImpurities: Array[String] =
TreeClassifierParams.supportedImpurities
--- End diff --
We should add a `Since` annotation here right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46581699
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -45,35 +45,46 @@ import org.apache.spark.sql.types.DoubleType
* Note: Multiclass labels are not currently supported.
*/
@Experimental
-final class GBTClassifier(override val uid: String)
+@Since("1.4.0")
--- End diff --
It's really minor but can you reorder these annotations like other classes
in ml/mllib?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46579113
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala
---
@@ -17,7 +17,7 @@
package org.apache.spark.ml.classification
-import org.apache.spark.annotation.Experimental
+import org.apache.spark.annotation.{Since, Experimental}
--- End diff --
Same here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46579088
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -21,7 +21,7 @@ import java.util.UUID
import scala.language.existentials
-import org.apache.spark.annotation.Experimental
+import org.apache.spark.annotation.{Since, Experimental}
--- End diff --
Same here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46579065
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -19,7 +19,7 @@ package org.apache.spark.ml.classification
import scala.collection.JavaConverters._
-import org.apache.spark.annotation.Experimental
+import org.apache.spark.annotation.{Since, Experimental}
--- End diff --
Same here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46578992
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -20,7 +20,7 @@ package org.apache.spark.ml.classification
import com.github.fommil.netlib.BLAS.{getInstance => blas}
import org.apache.spark.Logging
-import org.apache.spark.annotation.Experimental
+import org.apache.spark.annotation.{Since, Experimental}
--- End diff --
Same here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46578954
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -17,7 +17,7 @@
package org.apache.spark.ml.classification
-import org.apache.spark.annotation.Experimental
+import org.apache.spark.annotation.{Since, Experimental}
--- End diff --
Please declare in ascending order.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user maropu commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-161548934 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-159468625 @jkbradley could you run tests for this PR? This is the fist PR for @taishi-oss. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-159466727 @taishi-oss thank you for the udpate! LGTM @jkbradley could you take a look at PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user taishi-oss commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-156377905 I modified the code that was pointed out. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user taishi-oss commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-156359833 @yu-iskw Sorry for being late, I'm do right now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-156182872 ping @taishi-oss --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-154254270 @taishi-oss thanks for rebaseing master. Could you add `@Since` to all public variables? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user yu-iskw commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r44093689
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -71,16 +71,19 @@ private[ml] trait OneVsRestParams extends
PredictorParams {
* (taking label 0).
*/
@Experimental
+@Since("1.4.0")
final class OneVsRestModel private[ml] (
-override val uid: String,
+@Since("1.4.0") override val uid: String,
labelMetadata: Metadata,
val models: Array[_ <: ClassificationModel[_, _]])
--- End diff --
Add the tag
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user yu-iskw commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r44093643
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -103,11 +116,12 @@ object DecisionTreeClassifier {
* features.
*/
@Experimental
+@Since("1.4.0")
final class DecisionTreeClassificationModel private[ml] (
-override val uid: String,
-override val rootNode: Node,
-override val numFeatures: Int,
-override val numClasses: Int)
+@Since("1.5.0")override val uid: String,
+@Since("1.5.0")override val rootNode: Node,
--- End diff --
ditto
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user yu-iskw commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r44093665
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -390,8 +404,9 @@ class LogisticRegression(override val uid: String)
* Model produced by [[LogisticRegression]].
*/
@Experimental
+@Since("1.4.0")
class LogisticRegressionModel private[ml] (
-override val uid: String,
+@Since("1.4.0") override val uid: String,
val coefficients: Vector,
--- End diff --
Add the tag
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user yu-iskw commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r44093682
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/NaiveBayes.scala ---
@@ -110,8 +116,9 @@ class NaiveBayes(override val uid: String)
* by D (number of features)
*/
@Experimental
+@Since("1.5.0")
class NaiveBayesModel private[ml] (
-override val uid: String,
+@Since("1.5.0") override val uid: String,
val pi: Vector,
--- End diff --
Add the tag
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user yu-iskw commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r44093684
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/NaiveBayes.scala ---
@@ -110,8 +116,9 @@ class NaiveBayes(override val uid: String)
* by D (number of features)
*/
@Experimental
+@Since("1.5.0")
class NaiveBayesModel private[ml] (
-override val uid: String,
+@Since("1.5.0") override val uid: String,
val pi: Vector,
val theta: Matrix)
--- End diff --
ditto
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user yu-iskw commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r44093668
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -390,8 +404,9 @@ class LogisticRegression(override val uid: String)
* Model produced by [[LogisticRegression]].
*/
@Experimental
+@Since("1.4.0")
class LogisticRegressionModel private[ml] (
-override val uid: String,
+@Since("1.4.0") override val uid: String,
val coefficients: Vector,
val intercept: Double)
--- End diff --
ditto
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user yu-iskw commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r44093642
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -103,11 +116,12 @@ object DecisionTreeClassifier {
* features.
*/
@Experimental
+@Since("1.4.0")
final class DecisionTreeClassificationModel private[ml] (
-override val uid: String,
-override val rootNode: Node,
-override val numFeatures: Int,
-override val numClasses: Int)
+@Since("1.5.0")override val uid: String,
--- End diff --
since 1.4.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user yu-iskw commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r44093654
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -165,8 +185,9 @@ object GBTClassifier {
* @param _treeWeights Weights for the decision trees in the ensemble.
*/
@Experimental
+@Since("1.6.0")
final class GBTClassificationModel private[ml](
-override val uid: String,
+@Since("1.6.0") override val uid: String,
private val _trees: Array[DecisionTreeRegressionModel],
private val _treeWeights: Array[Double],
override val numFeatures: Int)
--- End diff --
Add the tag to `numFeatures`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user taishi-oss commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-153612968 Sorry for being late. I rebased this branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-152881764 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-152868076 @hiross thank you for your contribution. Could you update this PR? After that, I could review it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user taishi-oss commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-141008317 I think DecisionTreeClassifer.copy is introduced in v1.5.0. but, This method is brought into v.1.4.1 using "git-cherry-pick". So "git blames" says v.1.5.0 but "git show" says v.1.4.1. I compare "git show" commnad's results with "git blames"'s results in ml.classification, and then there are some differnces as desribed above. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user taishi-oss commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-140677301 @mengxr Could you take a look? Now, I'm adding Since annotation to ml.classification. I think DecisionTreeClassifer.copy is introduced in [this commit](https://github.com/taishi-oss/spark/commit/43c7ec6384e51105dedf3a53354b6a3732cc27b2) (v.1.5.0). but, "git show" command shows that DecisionTreeClassifer.copy is introduce in v1.4.1. (Please see above.) Which version should I add Since annotation to this method? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user feynmanliang commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-140449400 Hmm I actually don't know the answer to that, maybe @mengxr can help --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user taishi-oss commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-140334039 I think [that commit](https://github.com/taishi-oss/spark/commit/43c7ec6384e51105dedf3a53354b6a3732cc27b2) is right. but "git show" command results as follows. I also think this is right. ``` [takahashi@phi spark]$ git show v1.4.0:mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala | grep "override def copy(extra: ParamMap): DecisionTreeClassifier = defaultCopy(extra)" [takahashi@phi spark]$ git show v1.4.1:mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala | grep "override def copy(extra: ParamMap): DecisionTreeClassifier = defaultCopy(extra)" override def copy(extra: ParamMap): DecisionTreeClassifier = defaultCopy(extra) [takahashi@phi spark]$ git show v1.5.0:mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala | grep "override def copy(extra: ParamMap): DecisionTreeClassifier = defaultCopy(extra)" override def copy(extra: ParamMap): DecisionTreeClassifier = defaultCopy(extra) ``` Which should I believe? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user feynmanliang commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-140182675 I believe the `copy` overrides were added by [this commit](https://github.com/taishi-oss/spark/commit/43c7ec6384e51105dedf3a53354b6a3732cc27b2) which went in to 1.5, not 1.4.1. SPARK-7751 has detailed directions on how to use the git history to identify the correct version numbers. You could also look at git blames and histories to figure out the exact commit that introduced it. you should add annotations to all public methods and constructor parameters (i.e. to `val`s if they are parameters in a public constructor). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user taishi-oss commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-140026675 Sorry, I misunderstood. I check when all methods were introduced and modify it. (use SPARK-7751 as a reference.) If it is not my mistake, DecisionTreeClassifer.copy was introduced in 1.4.1. And Should I add @Since annotation to val? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user feynmanliang commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-139311013 Not all methods in a file were introduced in the same version (e.g. see my comment about DecisionTreeClassifer.copy). Can you make sure that the annotation versions are correct? the jira has directions on how to identify the version a particular method was introduced. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8534#discussion_r39184933 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala --- @@ -90,6 +92,9 @@ final class DecisionTreeClassifier(override val uid: String) override def copy(extra: ParamMap): DecisionTreeClassifier = defaultCopy(extra) --- End diff -- This was [introduced in 1.5](https://github.com/taishi-oss/spark/commit/43c7ec6384e51105dedf3a53354b6a3732cc27b2#diff-1996e8d94a8a2815261946b240d2507eR90) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user feynmanliang commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-139308325 @taishi-oss no worries, thank you for your help! reviewing now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r39184277
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -87,10 +98,12 @@ final class DecisionTreeClassifier(override val uid:
String)
subsamplingRate = 1.0)
}
+ @Since("1.4.0")
override def copy(extra: ParamMap): DecisionTreeClassifier =
defaultCopy(extra)
}
@Experimental
+@Since("1.4.0")
object DecisionTreeClassifier {
/** Accessor for supported impurities: entropy, gini */
final val supportedImpurities: Array[String] =
TreeClassifierParams.supportedImpurities
--- End diff --
This is public
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user taishi-oss commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-139132076 I'm sorry for taking your time. I modified the code that was pointed out. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user feynmanliang commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-138616552 I only pointed out the issues in the first few files, do you mind fixing them in all the files? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8534#discussion_r38945344 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala --- @@ -35,6 +35,8 @@ import org.apache.spark.sql.DataFrame * for classification. * It supports both binary and multiclass labels, as well as both continuous and categorical * features. + * + * @since 1.4.0 --- End diff -- We should use "@Since" instead of "@since" since we made "@Since" for [inheriting scaladocs](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/annotation/Since.scala) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r38945223
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -90,6 +92,9 @@ final class DecisionTreeClassifier(override val uid:
String)
override def copy(extra: ParamMap): DecisionTreeClassifier =
defaultCopy(extra)
}
+/**
+ * @since 1.4.0
+ */
@Experimental
object DecisionTreeClassifier {
/** Accessor for supported impurities: entropy, gini */
--- End diff --
Ditto for public constructor fields
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8534#discussion_r38945200 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala --- @@ -90,6 +92,9 @@ final class DecisionTreeClassifier(override val uid: String) override def copy(extra: ParamMap): DecisionTreeClassifier = defaultCopy(extra) --- End diff -- Annotate all public methods --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8534#discussion_r38944990 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala --- @@ -35,6 +35,8 @@ import org.apache.spark.sql.DataFrame * for classification. * It supports both binary and multiclass labels, as well as both continuous and categorical * features. + * + * @since 1.4.0 */ @Experimental final class DecisionTreeClassifier(override val uid: String) --- End diff -- Please also annotate override constructor fields, see [mllib.LinearRegression](https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/mllib/regression/LinearRegression.scala#L38) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user taishi-oss commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-138488219 Sorry for being late. I modified @since annotations. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user feynmanliang commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-136513498 @taishi-oss these were already in spark prior to 1.6, please see the [parent JIRA](https://issues.apache.org/jira/browse/SPARK-7751) for how to track down the correct version number to use in the @since annotations. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8534#issuecomment-136307174 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
GitHub user taishi-oss opened a pull request: https://github.com/apache/spark/pull/8534 [SPARK-10259] [ML] Add @since annotation to ml.classification Add @since annotation to ml.classification You can merge this pull request into a Git repository by running: $ git pull https://github.com/taishi-oss/spark issue10259 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/8534.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #8534 commit 1c98d6d6981163ab2b5a7a5ee1a1b4a272d20f49 Author: Takahashi Hiroshi Date: 2015-08-31T09:00:29Z Add @since annotation to ml.classification --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
