[GitHub] spark pull request: [SPARK-10260][ML] Add @Since annotation to ml....
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8455 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10260][ML] Add @Since annotation to ml....
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8455#issuecomment-135643024 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41729/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10260][ML] Add @Since annotation to ml....
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8455#issuecomment-135643023 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10260][ML] Add @Since annotation to ml....
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8455#issuecomment-135642972 [Test build #41729 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41729/console) for PR 8455 at commit [`f4ad585`](https://github.com/apache/spark/commit/f4ad585561bba37ac2050d80d9c759b0392282b2). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class KMeans @Since(1.5.0) (` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10260][ML] Add @Since annotation to ml....
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8455#issuecomment-135665306 Thank you for merging it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10260][ML] Add @Since annotation to ml....
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8455#issuecomment-135666875 :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10260][ML] Add @Since annotation to ml....
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8455#issuecomment-135636695 @mengxr thanks for the comment. I have gotten rid of them from `KMeansParams`. Could you review it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10260][ML] Add @Since annotation to ml....
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8455#issuecomment-135638786 [Test build #41729 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41729/consoleFull) for PR 8455 at commit [`f4ad585`](https://github.com/apache/spark/commit/f4ad585561bba37ac2050d80d9c759b0392282b2). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10260][ML] Add @Since annotation to ml....
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8455#issuecomment-135638350 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10260][ML] Add @Since annotation to ml....
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8455#issuecomment-135642212 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41728/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10260][ML] Add @Since annotation to ml....
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8455#issuecomment-135642211 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10260][ML] Add @Since annotation to ml....
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8455#issuecomment-135642132 [Test build #41728 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41728/console) for PR 8455 at commit [`2c0a4d0`](https://github.com/apache/spark/commit/2c0a4d0e2cd6da8371bab064c83e8e155aa5183f). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class KMeans @Since(1.5.0) (` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10260][ML] Add @Since annotation to ml....
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8455#issuecomment-135638360 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10260][ML] Add @Since annotation to ml....
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8455#issuecomment-135638073 Sorry for my easy mistake I fixed it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10260][ML] Add @Since annotation to ml....
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8455#discussion_r38171523
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -30,6 +30,7 @@ import org.apache.spark.sql.{DataFrame, Row}
/**
+ * :: Experimental ::
--- End diff --
This is also necessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10260][ML] Add @Since annotation to ml....
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8455#issuecomment-135637836 LGTM except the comment above. I'll merge it after 1.5. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10260][ML] Add @Since annotation to ml....
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8455#issuecomment-135637446 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10260][ML] Add @Since annotation to ml....
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8455#issuecomment-135637464 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10260][ML] Add @Since annotation to ml....
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8455#issuecomment-135637651 [Test build #41728 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41728/consoleFull) for PR 8455 at commit [`2c0a4d0`](https://github.com/apache/spark/commit/2c0a4d0e2cd6da8371bab064c83e8e155aa5183f). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10260][ML] Add @Since annotation to ml....
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8455#discussion_r38169722
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -30,8 +30,11 @@ import org.apache.spark.sql.{DataFrame, Row}
/**
+ * :: Experimental ::
* Common params for KMeans and KMeansModel
*/
+@Since(1.5.0)
+@Experimental
--- End diff --
Both `Since` and `Experimental` are not necessary because this is package
private.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10260][ML] Add @Since annotation to ml....
Github user feynmanliang commented on the pull request: https://github.com/apache/spark/pull/8455#issuecomment-135116659 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10260][ML] Add @Since annotation to ml....
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8455#discussion_r38009649 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -84,27 +93,32 @@ private[clustering] trait KMeansParams extends Params with HasMaxIter with HasFe * * @param parentModel a model trained by spark.mllib.clustering.KMeans. */ +@Since(1.5.0) @Experimental class KMeansModel private[ml] ( -override val uid: String, +@Since(1.5.0) override val uid: String, --- End diff -- No need to annotate params to private constructor --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10260][ML] Add @Since annotation to ml....
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8455#issuecomment-134897912 [Test build #41614 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41614/consoleFull) for PR 8455 at commit [`e5713a0`](https://github.com/apache/spark/commit/e5713a0209c0f3d6d8847b9fd5bebc255944f234). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10260][ML] Add @Since annotation to ml....
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8455#issuecomment-134912364 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41614/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10260][ML] Add @Since annotation to ml....
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8455#issuecomment-134912362 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10260][ML] Add @Since annotation to ml....
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8455#issuecomment-134924344 @mengxr could you review it? cc: @feynmanliang --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10260][ML] Add @Since annotation to ml....
GitHub user yu-iskw opened a pull request: https://github.com/apache/spark/pull/8455 [SPARK-10260][ML] Add @Since annotation to ml.clustering ### JIRA [[SPARK-10260] Add @Since annotation to ml.clustering - ASF JIRA](https://issues.apache.org/jira/browse/SPARK-10260) You can merge this pull request into a Git repository by running: $ git pull https://github.com/yu-iskw/spark SPARK-10260 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/8455.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #8455 commit e5713a0209c0f3d6d8847b9fd5bebc255944f234 Author: Yu ISHIKAWA yuu.ishik...@gmail.com Date: 2015-08-26T08:21:13Z [SPARK-10260][ML] Add @Since annotation to ml.clustering --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10260][ML] Add @Since annotation to ml....
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8455#issuecomment-134897463 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10260][ML] Add @Since annotation to ml....
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8455#issuecomment-134897445 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10260][ML] Add @Since annotation to ml....
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8455#issuecomment-134911927 [Test build #41614 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41614/console) for PR 8455 at commit [`e5713a0`](https://github.com/apache/spark/commit/e5713a0209c0f3d6d8847b9fd5bebc255944f234). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class KMeans @Since(1.5.0) (` * `class GaussianMixtureModel @Since(1.3.0) (` * `class KMeansModel @Since(1.1.0) (@Since(1.0.0) val clusterCenters: Array[Vector])` * `class PowerIterationClusteringModel @Since(1.3.0) (` * `class StreamingKMeansModel @Since(1.2.0) (` * `class StreamingKMeans @Since(1.2.0) (` * `class ChiSqSelectorModel @Since(1.3.0) (` * `class ChiSqSelector @Since(1.3.0) (` * `class ElementwiseProduct @Since(1.4.0) (` * `class IDF @Since(1.2.0) (@Since(1.2.0) val minDocFreq: Int) ` * `class Normalizer @Since(1.1.0) (p: Double) extends VectorTransformer ` * `class PCA @Since(1.4.0) (@Since(1.4.0) val k: Int) ` * `class StandardScaler @Since(1.1.0) (withMean: Boolean, withStd: Boolean) extends Logging ` * `class StandardScalerModel @Since(1.3.0) (` * `class PoissonGenerator @Since(1.1.0) (` * `class ExponentialGenerator @Since(1.3.0) (` * `class GammaGenerator @Since(1.3.0) (` * `class LogNormalGenerator @Since(1.3.0) (` * `abstract class GeneralizedLinearModel @Since(1.0.0) (` * `class IsotonicRegressionModel @Since(1.3.0) (` * `case class LabeledPoint @Since(1.0.0) (` * `class LassoModel @Since(1.1.0) (` * `class LinearRegressionModel @Since(1.1.0) (` * `class RidgeRegressionModel @Since(1.1.0) (` * `class MultivariateGaussian @Since(1.3.0) (` * `case class BoostingStrategy @Since(1.4.0) (` * `class Strategy @Since(1.3.0) (` * `class DecisionTreeModel @Since(1.0.0) (` * `class Node @Since(1.2.0) (` * `class Predict @Since(1.2.0) (` * `class RandomForestModel @Since(1.2.0) (` * `class GradientBoostedTreesModel @Since(1.2.0) (` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
