[GitHub] spark pull request: [SPARK-10506][SQL]move close() to finally code...
Github user baishuo closed the pull request at: https://github.com/apache/spark/pull/8664 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10506][SQL]move close() to finally code...
Github user baishuo commented on the pull request: https://github.com/apache/spark/pull/8664#issuecomment-142157532 I am so sorry that I worked on trip and diffcult to connect github. @andrewor14 @srowen close this PR I will reopen it when I go back to beijing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10506][SQL]move close() to finally code...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/8664#issuecomment-142094019 @baishuo can you follow up on this, or close the PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10506][SQL]move close() to finally code...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8664#issuecomment-141068913 [Test build #1770 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1770/consoleFull) for PR 8664 at commit [`4b91eac`](https://github.com/apache/spark/commit/4b91eace4d0235a68d43892d413942cc8ed34c36). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10506][SQL]move close() to finally code...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8664#issuecomment-141100130 [Test build #1770 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1770/console) for PR 8664 at commit [`4b91eac`](https://github.com/apache/spark/commit/4b91eace4d0235a68d43892d413942cc8ed34c36). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10506][SQL]move close() to finally code...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/8664#issuecomment-139744497 @baishuo HiveQuerySuite is failing consistently here. I wonder if it is somehow related to this change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10506][SQL]move close() to finally code...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8664#issuecomment-139658801 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42350/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10506][SQL]move close() to finally code...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8664#issuecomment-139658736 [Test build #42350 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42350/console) for PR 8664 at commit [`4b91eac`](https://github.com/apache/spark/commit/4b91eace4d0235a68d43892d413942cc8ed34c36). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10506][SQL]move close() to finally code...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8664#issuecomment-139658799 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10506][SQL]move close() to finally code...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8664#issuecomment-139636862 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10506][SQL]move close() to finally code...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8664#issuecomment-139636843 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10506][SQL]move close() to finally code...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8664#issuecomment-139637363 [Test build #42350 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42350/consoleFull) for PR 8664 at commit [`4b91eac`](https://github.com/apache/spark/commit/4b91eace4d0235a68d43892d413942cc8ed34c36). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10506][SQL]move close() to finally code...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8664#issuecomment-139635993 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10506][SQL]move close() to finally code...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8664#issuecomment-139137850 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10506][SQL]move close() to finally code...
Github user baishuo commented on the pull request: https://github.com/apache/spark/pull/8664#issuecomment-139138023 hi @srowen @andrewor14 after debug, I found before we call UTF8String.fromBytes(output.toByteArray) , we must call generator.close(), otherwise UTF8String.fromBytes will get empty result. That why the code yesterday didnt pass the test. But I dont know the root cause :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10506][SQL]move close() to finally code...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8664#issuecomment-139137874 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10506][SQL]move close() to finally code...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8664#issuecomment-139181422 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10506][SQL]move close() to finally code...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8664#issuecomment-139181291 [Test build #42247 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42247/console) for PR 8664 at commit [`4b91eac`](https://github.com/apache/spark/commit/4b91eace4d0235a68d43892d413942cc8ed34c36). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10506][SQL]move close() to finally code...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8664#issuecomment-139181427 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42247/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10506][SQL]move close() to finally code...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8664#issuecomment-139141958 [Test build #42247 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42247/consoleFull) for PR 8664 at commit [`4b91eac`](https://github.com/apache/spark/commit/4b91eace4d0235a68d43892d413942cc8ed34c36). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10506][SQL]move close() to finally code...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8664#issuecomment-139220355 [Test build #1735 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1735/consoleFull) for PR 8664 at commit [`4b91eac`](https://github.com/apache/spark/commit/4b91eace4d0235a68d43892d413942cc8ed34c36). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10506][SQL]move close() to finally code...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8664#issuecomment-139245101 [Test build #1735 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1735/console) for PR 8664 at commit [`4b91eac`](https://github.com/apache/spark/commit/4b91eace4d0235a68d43892d413942cc8ed34c36). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10506][SQL]move close() to finally code...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8664#issuecomment-138815152 [Test build #1730 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1730/consoleFull) for PR 8664 at commit [`637dee0`](https://github.com/apache/spark/commit/637dee0369ac4dcfa4a5c0f408318ae9e55c0e94). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10506][SQL]move close() to finally code...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8664#issuecomment-138819101 [Test build #1730 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1730/console) for PR 8664 at commit [`637dee0`](https://github.com/apache/spark/commit/637dee0369ac4dcfa4a5c0f408318ae9e55c0e94). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10506][SQL]move close() to finally code...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/8664#issuecomment-138814756 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10506][SQL]move close() to finally code...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8664#issuecomment-139035687 [Test build #42216 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42216/console) for PR 8664 at commit [`637dee0`](https://github.com/apache/spark/commit/637dee0369ac4dcfa4a5c0f408318ae9e55c0e94). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10506][SQL]move close() to finally code...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8664#issuecomment-139035737 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10506][SQL]move close() to finally code...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8664#issuecomment-139035742 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42216/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10506][SQL]move close() to finally code...
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8664#discussion_r39088739
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -132,13 +132,12 @@ case class GetJsonObject(json: Expression, path:
Expression)
}
if (parsed.isDefined) {
+ val parser = jsonFactory.createParser(jsonStr.getBytes)
+ val output = new ByteArrayOutputStream()
+ val generator = jsonFactory.createGenerator(output,
JsonEncoding.UTF8)
--- End diff --
what if these things threw exceptions? Can you make them `var`s instead and
do a null check in finally?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10506][SQL]move close() to finally code...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8664#issuecomment-139030106 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10506][SQL]move close() to finally code...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8664#issuecomment-139029855 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10506][SQL]move close() to finally code...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8664#issuecomment-139030078 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10506][SQL]move close() to finally code...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8664#issuecomment-139030476 [Test build #42216 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42216/consoleFull) for PR 8664 at commit [`637dee0`](https://github.com/apache/spark/commit/637dee0369ac4dcfa4a5c0f408318ae9e55c0e94). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10506][SQL]move close() to finally code...
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8664#discussion_r39099732
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -132,13 +132,12 @@ case class GetJsonObject(json: Expression, path:
Expression)
}
if (parsed.isDefined) {
+ val parser = jsonFactory.createParser(jsonStr.getBytes)
+ val output = new ByteArrayOutputStream()
+ val generator = jsonFactory.createGenerator(output,
JsonEncoding.UTF8)
--- End diff --
If those are also objects that need to be closed, I agree. Otherwise if
those lines fail, there is no generator to close. Moving this outside the try
does change things but it looks like the intent since the catch is only for an
error during parsing. I think.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
