[GitHub] spark pull request: [SPARK-10973][ML][PYTHON] __gettitem__ method ...
Github user zero323 commented on the pull request: https://github.com/apache/spark/pull/9009#issuecomment-147753463 @jkbradley It's my pleasure. I've created a [JIRA](https://issues.apache.org/jira/browse/SPARK-11084) and opened a [PR](https://github.com/apache/spark/pull/9098). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10973][ML][PYTHON] __gettitem__ method ...
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9009#issuecomment-147308172 Yes, please. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10973][ML][PYTHON] __gettitem__ method ...
Github user zero323 commented on the pull request: https://github.com/apache/spark/pull/9009#issuecomment-147244101 @jkbradley Sure, I can do it later this week. Should I open a new JIRA for that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10973][ML][PYTHON] __gettitem__ method ...
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9009#issuecomment-147117437 @zero323 Good point, that's better for sure. Do you mind preparing a patch for 1.6 for that? (I don't think it's necessary to backport it everywhere.) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10973][ML][PYTHON] __gettitem__ method ...
Github user zero323 commented on the pull request: https://github.com/apache/spark/pull/9009#issuecomment-147114654 It should be possible to push this check before binary search: 8a695fe2c3344acd19279fcd539177426d436a02 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10973][ML][PYTHON] __gettitem__ method ...
Github user zero323 commented on the pull request: https://github.com/apache/spark/pull/9009#issuecomment-147108493 @jkbradley https://github.com/apache/spark/pull/9062, https://github.com/apache/spark/pull/9063, https://github.com/apache/spark/pull/9064 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10973][ML][PYTHON] __gettitem__ method ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9009#issuecomment-146714531 [Test build #1862 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1862/consoleFull) for PR 9009 at commit [`a1898ee`](https://github.com/apache/spark/commit/a1898ee172d1b3b4e8f69650edb2ecbc507f13d7). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10973][ML][PYTHON] __gettitem__ method ...
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9009#issuecomment-146714417 Thanks! I'll merge this with master once tests pass. Would you be able to send PRs against branch-1.3, branch-1.4, branch-1.5 in order to backport this to previous Spark versions? They can use the same JIRA number. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10973][ML][PYTHON] __gettitem__ method ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9009#issuecomment-146716786 [Test build #1862 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1862/console) for PR 9009 at commit [`a1898ee`](https://github.com/apache/spark/commit/a1898ee172d1b3b4e8f69650edb2ecbc507f13d7). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10973][ML][PYTHON] __gettitem__ method ...
Github user zero323 commented on the pull request: https://github.com/apache/spark/pull/9009#issuecomment-146689536 @jkbradley Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10973][ML][PYTHON] __gettitem__ method ...
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9009#issuecomment-146732821 merging with master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10973][ML][PYTHON] __gettitem__ method ...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9009 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
