[GitHub] spark pull request: [SPARK-11311] [SQL] spark cannot describe temp...

2015-11-11 Thread yhuai 
Github user yhuai commented on a diff in the pull request:

https://github.com/apache/spark/pull/9277#discussion_r44558700
  
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala 
---
@@ -115,7 +115,11 @@ private[hive] class HiveFunctionRegistry(underlying: 
analysis.FunctionRegistry)
   annotation.value(),
   annotation.extended()))
   } else {
-None
+Some(new ExpressionInfo(
+  info.getFunctionClass.getCanonicalName,
+  name,
+  null,
+  null))
--- End diff --

When will we hit this branch? For Hive UDFs, this fixes the problem because 
UDFs do not have annotation? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11311] [SQL] spark cannot describe temp...

2015-11-11 Thread adrian-wang 
Github user adrian-wang commented on a diff in the pull request:

https://github.com/apache/spark/pull/9277#discussion_r44614264
  
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala 
---
@@ -115,7 +115,11 @@ private[hive] class HiveFunctionRegistry(underlying: 
analysis.FunctionRegistry)
   annotation.value(),
   annotation.extended()))
   } else {
-None
+Some(new ExpressionInfo(
+  info.getFunctionClass.getCanonicalName,
+  name,
+  null,
+  null))
--- End diff --

When we register a function using `create function xx as "org."`, 
sometimes there's no annotation, but spark would complain could not find this 
function.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11311] [SQL] spark cannot describe temp...

2015-11-02 Thread liancheng 
Github user liancheng commented on the pull request:

https://github.com/apache/spark/pull/9277#issuecomment-153044589
  
LGTM, merging to master. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11311] [SQL] spark cannot describe temp...

2015-11-02 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/9277


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11311] [SQL] spark cannot describe temp...

2015-10-26 Thread adrian-wang 
GitHub user adrian-wang opened a pull request:

https://github.com/apache/spark/pull/9277

[SPARK-11311] [SQL] spark cannot describe temporary functions



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/adrian-wang/spark functionreg

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/9277.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #9277


commit e1c0a98ee0aa0d26b9cda14dc48502162cf2091b
Author: Daoyuan Wang 
Date:   2015-10-26T06:57:19Z

fix temporary function description




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11311] [SQL] spark cannot describe temp...

2015-10-26 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9277#issuecomment-151046510
  
 Merged build triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11311] [SQL] spark cannot describe temp...

2015-10-26 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9277#issuecomment-151046521
  
Merged build started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11311] [SQL] spark cannot describe temp...

2015-10-26 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/9277#issuecomment-151047580
  
**[Test build #44345 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44345/consoleFull)**
 for PR 9277 at commit 
[`50bdef7`](https://github.com/apache/spark/commit/50bdef7b41a7e7d1beff4debc27f6b9eea2aafc5).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11311] [SQL] spark cannot describe temp...

2015-10-26 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9277#issuecomment-151046089
  
Merged build started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11311] [SQL] spark cannot describe temp...

2015-10-26 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9277#issuecomment-151046075
  
 Merged build triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11311] [SQL] spark cannot describe temp...

2015-10-26 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9277#issuecomment-151071849
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44345/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11311] [SQL] spark cannot describe temp...

2015-10-26 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/9277#issuecomment-151071437
  
**[Test build #44345 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44345/consoleFull)**
 for PR 9277 at commit 
[`50bdef7`](https://github.com/apache/spark/commit/50bdef7b41a7e7d1beff4debc27f6b9eea2aafc5).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11311] [SQL] spark cannot describe temp...

2015-10-26 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9277#issuecomment-151047755
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44344/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11311] [SQL] spark cannot describe temp...

2015-10-26 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9277#issuecomment-151047753
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org