[GitHub] spark pull request: [SPARK-11457][Streaming][YARN] Fix incorrect A...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/9412


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11457][Streaming][YARN] Fix incorrect A...

[vanzin]

Github user vanzin commented on the pull request:

https://github.com/apache/spark/pull/9412#issuecomment-154260376
  
Those variables are set by the ApplicationMaster code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11457][Streaming][YARN] Fix incorrect A...

[vanzin]

Github user vanzin commented on the pull request:

https://github.com/apache/spark/pull/9412#issuecomment-154255763
  
@tdas @harishreedharan could you guys double check this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11457][Streaming][YARN] Fix incorrect A...

[vanzin]

Github user vanzin commented on the pull request:

https://github.com/apache/spark/pull/9412#issuecomment-154261801
  
Merging this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11457][Streaming][YARN] Fix incorrect A...

[harishreedharan]

Github user harishreedharan commented on the pull request:

https://github.com/apache/spark/pull/9412#issuecomment-154256737
  
Where is this being set into the SparkConf for a normal app? I am not sure 
of the parameters, but setting the new values looks good (not sure if 
`spark.ui.filters` and the other params) are the right ones. @vanzin  - if they 
are, this LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11457][Streaming][YARN] Fix incorrect A...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9412#issuecomment-153340684
  
Merged build started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11457][Streaming][YARN] Fix incorrect A...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9412#issuecomment-153340668
  
 Merged build triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11457][Streaming][YARN] Fix incorrect A...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/9412#issuecomment-153340866
  
**[Test build #44918 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44918/consoleFull)**
 for PR 9412 at commit 
[`c4a9cb9`](https://github.com/apache/spark/commit/c4a9cb93c3d01ee99546b1d0e5e21559a6ea8be1).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11457][Streaming][YARN] Fix incorrect A...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9412#issuecomment-153354845
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11457][Streaming][YARN] Fix incorrect A...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/9412#issuecomment-153354719
  
**[Test build #44918 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44918/consoleFull)**
 for PR 9412 at commit 
[`c4a9cb9`](https://github.com/apache/spark/commit/c4a9cb93c3d01ee99546b1d0e5e21559a6ea8be1).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11457][Streaming][YARN] Fix incorrect A...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9412#issuecomment-153354847
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44918/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11457][Streaming][YARN] Fix incorrect A...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/9412#issuecomment-153013074
  
**[Test build #44810 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44810/consoleFull)**
 for PR 9412 at commit 
[`7e07efe`](https://github.com/apache/spark/commit/7e07efe701cf9dffaaf8411b108bdd2b3ca99f91).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11457][Streaming][YARN] Fix incorrect A...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9412#issuecomment-153028669
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44810/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11457][Streaming][YARN] Fix incorrect A...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9412#issuecomment-153028668
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11457][Streaming][YARN] Fix incorrect A...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/9412#issuecomment-153028495
  
**[Test build #44810 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44810/consoleFull)**
 for PR 9412 at commit 
[`7e07efe`](https://github.com/apache/spark/commit/7e07efe701cf9dffaaf8411b108bdd2b3ca99f91).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11457][Streaming][YARN] Fix incorrect A...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9412#issuecomment-153011717
  
Merged build started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11457][Streaming][YARN] Fix incorrect A...

[jerryshao]

GitHub user jerryshao opened a pull request:

https://github.com/apache/spark/pull/9412

[SPARK-11457][Streaming][YARN] Fix incorrect AM proxy filter conf recovery 
from checkpoint

Currently Yarn AM proxy filter configuration is recovered from checkpoint 
file when Spark Streaming application is restarted, which will lead to some 
unwanted behaviors:

1. Wrong RM address if RM is redeployed from failure.
2. Wrong proxyBase, since app id is updated, old app id for proxyBase is 
wrong.

So instead of recovering from checkpoint file, these configurations should 
be reloaded each time when app started.

This problem only exists in Yarn cluster mode, for Yarn client mode, these 
configurations will be updated with RPC message `AddWebUIFilter`.

Please help to review @tdas @harishreedharan @vanzin , thanks a lot.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jerryshao/apache-spark SPARK-11457

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/9412.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #9412


commit 7e07efe701cf9dffaaf8411b108bdd2b3ca99f91
Author: jerryshao 
Date:   2015-11-02T12:30:35Z

Fix Spark Streaming checkpoint with Yarn-cluster configuration recovery 
issue




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11457][Streaming][YARN] Fix incorrect A...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9412#issuecomment-153011679
  
 Merged build triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11457][Streaming][YARN] Fix incorrect A...

[vanzin]

Github user vanzin commented on the pull request:

https://github.com/apache/spark/pull/9412#issuecomment-153115388
  
LGTM as far as I understand this code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11457][Streaming][YARN] Fix incorrect A...

[vanzin]

Github user vanzin commented on a diff in the pull request:

https://github.com/apache/spark/pull/9412#discussion_r43661295
  
--- Diff: 
streaming/src/main/scala/org/apache/spark/streaming/Checkpoint.scala ---
@@ -66,6 +67,14 @@ class Checkpoint(ssc: StreamingContext, val 
checkpointTime: Time)
 newSparkConf.set(prop, value)
   }
 }
+
+// Add Yarn proxy filter specific configurations to the recovered 
SparkConf
+val filter = 
"org.apache.hadoop.yarn.server.webproxy.amfilter.AmIpFilter"
+val filterPrefix = s"spark.$filter.param."
+newReloadConf.getAll
+  .filter { case (k, v) => k.startsWith(filterPrefix) && k.length > 
filterPrefix.length }
--- End diff --

You could do this inside the `foreach`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org