[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[liancheng]

Github user liancheng commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-163529939
  
Since there's a conflict and 1.6 is in RC phase, I opened #10250 to 
backport this one to branch-1.6, so that it's tested on Jenkins.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-163178578
  
**[Test build #47422 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47422/consoleFull)**
 for PR 10004 at commit 
[`02448a6`](https://github.com/apache/spark/commit/02448a6191c2bcec78c7d1a1247ba45c7192164e).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[liancheng]

Github user liancheng commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-163152700
  
@nongli Uploaded new screenshot and rebased to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-163153888
  
**[Test build #47422 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47422/consoleFull)**
 for PR 10004 at commit 
[`02448a6`](https://github.com/apache/spark/commit/02448a6191c2bcec78c7d1a1247ba45c7192164e).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-163178822
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47422/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-163178820
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[liancheng]

Github user liancheng commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-163187890
  
I know that the current visual effect of super long paths isn't perfect, 
but at least it doesn't introduce super wide plan nodes. And this is also how 
our current UI handles super long text.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[rxin]

Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-163295721
  
hm i had trouble cherrypicking it into 1.6. Can you do it yourself?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[rxin]

Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-163290673
  
I'm going to merge this into master/1.6.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/10004


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[nongli]

Github user nongli commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-162994016
  
Can you add a screenshot if the path is really long?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[liancheng]

Github user liancheng commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-161221212
  
@rxin One problem I found is that, the tooltip box is of fixed width. This 
means that the full path can never be fully observed if it's too long. But I 
agree that we should keep the normal box relatively smaller. I'll just remove 
the metadata entries in the normal box.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-161232406
  
**[Test build #47050 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47050/consoleFull)**
 for PR 10004 at commit 
[`863df7c`](https://github.com/apache/spark/commit/863df7ce59bc19ef61a482ffe944b83e710a0961).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-161262393
  
**[Test build #47050 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47050/consoleFull)**
 for PR 10004 at commit 
[`863df7c`](https://github.com/apache/spark/commit/863df7ce59bc19ef61a482ffe944b83e710a0961).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-161262717
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47050/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-161262714
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[liancheng]

Github user liancheng commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-160910296
  
Comments addressed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[rxin]

Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-160914904
  
Is it possible to only show the short text in the normal box, and then when 
hover, show the full path? I'm very concerned about long paths.


cc @zsxwing 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-160915409
  
**[Test build #46959 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46959/consoleFull)**
 for PR 10004 at commit 
[`6891876`](https://github.com/apache/spark/commit/68918769dee5fdd2105715b7e542f9d263650e71).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-160930182
  
**[Test build #46959 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46959/consoleFull)**
 for PR 10004 at commit 
[`6891876`](https://github.com/apache/spark/commit/68918769dee5fdd2105715b7e542f9d263650e71).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-160930237
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-160930238
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46959/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[andrewor14]

Github user andrewor14 commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-160820757
  
Can we not show `PushedFilters` if there are no pushed filters?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[andrewor14]

Github user andrewor14 commented on a diff in the pull request:

https://github.com/apache/spark/pull/10004#discussion_r46231611
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SparkPlanGraph.scala 
---
@@ -85,26 +89,51 @@ private[sql] object SparkPlanGraph {
  * @param metrics metrics that this SparkPlan node will track
  */
 private[ui] case class SparkPlanGraphNode(
-id: Long, name: String, desc: String, metrics: Seq[SQLPlanMetric]) {
+id: Long,
+name: String,
+desc: String,
+metadata: Map[String, String],
+metrics: Seq[SQLPlanMetric]) {
 
   def makeDotNode(metricsValue: Map[Long, String]): String = {
-val values = {
-  for (metric <- metrics;
-   value <- metricsValue.get(metric.accumulatorId)) yield {
-metric.name + ": " + value
-  }
-}
-val label = if (values.isEmpty) {
-name
+val builder = mutable.StringBuilder.newBuilder
+
+builder ++= name
+
+def truncateLongText(text: String) = {
--- End diff --

return type


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[andrewor14]

Github user andrewor14 commented on a diff in the pull request:

https://github.com/apache/spark/pull/10004#discussion_r46231579
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
 ---
@@ -315,7 +316,14 @@ private[sql] object DataSourceStrategy extends 
Strategy with Logging {
 // `Filter`s or cannot be handled by `relation`.
 val filterCondition = 
unhandledPredicates.reduceLeftOption(expressions.And)
 
-val pushedFiltersString = pushedFilters.mkString(" PushedFilter: [", 
",", "] ")
+val metadata = {
--- End diff --

can you add the type to this `val`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-160295792
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-160295756
  
**[Test build #46841 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46841/consoleFull)**
 for PR 10004 at commit 
[`5d12dd7`](https://github.com/apache/spark/commit/5d12dd7df3ec64f99708a121989641432e792e8d).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-160295794
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46841/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[liancheng]

Github user liancheng commented on a diff in the pull request:

https://github.com/apache/spark/pull/10004#discussion_r46078778
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala ---
@@ -422,7 +422,7 @@ abstract class HadoopFsRelation private[sql](
 parameters: Map[String, String])
   extends BaseRelation with FileRelation with Logging {
 
-  override def toString: String = getClass.getSimpleName + 
paths.mkString("[", ",", "]")
+  override def toString: String = getClass.getSimpleName
--- End diff --

Removed the paths string because it's now shown as part of the metadata in 
both `simpleString` and visualized plan node.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-160277691
  
**[Test build #46841 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46841/consoleFull)**
 for PR 10004 at commit 
[`5d12dd7`](https://github.com/apache/spark/commit/5d12dd7df3ec64f99708a121989641432e792e8d).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-160175554
  
**[Test build #46825 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46825/consoleFull)**
 for PR 10004 at commit 
[`8cbf0ff`](https://github.com/apache/spark/commit/8cbf0ff166f57f0592149381bf3a8daf7ed311c4).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-160171989
  
**[Test build #46825 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46825/consoleFull)**
 for PR 10004 at commit 
[`8cbf0ff`](https://github.com/apache/spark/commit/8cbf0ff166f57f0592149381bf3a8daf7ed311c4).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[liancheng]

Github user liancheng commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-160170582
  
@rxin Updated. Now it shows `ParquetRelation` and `OrcRelation` etc. 
instead of `PhysicalRDD`. Hive metastore table name is also attached. For the 
long input paths scenario, yes it makes the box super wide. So in the last 
commit, I truncate the text if it's longer than 100 characters. This is 
somewhat brutal, but I'm not sure about the best practice here. Maybe doing the 
truncation in JS side is a better idea?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-160175612
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46825/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-160175611
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-160250890
  
**[Test build #46835 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46835/consoleFull)**
 for PR 10004 at commit 
[`6925eb3`](https://github.com/apache/spark/commit/6925eb310bdfcdf465b315dabf18f03a6578a633).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[liancheng]

Github user liancheng commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-160249898
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-160248965
  
**[Test build #46833 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46833/consoleFull)**
 for PR 10004 at commit 
[`6925eb3`](https://github.com/apache/spark/commit/6925eb310bdfcdf465b315dabf18f03a6578a633).
 * This patch **fails PySpark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-160248975
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46833/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-160248974
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-160256822
  
**[Test build #46835 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46835/consoleFull)**
 for PR 10004 at commit 
[`6925eb3`](https://github.com/apache/spark/commit/6925eb310bdfcdf465b315dabf18f03a6578a633).
 * This patch **fails PySpark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-160256997
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-160242980
  
**[Test build #46833 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46833/consoleFull)**
 for PR 10004 at commit 
[`6925eb3`](https://github.com/apache/spark/commit/6925eb310bdfcdf465b315dabf18f03a6578a633).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[liancheng]

GitHub user liancheng opened a pull request:

https://github.com/apache/spark/pull/10004

[SPARK-12012] [SQL] Show more comprehensive PhysicalRDD metadata when 
visualizing SQL query plan

This PR adds a `private[sql]` method `metadata` to `SparkPlan`, which can 
be used to describe detail information about a physical plan during 
visualization. Specifically, this PR uses this method to provide details of 
`PhysicalRDD`s translated from a data source relation. As shown in the 
following screenshot:


![image](https://cloud.githubusercontent.com/assets/230655/11422817/0249861a-947a-11e5-8ee5-c7fdd618dec4.png)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/liancheng/spark 
spark-12012.physical-rdd-metadata

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/10004.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10004


commit b6a32c76e3f4f26673672a916b6b5b77484c174b
Author: Cheng Lian 
Date:   2015-11-26T12:02:34Z

Show more comprehensive PhysicalRDD metadata when visualizing SQL query plan




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[liancheng]

Github user liancheng commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-159901213
  
cc @andrewor14 @yhuai


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-159902733
  
**[Test build #46765 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46765/consoleFull)**
 for PR 10004 at commit 
[`b6a32c7`](https://github.com/apache/spark/commit/b6a32c76e3f4f26673672a916b6b5b77484c174b).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-159907678
  
**[Test build #46765 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46765/consoleFull)**
 for PR 10004 at commit 
[`b6a32c7`](https://github.com/apache/spark/commit/b6a32c76e3f4f26673672a916b6b5b77484c174b).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-159907707
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-159907709
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46765/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

[rxin]

Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/10004#issuecomment-159977685
  
I wouldn't have the top level name be "PhysicalRDD" - that term just makes 
no sense to users.

I'd consider just putting "Orc" there. If it is a Hive table, just saying 
"Scan: table name" might work too".

BTW - if the path is super long, is the box going to be expanded to super 
wide as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org