[GitHub] spark pull request: [SPARK-12200][SQL] Add __contains__ implementa...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10194 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12200][SQL] Add __contains__ implementa...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10194#issuecomment-218576323 LGTM - merging in master/2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12200][SQL] Add __contains__ implementa...
Github user davies commented on the pull request: https://github.com/apache/spark/pull/10194#issuecomment-218553740 cc @rxin on the sematics change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12200][SQL] Add __contains__ implementa...
Github user maver1ck commented on the pull request: https://github.com/apache/spark/pull/10194#issuecomment-218553241 @holdenk Thanks :) @davies I think everything is OK. Can we merge it also into 2.0 branch ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12200][SQL] Add __contains__ implementa...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10194#issuecomment-218552507 **[Test build #2984 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2984/consoleFull)** for PR 10194 at commit [`5b1b338`](https://github.com/apache/spark/commit/5b1b338c86903605f4b3fb33cceba6f572de3dc1). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12200][SQL] Add __contains__ implementa...
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/10194#issuecomment-218547797 @maver1ck normally Jenkins will automatically retest on push (although there can be some delay if there is a backlog). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12200][SQL] Add __contains__ implementa...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10194#issuecomment-218547534 **[Test build #2984 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2984/consoleFull)** for PR 10194 at commit [`5b1b338`](https://github.com/apache/spark/commit/5b1b338c86903605f4b3fb33cceba6f572de3dc1). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12200][SQL] Add __contains__ implementa...
Github user maver1ck commented on the pull request: https://github.com/apache/spark/pull/10194#issuecomment-218547285 @davies I fixed whitespaces. Can we test this one more time ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12200][SQL] Add __contains__ implementa...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10194#issuecomment-218543818 **[Test build #2983 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2983/consoleFull)** for PR 10194 at commit [`aff15f8`](https://github.com/apache/spark/commit/aff15f80a50b899cb40ee61db5f89ace6a634496). * This patch **fails Python style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12200][SQL] Add __contains__ implementa...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10194#issuecomment-218543600 **[Test build #2983 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2983/consoleFull)** for PR 10194 at commit [`aff15f8`](https://github.com/apache/spark/commit/aff15f80a50b899cb40ee61db5f89ace6a634496). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12200][SQL] Add __contains__ implementa...
Github user davies commented on the pull request: https://github.com/apache/spark/pull/10194#issuecomment-218543523 @maver1ck Sorry, I misunderstood it. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12200][SQL] Add __contains__ implementa...
Github user maver1ck commented on the pull request: https://github.com/apache/spark/pull/10194#issuecomment-218384288 @davies But you mentioned current behaviour. My patch is to change it, so you could access the column by `row['col_name']` and `'col_name' in row` will return **True**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12200][SQL] Add __contains__ implementa...
Github user davies commented on the pull request: https://github.com/apache/spark/pull/10194#issuecomment-218220364 I think it's confusing to support this, for example, you could access the column by `row['col_name']`, but `'col_name' in row` will return False. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12200][SQL] Add __contains__ implementa...
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/10194#issuecomment-218082133 Maybe @davies because I see most of codes are written by him --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
