[GitHub] spark pull request: [SPARK-12222] [Core] Deserialize RoaringBitmap...

[highmoutain]

Github user highmoutain commented on the pull request:

https://github.com/apache/spark/pull/10213#issuecomment-173475873
  
does this problem have been solved in 1.6.0?
But I encoutered this problem again in 1.6.0 when I use udf.
my version is spark-1.6.0-bin-hadoop2.6.tgz.


(p.mobile_id, 'model', 'MOBILE_MODEL') as mobile_model from 
analytics_device_profile_zh10 p limit 1;
16/01/21 14:47:29 WARN TaskSetManager: Lost task 0.0 in stage 44.0 (TID 44, 
172.30.4.216): com.esotericsoftware.kryo.KryoException: Buffer underflow.
Serialization trace:

mobileAttributeCahceMap (enterprise.hive.udfs.ConvertDeviceModel)
at com.esotericsoftware.kryo.io.Input.require(Input.java:156)
at com.esotericsoftware.kryo.io.Input.readAscii_slow(Input.java:580)
at com.esotericsoftware.kryo.io.Input.readAscii(Input.java:558)
at com.esotericsoftware.kryo.io.Input.readString(Input.java:436)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12222] [Core] Deserialize RoaringBitmap...

[davies]

Github user davies commented on the pull request:

https://github.com/apache/spark/pull/10213#issuecomment-173480519
  
@highmoutain This patch was included in 1.6.0. Your problem looks like not 
related to this one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12222] [Core] Deserialize RoaringBitmap...

[sarutak]

Github user sarutak commented on the pull request:

https://github.com/apache/spark/pull/10253#issuecomment-167665206
  
LGTM.  Merging this into `master` and `branch-1.6`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12222] [Core] Deserialize RoaringBitmap...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/10253


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12222] [Core] Deserialize RoaringBitmap...

[adrian-wang]

GitHub user adrian-wang opened a pull request:

https://github.com/apache/spark/pull/10253

[SPARK-1] [Core] Deserialize RoaringBitmap using Kryo serializer throw 
Buffer underflow exception

Since we only need to implement `def skipBytes(n: Int)`,
code in #10213 could be simplified.
@davies @scwf 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/adrian-wang/spark kryo

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/10253.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10253


commit 90c3152acbcb6f67786f9bd76992cd7e7d46a718
Author: Daoyuan Wang 
Date:   2015-12-10T08:46:30Z

kryo skip




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12222] [Core] Deserialize RoaringBitmap...

[scwf]

Github user scwf commented on the pull request:

https://github.com/apache/spark/pull/10253#issuecomment-163590407
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12222] [Core] Deserialize RoaringBitmap...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10253#issuecomment-163827705
  
**[Test build #47564 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47564/consoleFull)**
 for PR 10253 at commit 
[`90c3152`](https://github.com/apache/spark/commit/90c3152acbcb6f67786f9bd76992cd7e7d46a718).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12222] [Core] Deserialize RoaringBitmap...

[adrian-wang]

Github user adrian-wang commented on the pull request:

https://github.com/apache/spark/pull/10253#issuecomment-163825599
  
retest this please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12222] [Core] Deserialize RoaringBitmap...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10253#issuecomment-163842706
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12222] [Core] Deserialize RoaringBitmap...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10253#issuecomment-163842710
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47564/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12222] [Core] Deserialize RoaringBitmap...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10253#issuecomment-163842537
  
**[Test build #47564 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47564/consoleFull)**
 for PR 10253 at commit 
[`90c3152`](https://github.com/apache/spark/commit/90c3152acbcb6f67786f9bd76992cd7e7d46a718).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12222] [Core] Deserialize RoaringBitmap...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10253#issuecomment-163647364
  
**[Test build #47498 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47498/consoleFull)**
 for PR 10253 at commit 
[`90c3152`](https://github.com/apache/spark/commit/90c3152acbcb6f67786f9bd76992cd7e7d46a718).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12222] [Core] Deserialize RoaringBitmap...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10213#issuecomment-163090489
  
**[Test build #47396 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47396/consoleFull)**
 for PR 10213 at commit 
[`01d37b0`](https://github.com/apache/spark/commit/01d37b0e1833dd17aedd27427102edef3ffdba79).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12222] [Core] Deserialize RoaringBitmap...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10213#issuecomment-163107230
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47396/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12222] [Core] Deserialize RoaringBitmap...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10213#issuecomment-163107229
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12222] [Core] Deserialize RoaringBitmap...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/10213


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12222] [Core] Deserialize RoaringBitmap...

[scwf]

Github user scwf commented on the pull request:

https://github.com/apache/spark/pull/10213#issuecomment-163089761
  
/cc @davies 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12222] [Core] Deserialize RoaringBitmap...

[scwf]

GitHub user scwf opened a pull request:

https://github.com/apache/spark/pull/10213

[SPARK-1] [Core] Deserialize RoaringBitmap using Kryo serializer throw 
Buffer underflow exception

Deserialize RoaringBitmap using Kryo serializer throw Buffer underflow 
exception:
```
com.esotericsoftware.kryo.KryoException: Buffer underflow.
at com.esotericsoftware.kryo.io.Input.require(Input.java:156)
at com.esotericsoftware.kryo.io.Input.skip(Input.java:131)
at com.esotericsoftware.kryo.io.Input.skip(Input.java:264)
at 
org.apache.spark.sql.SQLQuerySuite$$anonfun$6$KryoInputDataInputBridge$1.skipBytes
```

This is caused by a bug of kryo's `Input.skip(long 
count)`(https://github.com/EsotericSoftware/kryo/issues/119) and we call this 
method in `KryoInputDataInputBridge`.

Instead of upgrade kryo's version, this pr bypass the  kryo's 
`Input.skip(long count)` by directly call another `skip` method in kryo's 
Input.java(https://github.com/EsotericSoftware/kryo/blob/kryo-2.21/src/com/esotericsoftware/kryo/io/Input.java#L124),
 i.e. write the bug-fixed version of `Input.skip(long count)` in 
KryoInputDataInputBridge's `skipBytes` method.

more detail link to 
https://github.com/apache/spark/pull/9748#issuecomment-162860246

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scwf/spark patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/10213.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10213


commit edf438443b35e131490e8652d6382143180b9e26
Author: Fei Wang 
Date:   2015-12-09T02:41:42Z

fix skipBytes

commit 01d37b0e1833dd17aedd27427102edef3ffdba79
Author: Fei Wang 
Date:   2015-12-09T02:45:19Z

added test suite




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12222] [Core] Deserialize RoaringBitmap...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10213#issuecomment-163107186
  
**[Test build #47396 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47396/consoleFull)**
 for PR 10213 at commit 
[`01d37b0`](https://github.com/apache/spark/commit/01d37b0e1833dd17aedd27427102edef3ffdba79).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12222] [Core] Deserialize RoaringBitmap...

[davies]

Github user davies commented on the pull request:

https://github.com/apache/spark/pull/10213#issuecomment-163115766
  
LGTM, merging into master and 1.6, thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org