[GitHub] spark pull request: [SPARK-12232][SPARKR] New R API for read.table...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10406 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12232][SPARKR] New R API for read.table...
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/10406#issuecomment-173063751 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12232][SPARKR] New R API for read.table...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10406#issuecomment-173063070 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49746/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12232][SPARKR] New R API for read.table...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10406#issuecomment-173063069 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12232][SPARKR] New R API for read.table...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10406#issuecomment-173063002 **[Test build #49746 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49746/consoleFull)** for PR 10406 at commit [`42b5af7`](https://github.com/apache/spark/commit/42b5af7ad6f066132d63fb1b3e220daa77a176ba). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12232][SPARKR] New R API for read.table...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10406#issuecomment-173059522 **[Test build #49746 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49746/consoleFull)** for PR 10406 at commit [`42b5af7`](https://github.com/apache/spark/commit/42b5af7ad6f066132d63fb1b3e220daa77a176ba). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12232][SPARKR] New R API for read.table...
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/10406#issuecomment-173059336 Thanks. LGTM. I'll just keep this open for a few hours to see if @sun-rui has any comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12232][SPARKR] New R API for read.table...
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/10406#issuecomment-173058870 Done, updated code, tests, and doc. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12232][SPARKR] New R API for read.table...
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/10406#issuecomment-173051373 These's the migration guide: http://spark.apache.org/docs/latest/sparkr.html#migration-guide --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12232][SPARKR] New R API for read.table...
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/10406#issuecomment-173048765 Yes - removing `table` is fine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12232][SPARKR] New R API for read.table...
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/10406#issuecomment-173049103 We should make a note in the release notes / deprecation from 1.x to 2.0 list somewhere as well cc @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12232][SPARKR] New R API for read.table...
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/10406#issuecomment-173043622 right.. `tables` is returning a DataFrame whereas `tableNames` is returning a vector? I'll open a JIRA to discuss these two. For this, are we ok to remove `table` now, instead of .Deprecate I have here? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12232][SPARKR] New R API for read.table...
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/10406#issuecomment-173038750 So `tableToDF` actually sounds good to me and its fine to assume that somebody using SparkR thinks of table as a SQL table, so `saveToTable`, `dropTempTable` etc. sound fine to me. We should definitely remove `table` which conflicts with base R and is completely unrelated. As for `tables` I'm also inclined to remove it especially if `tableNames` returns the same thing. Anyway you can open a new JIRA for discussing the rename / removal as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12232][SPARKR] New R API for read.table...
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/10406#issuecomment-173036074 Sure - I think we are saying this should be called `tableToDF`. What about `tables`, `saveToTable`, `cacheTable`, `dropTempTable`, or `tableNames`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12232][SPARKR] New R API for read.table...
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/10406#issuecomment-173033926 Sorry for the delay in getting back on this - I agree that using `table` to refer to SQL table is probably fine. Also since this will go into 2.0 we can probably remove some of the old functions like `tables` instead of marking them as deprecated ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12232][SPARKR] New R API for read.table...
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/10406#issuecomment-167913609 IMO, In the context of Spark, `table` means SQL table. Now that we have so many existing APIs using table in their names, as a new API, it is better to be consistent. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12232][SPARKR] New R API for read.table...
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/10406#issuecomment-167893445 @shivaram @sun-rui any thought on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12232][SPARKR] New R API for read.table...
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/10406#issuecomment-166514082 I'm not sure - `table` in R generally is associated with `data.frame` (think `read.table`) or the popular `data.table`, I actually think `saveAsTable` and `tables` should be updated for clarity as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12232][SPARKR] New R API for read.table...
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/10406#issuecomment-166180732 How about "tableToDF" ? there are some API methods having table in their names, like "createExternalTable", "saveAsTable", "tables". "tableToDF" is shorter and consistent. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
