[GitHub] spark pull request: [SPARK-12421][SQL] Prevent Internal/External r...

2016-01-04 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/10553


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12421][SQL] Prevent Internal/External r...

2016-01-04 Thread marmbrus 
Github user marmbrus commented on the pull request:

https://github.com/apache/spark/pull/10553#issuecomment-168800925
  
Thanks, merging to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12421][SQL] Prevent Internal/External r...

2016-01-02 Thread hvanhovell 
GitHub user hvanhovell opened a pull request:

https://github.com/apache/spark/pull/10553

[SPARK-12421][SQL] Prevent Internal/External row from exposing state.

It is currently possible to change the values of the supposedly immutable 
```GenericRow``` and ```GenericInternalRow``` classes. This is caused by the 
fact that scala's ArrayOps ```toArray``` will return the backing array instead 
of a copy. This PR fixes this problem.

This PR was inspired by https://github.com/apache/spark/pull/10374 by @apo1.

cc @apo1 @sarutak @marmbrus @cloud-fan @nongli (everyone in the previous 
conversation).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/hvanhovell/spark SPARK-12421

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/10553.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10553


commit 632b5dc202cce7ec7e2826018e06d120a4cd33d1
Author: Herman van Hovell 
Date:   2016-01-02T11:34:05Z

Prevent leaking state from internal/external row.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12421][SQL] Prevent Internal/External r...

2016-01-02 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10553#issuecomment-168390480
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48581/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12421][SQL] Prevent Internal/External r...

2016-01-02 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10553#issuecomment-168390446
  
**[Test build #48581 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48581/consoleFull)**
 for PR 10553 at commit 
[`632b5dc`](https://github.com/apache/spark/commit/632b5dc202cce7ec7e2826018e06d120a4cd33d1).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12421][SQL] Prevent Internal/External r...

2016-01-02 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10553#issuecomment-168392086
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12421][SQL] Prevent Internal/External r...

2016-01-02 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10553#issuecomment-168391748
  
**[Test build #48582 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48582/consoleFull)**
 for PR 10553 at commit 
[`daa123b`](https://github.com/apache/spark/commit/daa123bc76c16bc3331c140c6c4656f02af89a53).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12421][SQL] Prevent Internal/External r...

2016-01-02 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10553#issuecomment-168384349
  
**[Test build #48582 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48582/consoleFull)**
 for PR 10553 at commit 
[`daa123b`](https://github.com/apache/spark/commit/daa123bc76c16bc3331c140c6c4656f02af89a53).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12421][SQL] Prevent Internal/External r...

2016-01-02 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10553#issuecomment-168383990
  
**[Test build #48581 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48581/consoleFull)**
 for PR 10553 at commit 
[`632b5dc`](https://github.com/apache/spark/commit/632b5dc202cce7ec7e2826018e06d120a4cd33d1).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12421][SQL] Prevent Internal/External r...

2016-01-02 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10553#issuecomment-168390479
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12421][SQL] Prevent Internal/External r...

2016-01-02 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10553#issuecomment-168392090
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48582/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12421][SQL] Prevent Internal/External r...

2016-01-02 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10553#issuecomment-168395737
  
**[Test build #48584 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48584/consoleFull)**
 for PR 10553 at commit 
[`4d5d162`](https://github.com/apache/spark/commit/4d5d1621cc94bbf8d90ad99b13fba25e816058c0).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12421][SQL] Prevent Internal/External r...

2016-01-02 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10553#issuecomment-168401275
  
**[Test build #48584 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48584/consoleFull)**
 for PR 10553 at commit 
[`4d5d162`](https://github.com/apache/spark/commit/4d5d1621cc94bbf8d90ad99b13fba25e816058c0).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12421][SQL] Prevent Internal/External r...

2016-01-02 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10553#issuecomment-168401330
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48584/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12421][SQL] Prevent Internal/External r...

2016-01-02 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10553#issuecomment-168401328
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org