[GitHub] spark pull request: [SPARK-12578][SQL] Distinct should not be sile...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10557 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12578][SQL] Distinct should not be sile...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10557#issuecomment-169267439 Merged. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12578][SQL] Distinct should not be sile...
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/10557#issuecomment-169106215 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12578][SQL] Distinct should not be sile...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10557#issuecomment-168468517 cc @hvanhovell --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12578][SQL] Distinct should not be sile...
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/10557#issuecomment-168457622 ping @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12578][SQL] Distinct should not be sile...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10557#issuecomment-168426184 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48587/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12578][SQL] Distinct should not be sile...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10557#issuecomment-168426183 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12578][SQL] Distinct should not be sile...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10557#issuecomment-168426136 **[Test build #48587 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48587/consoleFull)** for PR 10557 at commit [`79db0eb`](https://github.com/apache/spark/commit/79db0eb149c025d214b0213d9cc671faa2b10ac6). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12578][SQL] Distinct should not be sile...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10557#issuecomment-168416561 **[Test build #48587 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48587/consoleFull)** for PR 10557 at commit [`79db0eb`](https://github.com/apache/spark/commit/79db0eb149c025d214b0213d9cc671faa2b10ac6). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12578][SQL] Distinct should not be sile...
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/10557 [SPARK-12578][SQL] Distinct should not be silently ignored when used in an aggregate function with OVER clause JIRA: https://issues.apache.org/jira/browse/SPARK-12578 Slightly update to Hive parser. We should keep the distinct keyword when used in an aggregate function with OVER clause. So the CheckAnalysis will detect it and throw exception later. You can merge this pull request into a Git repository by running: $ git pull https://github.com/viirya/spark-1 keep-distinct-hivesql Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/10557.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #10557 commit 79db0eb149c025d214b0213d9cc671faa2b10ac6 Author: Liang-Chi Hsieh Date: 2016-01-02T18:34:01Z window function: distinct should not be silently ignored. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
