[GitHub] spark pull request: [SPARK-12668] Renaming CSV options to be simil...

2016-01-17 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10800#issuecomment-172437737
  
**[Test build #49572 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49572/consoleFull)**
 for PR 10800 at commit 
[`8992d41`](https://github.com/apache/spark/commit/8992d414b43188e58e8edd415f57d345471ef1dc).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-12668] Renaming CSV options to be simil...

2016-01-17 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request:

https://github.com/apache/spark/pull/10800#issuecomment-172435937
  
@falaki Ah, right.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-12668] Renaming CSV options to be simil...

2016-01-17 Thread falaki
Github user falaki commented on the pull request:

https://github.com/apache/spark/pull/10800#issuecomment-172434826
  
@HyukjinKwon please do not replace existing option names. Please just 
provide aliases. This can be done entirely inside `CSVParameters.scala`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-12668] Renaming CSV options to be simil...

2016-01-17 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request:

https://github.com/apache/spark/pull/10800

[SPARK-12668] Renaming CSV options to be similar to Pandas and R

https://issues.apache.org/jira/browse/SPARK-12668

Spark CSV datasource has been being merged (file in 
[SPARK-12420](https://issues.apache.org/jira/browse/SPARK-12420)). This is a 
quicky PR that simply renames several CSV options to  similar to Pandas and R.

- Alias for delimiter ­-> sep
- charset -­> encoding

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/HyukjinKwon/spark SPARK-12668

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/10800.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10800


commit 8992d414b43188e58e8edd415f57d345471ef1dc
Author: hyukjinkwon 
Date:   2016-01-18T05:40:34Z

Simply rename the options from delimiter to seq and from charset to encoding




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org