[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-177415413 Thanks - merging this in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-177364338 cc @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10723 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176682737 **[Test build #50366 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50366/consoleFull)** for PR 10723 at commit [`8b7086e`](https://github.com/apache/spark/commit/8b7086e85c10d537cd21e926d9129f9edf853445). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `case class SetDatabaseCommand(databaseName: String) extends RunnableCommand ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176801107 **[Test build #50382 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50382/consoleFull)** for PR 10723 at commit [`8b7086e`](https://github.com/apache/spark/commit/8b7086e85c10d537cd21e926d9129f9edf853445). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `case class SetDatabaseCommand(databaseName: String) extends RunnableCommand ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176801387 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176801392 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50382/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176646326 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176646327 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50355/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176646144 **[Test build #50355 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50355/consoleFull)** for PR 10723 at commit [`8b7086e`](https://github.com/apache/spark/commit/8b7086e85c10d537cd21e926d9129f9edf853445). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `case class SetDatabaseCommand(databaseName: String) extends RunnableCommand ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176687778 It's weird. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176687829 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176689503 See how another round of test shows. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176737679 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50377/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176737672 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176742653 ping @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176693744 **[Test build #50377 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50377/consoleFull)** for PR 10723 at commit [`8b7086e`](https://github.com/apache/spark/commit/8b7086e85c10d537cd21e926d9129f9edf853445). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176750935 **[Test build #50382 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50382/consoleFull)** for PR 10723 at commit [`8b7086e`](https://github.com/apache/spark/commit/8b7086e85c10d537cd21e926d9129f9edf853445). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176689278 Yeah, I think so. And I don't update codes since last successful test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176744090 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176744070 @viirya I am gonna trigger another test to make sure things keep working. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176695515 Many unrelated failures like can't find hive jar file. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176750381 @hvanhovell ok, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176688345 It is, can't make sense of this either. Are tests passing locally? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176736649 **[Test build #50377 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50377/consoleFull)** for PR 10723 at commit [`8b7086e`](https://github.com/apache/spark/commit/8b7086e85c10d537cd21e926d9129f9edf853445). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `case class SetDatabaseCommand(databaseName: String) extends RunnableCommand ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176649593 **[Test build #50366 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50366/consoleFull)** for PR 10723 at commit [`8b7086e`](https://github.com/apache/spark/commit/8b7086e85c10d537cd21e926d9129f9edf853445). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176648006 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176682866 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50366/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176682864 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176279389 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176257408 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50276/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176257400 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176256620 **[Test build #50276 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50276/consoleFull)** for PR 10723 at commit [`7d31844`](https://github.com/apache/spark/commit/7d3184477938139a7bb8b6046520290bf13e9a2a). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176612064 **[Test build #50355 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50355/consoleFull)** for PR 10723 at commit [`8b7086e`](https://github.com/apache/spark/commit/8b7086e85c10d537cd21e926d9129f9edf853445). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176049626 **[Test build #50258 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50258/consoleFull)** for PR 10723 at commit [`7350f07`](https://github.com/apache/spark/commit/7350f07597fa7072751158184b113f27220e9c0f). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/10723#discussion_r51096951
--- Diff:
sql/catalyst/src/main/antlr3/org/apache/spark/sql/catalyst/parser/SparkSqlLexer.g
---
@@ -465,7 +467,7 @@ Identifier
fragment
QuotedIdentifier
:
-'`' ( '``' | ~('`') )* '`' { setText(getText().substring(1,
getText().length() -1 ).replaceAll("``", "`")); }
+'`' ( '``' | ~('`') )* '`' { setText(getText().replaceAll("``",
"`")); }
--- End diff --
Then I think we can make `cleanIdentifier` to strip the inital and final
backticks for this case too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176049783 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50258/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176049782 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10723#discussion_r51105544
--- Diff:
sql/catalyst/src/main/antlr3/org/apache/spark/sql/catalyst/parser/SparkSqlLexer.g
---
@@ -465,7 +467,7 @@ Identifier
fragment
QuotedIdentifier
:
-'`' ( '``' | ~('`') )* '`' { setText(getText().substring(1,
getText().length() -1 ).replaceAll("``", "`")); }
+'`' ( '``' | ~('`') )* '`' { setText(getText().replaceAll("``",
"`")); }
--- End diff --
That would solve it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/10723#discussion_r51107309
--- Diff:
sql/catalyst/src/main/antlr3/org/apache/spark/sql/catalyst/parser/SparkSqlLexer.g
---
@@ -465,7 +467,7 @@ Identifier
fragment
QuotedIdentifier
:
-'`' ( '``' | ~('`') )* '`' { setText(getText().substring(1,
getText().length() -1 ).replaceAll("``", "`")); }
+'`' ( '``' | ~('`') )* '`' { setText(getText().replaceAll("``",
"`")); }
--- End diff --
Yeah, I will update this later. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176208155 **[Test build #50276 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50276/consoleFull)** for PR 10723 at commit [`7d31844`](https://github.com/apache/spark/commit/7d3184477938139a7bb8b6046520290bf13e9a2a). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/10723#discussion_r51074963
--- Diff:
sql/catalyst/src/main/antlr3/org/apache/spark/sql/catalyst/parser/SparkSqlLexer.g
---
@@ -465,7 +467,7 @@ Identifier
fragment
QuotedIdentifier
:
-'`' ( '``' | ~('`') )* '`' { setText(getText().substring(1,
getText().length() -1 ).replaceAll("``", "`")); }
+'`' ( '``' | ~('`') )* '`' { setText(getText().replaceAll("``",
"`")); }
--- End diff --
The above query will get ParseException: mismatched character ''
expecting '`'.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/10723#discussion_r51074937
--- Diff:
sql/catalyst/src/main/antlr3/org/apache/spark/sql/catalyst/parser/SparkSqlLexer.g
---
@@ -465,7 +467,7 @@ Identifier
fragment
QuotedIdentifier
:
-'`' ( '``' | ~('`') )* '`' { setText(getText().substring(1,
getText().length() -1 ).replaceAll("``", "`")); }
+'`' ( '``' | ~('`') )* '`' { setText(getText().replaceAll("``",
"`")); }
--- End diff --
`QuotedIdentifier` originally strips first and last backticks. So we don't
know if an identifier is quoted or not. In create table ddl commands, you can
specify a column name with quoted string to use special characters. If we strip
backticks early at `QuotedIdentifier`, then we can not have these column names
passed in. So I change it to not strip the first and last backticks and use
`cleanIdentifier` to get rid of the backticks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176013876 @hvanhovell Thanks for reviewing this. I've updated this to address your comments. Please see if it is proper for you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-176019860 **[Test build #50258 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50258/consoleFull)** for PR 10723 at commit [`7350f07`](https://github.com/apache/spark/commit/7350f07597fa7072751158184b113f27220e9c0f). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10723#discussion_r51086558
--- Diff:
sql/catalyst/src/main/antlr3/org/apache/spark/sql/catalyst/parser/SparkSqlLexer.g
---
@@ -465,7 +467,7 @@ Identifier
fragment
QuotedIdentifier
:
-'`' ( '``' | ~('`') )* '`' { setText(getText().substring(1,
getText().length() -1 ).replaceAll("``", "`")); }
+'`' ( '``' | ~('`') )* '`' { setText(getText().replaceAll("``",
"`")); }
--- End diff --
Sorry I mispasted the query (github also uses backticks for escaping):
sql("select * from (select 1 as ```weird``name`) as a")
We currently also support backticks in the name. The regex used in
```CatalystQl.cleanIdentifiers``` is quite limited and will not strip the
inital and final backticks in this case. So were are expecting this:
`weird`name
And getting this:
``weird`name`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10723#discussion_r51019139
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -42,6 +45,95 @@ private[sql] class SparkQl(conf: ParserConf =
SimpleParserConf()) extends Cataly
getClauses(Seq("TOK_QUERY", "FORMATTED", "EXTENDED"),
explainArgs)
ExplainCommand(nodeToPlan(query), extended = extended.isDefined)
+ case Token("TOK_REFRESHTABLE", nameParts :: Nil) =>
+val tableIdent = extractTableIdent(nameParts)
+RefreshTable(tableIdent)
+
+ case Token("TOK_CREATETABLEUSING", createTableArgs) =>
+val Seq(
+ temp,
+ allowExisting,
+ Some(tabName),
+ tableCols,
+ Some(Token("TOK_TABLEPROVIDER", providerNameParts)),
+ tableOpts,
+ tableAs) = getClauses(Seq(
+ "TEMPORARY",
+ "TOK_IFNOTEXISTS",
+ "TOK_TABNAME", "TOK_TABCOLLIST",
+ "TOK_TABLEPROVIDER",
+ "TOK_TABLEOPTIONS",
+ "TOK_QUERY"), createTableArgs)
+
+val tableIdent: TableIdentifier = tabName match {
+ case Token("TOK_TABNAME", Token(dbName, Nil) :: Token(tableName,
Nil) :: Nil) =>
+new TableIdentifier(cleanIdentifier(tableName),
Some(cleanIdentifier(dbName)))
+ case Token("TOK_TABNAME", Token(tableName, Nil) :: Nil) =>
+TableIdentifier(cleanIdentifier(tableName))
+}
+
+val columns = tableCols.map {
+ case Token("TOK_TABCOLLIST", fields) =>
StructType(fields.map(nodeToStructField))
+}
+
+val provider = providerNameParts.map {
+ case Token(name, Nil) => name
+}.mkString(".")
+
+val options = tableOpts.map { opts =>
+ opts match {
+case Token("TOK_TABLEOPTIONS", options) =>
+ options.map {
+case Token("TOK_TABLEOPTION", keysAndValue) =>
+ val key = keysAndValue.init.map {
+case Token(k, Nil) => k
+ }.mkString(".")
+ val value = unquoteString(keysAndValue.last.text)
+ (key, unquoteString(value))
+ }.asInstanceOf[Seq[(String, String)]].toMap
--- End diff --
Why is this cast needed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10723#discussion_r51020600
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -42,6 +45,95 @@ private[sql] class SparkQl(conf: ParserConf =
SimpleParserConf()) extends Cataly
getClauses(Seq("TOK_QUERY", "FORMATTED", "EXTENDED"),
explainArgs)
ExplainCommand(nodeToPlan(query), extended = extended.isDefined)
+ case Token("TOK_REFRESHTABLE", nameParts :: Nil) =>
+val tableIdent = extractTableIdent(nameParts)
+RefreshTable(tableIdent)
+
+ case Token("TOK_CREATETABLEUSING", createTableArgs) =>
+val Seq(
+ temp,
+ allowExisting,
+ Some(tabName),
+ tableCols,
+ Some(Token("TOK_TABLEPROVIDER", providerNameParts)),
+ tableOpts,
+ tableAs) = getClauses(Seq(
+ "TEMPORARY",
+ "TOK_IFNOTEXISTS",
+ "TOK_TABNAME", "TOK_TABCOLLIST",
+ "TOK_TABLEPROVIDER",
+ "TOK_TABLEOPTIONS",
+ "TOK_QUERY"), createTableArgs)
+
+val tableIdent: TableIdentifier = tabName match {
+ case Token("TOK_TABNAME", Token(dbName, Nil) :: Token(tableName,
Nil) :: Nil) =>
+new TableIdentifier(cleanIdentifier(tableName),
Some(cleanIdentifier(dbName)))
+ case Token("TOK_TABNAME", Token(tableName, Nil) :: Nil) =>
+TableIdentifier(cleanIdentifier(tableName))
+}
+
+val columns = tableCols.map {
+ case Token("TOK_TABCOLLIST", fields) =>
StructType(fields.map(nodeToStructField))
+}
+
+val provider = providerNameParts.map {
+ case Token(name, Nil) => name
+}.mkString(".")
+
+val options = tableOpts.map { opts =>
+ opts match {
+case Token("TOK_TABLEOPTIONS", options) =>
+ options.map {
+case Token("TOK_TABLEOPTION", keysAndValue) =>
+ val key = keysAndValue.init.map {
+case Token(k, Nil) => k
+ }.mkString(".")
+ val value = unquoteString(keysAndValue.last.text)
+ (key, unquoteString(value))
--- End diff --
Unquoting twice?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10723#discussion_r51018980
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -42,6 +45,95 @@ private[sql] class SparkQl(conf: ParserConf =
SimpleParserConf()) extends Cataly
getClauses(Seq("TOK_QUERY", "FORMATTED", "EXTENDED"),
explainArgs)
ExplainCommand(nodeToPlan(query), extended = extended.isDefined)
+ case Token("TOK_REFRESHTABLE", nameParts :: Nil) =>
+val tableIdent = extractTableIdent(nameParts)
+RefreshTable(tableIdent)
+
+ case Token("TOK_CREATETABLEUSING", createTableArgs) =>
+val Seq(
+ temp,
+ allowExisting,
+ Some(tabName),
+ tableCols,
+ Some(Token("TOK_TABLEPROVIDER", providerNameParts)),
+ tableOpts,
+ tableAs) = getClauses(Seq(
+ "TEMPORARY",
+ "TOK_IFNOTEXISTS",
+ "TOK_TABNAME", "TOK_TABCOLLIST",
+ "TOK_TABLEPROVIDER",
+ "TOK_TABLEOPTIONS",
+ "TOK_QUERY"), createTableArgs)
+
+val tableIdent: TableIdentifier = tabName match {
+ case Token("TOK_TABNAME", Token(dbName, Nil) :: Token(tableName,
Nil) :: Nil) =>
+new TableIdentifier(cleanIdentifier(tableName),
Some(cleanIdentifier(dbName)))
+ case Token("TOK_TABNAME", Token(tableName, Nil) :: Nil) =>
+TableIdentifier(cleanIdentifier(tableName))
+}
+
+val columns = tableCols.map {
+ case Token("TOK_TABCOLLIST", fields) =>
StructType(fields.map(nodeToStructField))
+}
+
+val provider = providerNameParts.map {
+ case Token(name, Nil) => name
+}.mkString(".")
+
+val options = tableOpts.map { opts =>
+ opts match {
+case Token("TOK_TABLEOPTIONS", options) =>
+ options.map {
+case Token("TOK_TABLEOPTION", keysAndValue) =>
--- End diff --
Nevermind. The name can have multiple parts. We could try to solve this in
the lexer (make it one name again).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10723#discussion_r51020936
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -42,6 +45,95 @@ private[sql] class SparkQl(conf: ParserConf =
SimpleParserConf()) extends Cataly
getClauses(Seq("TOK_QUERY", "FORMATTED", "EXTENDED"),
explainArgs)
ExplainCommand(nodeToPlan(query), extended = extended.isDefined)
+ case Token("TOK_REFRESHTABLE", nameParts :: Nil) =>
+val tableIdent = extractTableIdent(nameParts)
+RefreshTable(tableIdent)
+
+ case Token("TOK_CREATETABLEUSING", createTableArgs) =>
+val Seq(
+ temp,
+ allowExisting,
+ Some(tabName),
+ tableCols,
+ Some(Token("TOK_TABLEPROVIDER", providerNameParts)),
+ tableOpts,
+ tableAs) = getClauses(Seq(
+ "TEMPORARY",
+ "TOK_IFNOTEXISTS",
+ "TOK_TABNAME", "TOK_TABCOLLIST",
+ "TOK_TABLEPROVIDER",
+ "TOK_TABLEOPTIONS",
+ "TOK_QUERY"), createTableArgs)
+
+val tableIdent: TableIdentifier = tabName match {
+ case Token("TOK_TABNAME", Token(dbName, Nil) :: Token(tableName,
Nil) :: Nil) =>
+new TableIdentifier(cleanIdentifier(tableName),
Some(cleanIdentifier(dbName)))
+ case Token("TOK_TABNAME", Token(tableName, Nil) :: Nil) =>
+TableIdentifier(cleanIdentifier(tableName))
+}
+
+val columns = tableCols.map {
+ case Token("TOK_TABCOLLIST", fields) =>
StructType(fields.map(nodeToStructField))
+}
+
+val provider = providerNameParts.map {
+ case Token(name, Nil) => name
+}.mkString(".")
+
+val options = tableOpts.map { opts =>
--- End diff --
Nit: You could also turn the option into a sequence, flatMap over it, and
create the Map as a result:
val options = tableOpts.toSeq.flatMap { opts =>
val Token("TOK_TABLEOPTIONS", options) = opts
options.map {
case Token("TOK_TABLEOPTION", keysAndValue) =>
val key = keysAndValue.init.map.(_.text).mkString(".")
val value = unquoteString(keysAndValue.last.text)
key -> value
}
}.toMap
(note: code is not tested)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10723#discussion_r51022777
--- Diff:
sql/catalyst/src/main/antlr3/org/apache/spark/sql/catalyst/parser/SparkSqlLexer.g
---
@@ -465,7 +467,7 @@ Identifier
fragment
QuotedIdentifier
:
-'`' ( '``' | ~('`') )* '`' { setText(getText().substring(1,
getText().length() -1 ).replaceAll("``", "`")); }
+'`' ( '``' | ~('`') )* '`' { setText(getText().replaceAll("``",
"`")); }
--- End diff --
So we want backticks at the beginning and the end of the identifier? I
thought the first and the last backtick are a means of identifying a quoted
identifier, and not a part of the name. Do these backticks remain a part of the
name throughout the code?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10723#discussion_r51024924
--- Diff:
sql/catalyst/src/main/antlr3/org/apache/spark/sql/catalyst/parser/SparkSqlLexer.g
---
@@ -465,7 +467,7 @@ Identifier
fragment
QuotedIdentifier
:
-'`' ( '``' | ~('`') )* '`' { setText(getText().substring(1,
getText().length() -1 ).replaceAll("``", "`")); }
+'`' ( '``' | ~('`') )* '`' { setText(getText().replaceAll("``",
"`")); }
--- End diff --
You are using the CatalystQl ```cleanIdentifier``` function to get rid of
the remaining backticks. What happens if we do this:
sql("select * from (select 1 as ```weird`name`) as a")
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-175781673 @viirya I have done another round. Before giving my final OK: I would like to know why you want change the treatment of quoted identifiers? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10723#discussion_r51017052
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -42,6 +45,95 @@ private[sql] class SparkQl(conf: ParserConf =
SimpleParserConf()) extends Cataly
getClauses(Seq("TOK_QUERY", "FORMATTED", "EXTENDED"),
explainArgs)
ExplainCommand(nodeToPlan(query), extended = extended.isDefined)
+ case Token("TOK_REFRESHTABLE", nameParts :: Nil) =>
+val tableIdent = extractTableIdent(nameParts)
+RefreshTable(tableIdent)
+
+ case Token("TOK_CREATETABLEUSING", createTableArgs) =>
+val Seq(
+ temp,
+ allowExisting,
+ Some(tabName),
+ tableCols,
+ Some(Token("TOK_TABLEPROVIDER", providerNameParts)),
+ tableOpts,
+ tableAs) = getClauses(Seq(
+ "TEMPORARY",
+ "TOK_IFNOTEXISTS",
+ "TOK_TABNAME", "TOK_TABCOLLIST",
+ "TOK_TABLEPROVIDER",
+ "TOK_TABLEOPTIONS",
+ "TOK_QUERY"), createTableArgs)
+
+val tableIdent: TableIdentifier = tabName match {
--- End diff --
```extractTableIdent```?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10723#discussion_r51017780
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -42,6 +45,95 @@ private[sql] class SparkQl(conf: ParserConf =
SimpleParserConf()) extends Cataly
getClauses(Seq("TOK_QUERY", "FORMATTED", "EXTENDED"),
explainArgs)
ExplainCommand(nodeToPlan(query), extended = extended.isDefined)
+ case Token("TOK_REFRESHTABLE", nameParts :: Nil) =>
+val tableIdent = extractTableIdent(nameParts)
+RefreshTable(tableIdent)
+
+ case Token("TOK_CREATETABLEUSING", createTableArgs) =>
+val Seq(
+ temp,
+ allowExisting,
+ Some(tabName),
+ tableCols,
+ Some(Token("TOK_TABLEPROVIDER", providerNameParts)),
+ tableOpts,
+ tableAs) = getClauses(Seq(
+ "TEMPORARY",
+ "TOK_IFNOTEXISTS",
+ "TOK_TABNAME", "TOK_TABCOLLIST",
+ "TOK_TABLEPROVIDER",
+ "TOK_TABLEOPTIONS",
+ "TOK_QUERY"), createTableArgs)
+
+val tableIdent: TableIdentifier = tabName match {
+ case Token("TOK_TABNAME", Token(dbName, Nil) :: Token(tableName,
Nil) :: Nil) =>
+new TableIdentifier(cleanIdentifier(tableName),
Some(cleanIdentifier(dbName)))
+ case Token("TOK_TABNAME", Token(tableName, Nil) :: Nil) =>
+TableIdentifier(cleanIdentifier(tableName))
+}
+
+val columns = tableCols.map {
+ case Token("TOK_TABCOLLIST", fields) =>
StructType(fields.map(nodeToStructField))
+}
+
+val provider = providerNameParts.map {
+ case Token(name, Nil) => name
+}.mkString(".")
+
+val options = tableOpts.map { opts =>
+ opts match {
+case Token("TOK_TABLEOPTIONS", options) =>
+ options.map {
+case Token("TOK_TABLEOPTION", keysAndValue) =>
--- End diff --
Do we actually need a ```TOK_TABLEOPTION```? We know that a
```TOK_TABLEOPTIONS``` contains options. It'll save an intermediate node.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10723#discussion_r51018824
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -42,6 +45,95 @@ private[sql] class SparkQl(conf: ParserConf =
SimpleParserConf()) extends Cataly
getClauses(Seq("TOK_QUERY", "FORMATTED", "EXTENDED"),
explainArgs)
ExplainCommand(nodeToPlan(query), extended = extended.isDefined)
+ case Token("TOK_REFRESHTABLE", nameParts :: Nil) =>
+val tableIdent = extractTableIdent(nameParts)
+RefreshTable(tableIdent)
+
+ case Token("TOK_CREATETABLEUSING", createTableArgs) =>
+val Seq(
+ temp,
+ allowExisting,
+ Some(tabName),
+ tableCols,
+ Some(Token("TOK_TABLEPROVIDER", providerNameParts)),
+ tableOpts,
+ tableAs) = getClauses(Seq(
+ "TEMPORARY",
+ "TOK_IFNOTEXISTS",
+ "TOK_TABNAME", "TOK_TABCOLLIST",
+ "TOK_TABLEPROVIDER",
+ "TOK_TABLEOPTIONS",
+ "TOK_QUERY"), createTableArgs)
+
+val tableIdent: TableIdentifier = tabName match {
+ case Token("TOK_TABNAME", Token(dbName, Nil) :: Token(tableName,
Nil) :: Nil) =>
+new TableIdentifier(cleanIdentifier(tableName),
Some(cleanIdentifier(dbName)))
+ case Token("TOK_TABNAME", Token(tableName, Nil) :: Nil) =>
+TableIdentifier(cleanIdentifier(tableName))
+}
+
+val columns = tableCols.map {
+ case Token("TOK_TABCOLLIST", fields) =>
StructType(fields.map(nodeToStructField))
+}
+
+val provider = providerNameParts.map {
+ case Token(name, Nil) => name
+}.mkString(".")
+
+val options = tableOpts.map { opts =>
+ opts match {
+case Token("TOK_TABLEOPTIONS", options) =>
+ options.map {
+case Token("TOK_TABLEOPTION", keysAndValue) =>
+ val key = keysAndValue.init.map {
+case Token(k, Nil) => k
--- End diff --
```keysAndValue.init.map.(_.text).mkString(".")``` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-174916359 @hvanhovell I think I addressed all your comments. Please see if it is good for you now. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-174522006 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49990/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-174522004 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-174521748 **[Test build #49990 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49990/consoleFull)** for PR 10723 at commit [`1df2b80`](https://github.com/apache/spark/commit/1df2b80a1a0a49783f735488f662f26336a0ca52). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-174519749 **[Test build #49992 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49992/consoleFull)** for PR 10723 at commit [`9ff32e0`](https://github.com/apache/spark/commit/9ff32e02932734e9d92aebeb18ec573f9957). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-174564309 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49992/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-174563497 **[Test build #49992 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49992/consoleFull)** for PR 10723 at commit [`9ff32e0`](https://github.com/apache/spark/commit/9ff32e02932734e9d92aebeb18ec573f9957). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-174564304 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/10723#discussion_r50662018
--- Diff:
sql/catalyst/src/main/antlr3/org/apache/spark/sql/catalyst/parser/SparkSqlLexer.g
---
@@ -465,7 +467,7 @@ Identifier
fragment
QuotedIdentifier
:
-'`' ( '``' | ~('`') )* '`' { setText(getText().substring(1,
getText().length() -1 ).replaceAll("``", "`")); }
+'`' ( '``' | ~('`') )* '`' { setText(getText().replaceAll("``",
"`")); }
--- End diff --
Just don't strip the first and last backquotes as I remove the calling of
`substring`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-174439578 **[Test build #49986 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49986/consoleFull)** for PR 10723 at commit [`1df2b80`](https://github.com/apache/spark/commit/1df2b80a1a0a49783f735488f662f26336a0ca52). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/10723#discussion_r50665410 --- Diff: sql/catalyst/src/main/antlr3/org/apache/spark/sql/catalyst/parser/ExpressionParser.g --- @@ -518,6 +527,10 @@ principalIdentifier | QuotedIdentifier ; +looseNonReserved +: nonReserved | KW_FROM | KW_TO +; + --- End diff -- Thanks for reminding. I've added it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-174469791 **[Test build #49986 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49986/consoleFull)** for PR 10723 at commit [`1df2b80`](https://github.com/apache/spark/commit/1df2b80a1a0a49783f735488f662f26336a0ca52). * This patch **fails PySpark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-174469956 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49986/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10723#discussion_r50680071
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -42,6 +45,95 @@ private[sql] class SparkQl(conf: ParserConf =
SimpleParserConf()) extends Cataly
getClauses(Seq("TOK_QUERY", "FORMATTED", "EXTENDED"),
explainArgs)
ExplainCommand(nodeToPlan(query), extended = extended.isDefined)
+ case Token("TOK_REFRESHTABLE", nameParts :: Nil) =>
+val tableIdent = extractTableIdent(nameParts)
+RefreshTable(tableIdent)
+
+ case Token("TOK_CREATETABLEUSING", createTableArgs) =>
+val Seq(
+ temp,
+ allowExisting,
+ Some(tabName),
+ tableCols,
+ Some(Token("TOK_TABLEPROVIDER", providerNameParts)),
+ tableOpts,
+ tableAs) = getClauses(Seq(
+ "TEMPORARY",
+ "TOK_IFNOTEXISTS",
+ "TOK_TABNAME", "TOK_TABCOLLIST",
+ "TOK_TABLEPROVIDER",
+ "TOK_TABLEOPTIONS",
+ "TOK_QUERY"), createTableArgs)
+
+val tableIdent: TableIdentifier = tabName match {
+ case Token("TOK_TABNAME", Token(dbName, _) :: Token(tableName,
_) :: Nil) =>
--- End diff --
As soon as you use an underscore in a pattern match, for example:
```Token(dbName, _)```, you are using a wildcard in the second position.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-174469955 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-174483849 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/10723#discussion_r50684916
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -42,6 +45,95 @@ private[sql] class SparkQl(conf: ParserConf =
SimpleParserConf()) extends Cataly
getClauses(Seq("TOK_QUERY", "FORMATTED", "EXTENDED"),
explainArgs)
ExplainCommand(nodeToPlan(query), extended = extended.isDefined)
+ case Token("TOK_REFRESHTABLE", nameParts :: Nil) =>
+val tableIdent = extractTableIdent(nameParts)
+RefreshTable(tableIdent)
+
+ case Token("TOK_CREATETABLEUSING", createTableArgs) =>
+val Seq(
+ temp,
+ allowExisting,
+ Some(tabName),
+ tableCols,
+ Some(Token("TOK_TABLEPROVIDER", providerNameParts)),
+ tableOpts,
+ tableAs) = getClauses(Seq(
+ "TEMPORARY",
+ "TOK_IFNOTEXISTS",
+ "TOK_TABNAME", "TOK_TABCOLLIST",
+ "TOK_TABLEPROVIDER",
+ "TOK_TABLEOPTIONS",
+ "TOK_QUERY"), createTableArgs)
+
+val tableIdent: TableIdentifier = tabName match {
+ case Token("TOK_TABNAME", Token(dbName, _) :: Token(tableName,
_) :: Nil) =>
--- End diff --
ah, I see, just not sure where you are pointing to. I was wondering I don't
have case _ branch. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-174487205 **[Test build #49990 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49990/consoleFull)** for PR 10723 at commit [`1df2b80`](https://github.com/apache/spark/commit/1df2b80a1a0a49783f735488f662f26336a0ca52). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/10723#discussion_r50791979
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -52,26 +57,30 @@ private[sql] class SparkQl(conf: ParserConf =
SimpleParserConf()) extends Cataly
nodeToDescribeFallback(node)
} else {
tableType match {
-case Token("TOK_TABTYPE", Token("TOK_TABNAME", nameParts ::
Nil) :: Nil) =>
+case Token("TOK_TABTYPE", Token("TOK_TABNAME", nameParts) ::
Nil) =>
--- End diff --
Actually we have test for describe table command in HiveQuerySuite. Do we
need another test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/10723#discussion_r50661745
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -42,6 +45,95 @@ private[sql] class SparkQl(conf: ParserConf =
SimpleParserConf()) extends Cataly
getClauses(Seq("TOK_QUERY", "FORMATTED", "EXTENDED"),
explainArgs)
ExplainCommand(nodeToPlan(query), extended = extended.isDefined)
+ case Token("TOK_REFRESHTABLE", nameParts :: Nil) =>
+val tableIdent = extractTableIdent(nameParts)
+RefreshTable(tableIdent)
+
+ case Token("TOK_CREATETABLEUSING", createTableArgs) =>
+val Seq(
+ temp,
+ allowExisting,
+ Some(tabName),
+ tableCols,
+ Some(Token("TOK_TABLEPROVIDER", providerNameParts)),
+ tableOpts,
+ tableAs) = getClauses(Seq(
+ "TEMPORARY",
+ "TOK_IFNOTEXISTS",
+ "TOK_TABNAME", "TOK_TABCOLLIST",
+ "TOK_TABLEPROVIDER",
+ "TOK_TABLEOPTIONS",
+ "TOK_QUERY"), createTableArgs)
+
+val tableIdent: TableIdentifier = tabName match {
+ case Token("TOK_TABNAME", Token(dbName, _) :: Token(tableName,
_) :: Nil) =>
+new TableIdentifier(cleanIdentifier(tableName),
Some(cleanIdentifier(dbName)))
+ case Token("TOK_TABNAME", Token(tableName, _) :: Nil) =>
+TableIdentifier(cleanIdentifier(tableName))
+}
+
+val columns = tableCols.map {
+ case Token("TOK_TABCOLLIST", fields) =>
StructType(fields.map(nodeToStructField))
+}
+
+val provider = providerNameParts.map {
+ case Token(name, _) => name
+}.mkString(".")
+
+val options = tableOpts.map { opts =>
+ opts match {
+case Token("TOK_TABLEOPTIONS", options) =>
+ options.map {
+case Token("TOK_TABLEOPTION", keysAndValue) =>
+ val key = keysAndValue.init.map {
+case Token(k, _) => k
+ }.mkString(".")
+ val value = unquoteString(keysAndValue.last.text)
+ (key, unquoteString(value))
+ }.asInstanceOf[Seq[(String, String)]].toMap
+ }
+}.getOrElse(Map.empty[String, String])
+
+val asClause = tableAs.map(nodeToPlan(_))
+
+if (temp.isDefined && allowExisting.isDefined) {
+ throw new DDLException(
--- End diff --
Actually here the thrown exception will be caught in `CatalystQl` which
will then throw an `AnalysisException`. But I agreed that we can remove
`DDLException`. Only `DDLParser` uses it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/10723#discussion_r50661920
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -42,6 +45,95 @@ private[sql] class SparkQl(conf: ParserConf =
SimpleParserConf()) extends Cataly
getClauses(Seq("TOK_QUERY", "FORMATTED", "EXTENDED"),
explainArgs)
ExplainCommand(nodeToPlan(query), extended = extended.isDefined)
+ case Token("TOK_REFRESHTABLE", nameParts :: Nil) =>
+val tableIdent = extractTableIdent(nameParts)
+RefreshTable(tableIdent)
+
+ case Token("TOK_CREATETABLEUSING", createTableArgs) =>
+val Seq(
+ temp,
+ allowExisting,
+ Some(tabName),
+ tableCols,
+ Some(Token("TOK_TABLEPROVIDER", providerNameParts)),
+ tableOpts,
+ tableAs) = getClauses(Seq(
+ "TEMPORARY",
+ "TOK_IFNOTEXISTS",
+ "TOK_TABNAME", "TOK_TABCOLLIST",
+ "TOK_TABLEPROVIDER",
+ "TOK_TABLEOPTIONS",
+ "TOK_QUERY"), createTableArgs)
+
+val tableIdent: TableIdentifier = tabName match {
+ case Token("TOK_TABNAME", Token(dbName, _) :: Token(tableName,
_) :: Nil) =>
--- End diff --
I don't get understood. I think I don't use wildcards in pattern matches
here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10723#discussion_r50619674
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -42,6 +45,95 @@ private[sql] class SparkQl(conf: ParserConf =
SimpleParserConf()) extends Cataly
getClauses(Seq("TOK_QUERY", "FORMATTED", "EXTENDED"),
explainArgs)
ExplainCommand(nodeToPlan(query), extended = extended.isDefined)
+ case Token("TOK_REFRESHTABLE", nameParts :: Nil) =>
+val tableIdent = extractTableIdent(nameParts)
+RefreshTable(tableIdent)
+
+ case Token("TOK_CREATETABLEUSING", createTableArgs) =>
+val Seq(
+ temp,
+ allowExisting,
+ Some(tabName),
+ tableCols,
+ Some(Token("TOK_TABLEPROVIDER", providerNameParts)),
+ tableOpts,
+ tableAs) = getClauses(Seq(
+ "TEMPORARY",
+ "TOK_IFNOTEXISTS",
+ "TOK_TABNAME", "TOK_TABCOLLIST",
+ "TOK_TABLEPROVIDER",
+ "TOK_TABLEOPTIONS",
+ "TOK_QUERY"), createTableArgs)
+
+val tableIdent: TableIdentifier = tabName match {
+ case Token("TOK_TABNAME", Token(dbName, _) :: Token(tableName,
_) :: Nil) =>
+new TableIdentifier(cleanIdentifier(tableName),
Some(cleanIdentifier(dbName)))
+ case Token("TOK_TABNAME", Token(tableName, _) :: Nil) =>
+TableIdentifier(cleanIdentifier(tableName))
+}
+
+val columns = tableCols.map {
+ case Token("TOK_TABCOLLIST", fields) =>
StructType(fields.map(nodeToStructField))
+}
+
+val provider = providerNameParts.map {
+ case Token(name, _) => name
+}.mkString(".")
+
+val options = tableOpts.map { opts =>
+ opts match {
+case Token("TOK_TABLEOPTIONS", options) =>
+ options.map {
+case Token("TOK_TABLEOPTION", keysAndValue) =>
+ val key = keysAndValue.init.map {
+case Token(k, _) => k
+ }.mkString(".")
+ val value = unquoteString(keysAndValue.last.text)
+ (key, unquoteString(value))
+ }.asInstanceOf[Seq[(String, String)]].toMap
+ }
+}.getOrElse(Map.empty[String, String])
+
+val asClause = tableAs.map(nodeToPlan(_))
+
+if (temp.isDefined && allowExisting.isDefined) {
+ throw new DDLException(
--- End diff --
Do we still need a DDL exception? Why not throw an analysis exception?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10723#discussion_r50619708
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -52,26 +57,30 @@ private[sql] class SparkQl(conf: ParserConf =
SimpleParserConf()) extends Cataly
nodeToDescribeFallback(node)
} else {
tableType match {
-case Token("TOK_TABTYPE", Token("TOK_TABNAME", nameParts ::
Nil) :: Nil) =>
+case Token("TOK_TABTYPE", Token("TOK_TABNAME", nameParts) ::
Nil) =>
--- End diff --
Could we add a test for this? The Hive test suite apparently misses this
one. I could also address in a different PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10723#discussion_r50619696
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -42,6 +45,95 @@ private[sql] class SparkQl(conf: ParserConf =
SimpleParserConf()) extends Cataly
getClauses(Seq("TOK_QUERY", "FORMATTED", "EXTENDED"),
explainArgs)
ExplainCommand(nodeToPlan(query), extended = extended.isDefined)
+ case Token("TOK_REFRESHTABLE", nameParts :: Nil) =>
+val tableIdent = extractTableIdent(nameParts)
+RefreshTable(tableIdent)
+
+ case Token("TOK_CREATETABLEUSING", createTableArgs) =>
+val Seq(
+ temp,
+ allowExisting,
+ Some(tabName),
+ tableCols,
+ Some(Token("TOK_TABLEPROVIDER", providerNameParts)),
+ tableOpts,
+ tableAs) = getClauses(Seq(
+ "TEMPORARY",
+ "TOK_IFNOTEXISTS",
+ "TOK_TABNAME", "TOK_TABCOLLIST",
+ "TOK_TABLEPROVIDER",
+ "TOK_TABLEOPTIONS",
+ "TOK_QUERY"), createTableArgs)
+
+val tableIdent: TableIdentifier = tabName match {
+ case Token("TOK_TABNAME", Token(dbName, _) :: Token(tableName,
_) :: Nil) =>
--- End diff --
I am personally not big on using wildcards in pattern matches. This
prevents us from catching a grammar problem early. Since most of the wildcards
are actually empty lists, why not match these?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/10723#discussion_r50619659 --- Diff: sql/catalyst/src/main/antlr3/org/apache/spark/sql/catalyst/parser/ExpressionParser.g --- @@ -518,6 +527,10 @@ principalIdentifier | QuotedIdentifier ; +looseNonReserved +: nonReserved | KW_FROM | KW_TO +; + --- End diff -- Could add your initial line commentaar as a comment in the code? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10723#discussion_r50619663
--- Diff:
sql/catalyst/src/main/antlr3/org/apache/spark/sql/catalyst/parser/SparkSqlLexer.g
---
@@ -465,7 +467,7 @@ Identifier
fragment
QuotedIdentifier
:
-'`' ( '``' | ~('`') )* '`' { setText(getText().substring(1,
getText().length() -1 ).replaceAll("``", "`")); }
+'`' ( '``' | ~('`') )* '`' { setText(getText().replaceAll("``",
"`")); }
--- End diff --
So we are nog stripping quotes in the middle of strings anymore?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-174183437 @viirya I did a pass. I have left a few comment for you to address. Overall this looks pretty good! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-173840905 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-173876983 **[Test build #49916 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49916/consoleFull)** for PR 10723 at commit [`cbd3173`](https://github.com/apache/spark/commit/cbd3173fda11e7e7dc216519779a0ece08df8cc7). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-173877197 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-173877198 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49916/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-173877661 @hvanhovell the tests are passed. Can you help review this? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-173839876 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49905/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-173839873 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-173839756 **[Test build #49905 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49905/consoleFull)** for PR 10723 at commit [`cbd3173`](https://github.com/apache/spark/commit/cbd3173fda11e7e7dc216519779a0ece08df8cc7). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-173844321 **[Test build #49916 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49916/consoleFull)** for PR 10723 at commit [`cbd3173`](https://github.com/apache/spark/commit/cbd3173fda11e7e7dc216519779a0ece08df8cc7). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-173843613 Failure in InputStreamsSuite. I think it should be not related. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-173538635 **[Test build #49872 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49872/consoleFull)** for PR 10723 at commit [`9922ccc`](https://github.com/apache/spark/commit/9922cccde7ecdfd5e850552b78dd5742a0a4a6a3). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-173538837 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49872/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-173538836 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-173525273 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49868/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-173525271 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-173494001 **[Test build #49868 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49868/consoleFull)** for PR 10723 at commit [`3e5a229`](https://github.com/apache/spark/commit/3e5a22948558e79777568b5e2f7d14f93705cf3d). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-173507314 **[Test build #49872 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49872/consoleFull)** for PR 10723 at commit [`9922ccc`](https://github.com/apache/spark/commit/9922cccde7ecdfd5e850552b78dd5742a0a4a6a3). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
