[GitHub] spark pull request: [SPARK-12692][BUILD]Enforce style checking abo...

2016-01-13 Thread rxin 
Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/10736#issuecomment-171218362
  
I've merged this.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12692][BUILD]Enforce style checking abo...

2016-01-13 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10736#issuecomment-171216790
  
**[Test build #49301 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49301/consoleFull)**
 for PR 10736 at commit 
[`44b3698`](https://github.com/apache/spark/commit/44b36981d553a7f56150d6b0a0caa88eca30e1c5).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12692][BUILD]Enforce style checking abo...

2016-01-13 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10736#issuecomment-171217004
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49301/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12692][BUILD]Enforce style checking abo...

2016-01-13 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10736#issuecomment-171217002
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12692][BUILD]Enforce style checking abo...

2016-01-13 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/10736


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12692][BUILD]Enforce style checking abo...

2016-01-13 Thread rxin 
Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/10736#issuecomment-171210122
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12692][BUILD]Enforce style checking abo...

2016-01-13 Thread sarutak 
Github user sarutak commented on the pull request:

https://github.com/apache/spark/pull/10736#issuecomment-171535903
  
Very sorry for that. I missed to run `sbt scalastyle` with `-Pkinesis-asl` 
on my local environment.
I wondered why the style checker passed in this PR and I found the reason.
I opened a PR to fix it (#10754).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12692][BUILD]Enforce style checking abo...

2016-01-13 Thread JoshRosen 
Github user JoshRosen commented on the pull request:

https://github.com/apache/spark/pull/10736#issuecomment-171374169
  
It looks like some style tests are now failing; can you investigate and 
revert if necessary?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12692][BUILD]Enforce style checking abo...

2016-01-12 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10736#issuecomment-171195115
  
**[Test build #49301 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49301/consoleFull)**
 for PR 10736 at commit 
[`44b3698`](https://github.com/apache/spark/commit/44b36981d553a7f56150d6b0a0caa88eca30e1c5).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12692][BUILD]Enforce style checking abo...

2016-01-12 Thread sarutak 
GitHub user sarutak opened a pull request:

https://github.com/apache/spark/pull/10736

[SPARK-12692][BUILD]Enforce style checking about white space before comma

We have removed all of white spaces before comma from code so let's enforce 
style checking.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sarutak/spark 
SPARK-12692-followup-enforce-checking

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/10736.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10736


commit 44b36981d553a7f56150d6b0a0caa88eca30e1c5
Author: Kousuke Saruta 
Date:   2016-01-13T06:44:10Z

Enforced style check about space before token




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org