[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[jayadevanmurali]

Github user jayadevanmurali commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-182760091
  
@hvanhovell Thanks for the quick fix, I think we can retest this PR now. 
What you think ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-182892635
  
@jayadevanmurali issueing `retest this please` should normally do the trick.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-182891796
  
ok to test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-183013147
  
**[Test build #51120 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51120/consoleFull)**
 for PR 11051 at commit 
[`f3c7bbb`](https://github.com/apache/spark/commit/f3c7bbbf2defcb42208ff9f25db07ffa60d4889f).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/11051


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-183012725
  
@shaneknapp thanks for your help! Any idea what caused this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[shaneknapp]

Github user shaneknapp commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-183017267
  
the GHPRB plugin is finicky, obtuse and opaque in it's operations.  i have
no idea why it decided to not trigger, and the logs don't show anything.
 sorry...  :(

On Thu, Feb 11, 2016 at 11:07 AM, Herman van Hovell <
notificati...@github.com> wrote:

> @shaneknapp  thanks for your help! Any
> idea what caused this?
>
> —
> Reply to this email directly or view it on GitHub
> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-183047747
  
Merging to master. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-183047397
  
@shaneknapp Thanks for checking... The GHPRB just works in mysterious 
ways...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-183013527
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51120/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-183013525
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[jayadevanmurali]

Github user jayadevanmurali commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-182884877
  
@hvanhovell  I think, you may comment "ok to test" for triggering the build 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-182863542
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-182920304
  
@jayadevanmurali Jenkins will be restarted in 30 mins. Lets try again after 
that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-182941789
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[jayadevanmurali]

Github user jayadevanmurali commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-182942391
  
Ok. I think something missing in our test request, lot test started now 
which all requested after our PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-182964532
  
ok to test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[jayadevanmurali]

Github user jayadevanmurali commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-182964460
  
Jenkins, test this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[shaneknapp]

Github user shaneknapp commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-182966961
  
jenkins test this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[shaneknapp]

Github user shaneknapp commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-182967337
  
im not totally sure...  jenkins is picking up other PRB builds.  i'll poke 
around the (horrific) jenkins logs and see if i can't find out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[shaneknapp]

Github user shaneknapp commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-182968845
  
it's building now:

https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51120/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-182965414
  
@shaneknapp any idea why Jenkins is not picking this up? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-182975000
  
**[Test build #51120 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51120/consoleFull)**
 for PR 11051 at commit 
[`f3c7bbb`](https://github.com/apache/spark/commit/f3c7bbbf2defcb42208ff9f25db07ffa60d4889f).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[jayadevanmurali]

Github user jayadevanmurali commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-182452861
  
@hvanhovell 
Why this much delay for test ? 
Anything required from my side ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[jayadevanmurali]

Github user jayadevanmurali commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-182461950
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-182537393
  
@jayadevanmurali I have no idea why builds aren't triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-182537603
  
ok to test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-182539247
  
**[Test build #2530 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2530/consoleFull)**
 for PR 11051 at commit 
[`f3c7bbb`](https://github.com/apache/spark/commit/f3c7bbbf2defcb42208ff9f25db07ffa60d4889f).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-182504688
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-182574814
  
**[Test build #2530 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2530/consoleFull)**
 for PR 11051 at commit 
[`f3c7bbb`](https://github.com/apache/spark/commit/f3c7bbbf2defcb42208ff9f25db07ffa60d4889f).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[jayadevanmurali]

Github user jayadevanmurali commented on a diff in the pull request:

https://github.com/apache/spark/pull/11051#discussion_r52527852
  
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala 
---
@@ -1291,4 +1291,16 @@ class DataFrameSuite extends QueryTest with 
SharedSQLContext {
   Seq(1 -> "a").toDF("i", "j").filter($"i".cast(StringType) === "1"),
   Row(1, "a"))
   }
+
+  test("SPARK-12982: Add table name validation in temp table 
registration") {
+val df = Seq("foo", "bar").map(Tuple1.apply).toDF("col")
+// invalid table name test as below
+intercept[AnalysisException](df.registerTempTable("t~"))
+// valid table name test as below
+df.registerTempTable("table1")
+// another invalid table name test as below
+intercept[AnalysisException](df.registerTempTable("#$@sum"))
+// another invalid table name test as below
+intercept[AnalysisException](df.registerTempTable("table!#"))
--- End diff --

Ok thanks for the info. Let me know if you need any.help from.me.







---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[jayadevanmurali]

Github user jayadevanmurali commented on a diff in the pull request:

https://github.com/apache/spark/pull/11051#discussion_r52526270
  
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala 
---
@@ -1291,4 +1291,16 @@ class DataFrameSuite extends QueryTest with 
SharedSQLContext {
   Seq(1 -> "a").toDF("i", "j").filter($"i".cast(StringType) === "1"),
   Row(1, "a"))
   }
+
+  test("SPARK-12982: Add table name validation in temp table 
registration") {
+val df = Seq("foo", "bar").map(Tuple1.apply).toDF("col")
+// invalid table name test as below
+intercept[AnalysisException](df.registerTempTable("t~"))
+// valid table name test as below
+df.registerTempTable("table1")
+// another invalid table name test as below
+intercept[AnalysisException](df.registerTempTable("#$@sum"))
+// another invalid table name test as below
+intercept[AnalysisException](df.registerTempTable("table!#"))
--- End diff --

Is this a new bug ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on a diff in the pull request:

https://github.com/apache/spark/pull/11051#discussion_r52526783
  
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala 
---
@@ -1291,4 +1291,16 @@ class DataFrameSuite extends QueryTest with 
SharedSQLContext {
   Seq(1 -> "a").toDF("i", "j").filter($"i".cast(StringType) === "1"),
   Row(1, "a"))
   }
+
+  test("SPARK-12982: Add table name validation in temp table 
registration") {
+val df = Seq("foo", "bar").map(Tuple1.apply).toDF("col")
+// invalid table name test as below
+intercept[AnalysisException](df.registerTempTable("t~"))
+// valid table name test as below
+df.registerTempTable("table1")
+// another invalid table name test as below
+intercept[AnalysisException](df.registerTempTable("#$@sum"))
+// another invalid table name test as below
+intercept[AnalysisException](df.registerTempTable("table!#"))
--- End diff --

It is a bug, but it was in code base already. The fix is trivial (I need to 
add a separate rule for parsing table identifiers - which checks for an EOF).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on a diff in the pull request:

https://github.com/apache/spark/pull/11051#discussion_r52526013
  
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala 
---
@@ -1291,4 +1291,16 @@ class DataFrameSuite extends QueryTest with 
SharedSQLContext {
   Seq(1 -> "a").toDF("i", "j").filter($"i".cast(StringType) === "1"),
   Row(1, "a"))
   }
+
+  test("SPARK-12982: Add table name validation in temp table 
registration") {
+val df = Seq("foo", "bar").map(Tuple1.apply).toDF("col")
+// invalid table name test as below
+intercept[AnalysisException](df.registerTempTable("t~"))
+// valid table name test as below
+df.registerTempTable("table1")
+// another invalid table name test as below
+intercept[AnalysisException](df.registerTempTable("#$@sum"))
+// another invalid table name test as below
+intercept[AnalysisException](df.registerTempTable("table!#"))
--- End diff --

H... this one should fail. Let me submit a PR for this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-181756011
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[jayadevanmurali]

Github user jayadevanmurali commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-181957359
  
@SparkQA 
Could you please retest the changes



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-182068512
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[jayadevanmurali]

Github user jayadevanmurali commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-181266259
  
Thanks @hvanhovell  for this info


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[jayadevanmurali]

Github user jayadevanmurali commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-181260259
  
@SparkQA 
Could you please do a test again

@hvanhovell @davies 
Incorporated review comments in test case. Could you please review the same


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on a diff in the pull request:

https://github.com/apache/spark/pull/11051#discussion_r52145256
  
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala 
---
@@ -1291,4 +1291,19 @@ class DataFrameSuite extends QueryTest with 
SharedSQLContext {
   Seq(1 -> "a").toDF("i", "j").filter($"i".cast(StringType) === "1"),
   Row(1, "a"))
   }
+
+  test("SPARK-12982: Add table name validation in temp table 
registration") {
+val rows = List(Row("foo"), Row("bar"))
--- End diff --

We can be a bit more concise (also see the comment in the previous PR): 
`val df = Seq(("one", "two")).toDF("a", "b")`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-181265540
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[jayadevanmurali]

Github user jayadevanmurali commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-181269499
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-181265973
  
@jayadevanmurali you can request a retest by making a `retest this please` 
comment. The Jenkins PR builder will pick this up. See 
https://github.com/jenkinsci/ghprb-plugin/blob/master/README.md for more 
information.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[jayadevanmurali]

Github user jayadevanmurali commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-181265819
  
@hvanhovell 
I will make that change now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-181296056
  
LGTM pending tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[jayadevanmurali]

Github user jayadevanmurali commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-181701118
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-181498387
  
**[Test build #2523 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2523/consoleFull)**
 for PR 11051 at commit 
[`d576496`](https://github.com/apache/spark/commit/d5764967977d67eeeccd38b4f516a20193b31c16).
 * This patch **fails Scala style tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-181497827
  
**[Test build #2523 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2523/consoleFull)**
 for PR 11051 at commit 
[`d576496`](https://github.com/apache/spark/commit/d5764967977d67eeeccd38b4f516a20193b31c16).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on a diff in the pull request:

https://github.com/apache/spark/pull/11051#discussion_r52235163
  
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala 
---
@@ -1291,4 +1291,16 @@ class DataFrameSuite extends QueryTest with 
SharedSQLContext {
   Seq(1 -> "a").toDF("i", "j").filter($"i".cast(StringType) === "1"),
   Row(1, "a"))
   }
+
+  test("SPARK-12982: Add table name validation in temp table 
registration") {
+val df = Seq("foo", "bar").map(Tuple1.apply).toDF("col")
+//invalid table name test as below
--- End diff --

You need to add a space between `//` and the actual comment in order to 
pass style checks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[davies]

Github user davies commented on a diff in the pull request:

https://github.com/apache/spark/pull/11051#discussion_r51963054
  
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala 
---
@@ -1291,4 +1291,14 @@ class DataFrameSuite extends QueryTest with 
SharedSQLContext {
   Seq(1 -> "a").toDF("i", "j").filter($"i".cast(StringType) === "1"),
   Row(1, "a"))
   }
+  
+  test("SPARK-12982: Add table name validation in temp table 
registration") {
--- End diff --

ping


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[jayadevanmurali]

Github user jayadevanmurali commented on the pull request:

https://github.com/apache/spark/pull/10983#issuecomment-179886072
  
Created new pr with latest code for this issue


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[jayadevanmurali]

Github user jayadevanmurali closed the pull request at:

https://github.com/apache/spark/pull/10983


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-179852568
  
ok to test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on the pull request:

https://github.com/apache/spark/pull/10983#issuecomment-179867521
  
@jayadevanmurali could you close this one?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[jayadevanmurali]

Github user jayadevanmurali commented on a diff in the pull request:

https://github.com/apache/spark/pull/11051#discussion_r51973903
  
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala 
---
@@ -1291,4 +1291,14 @@ class DataFrameSuite extends QueryTest with 
SharedSQLContext {
   Seq(1 -> "a").toDF("i", "j").filter($"i".cast(StringType) === "1"),
   Row(1, "a"))
   }
+  
+  test("SPARK-12982: Add table name validation in temp table 
registration") {
--- End diff --

@hvanhovell @davies 
Shall I include the changes for the above review comments now ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-180010563
  
**[Test build #2517 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2517/consoleFull)**
 for PR 11051 at commit 
[`4c25f2e`](https://github.com/apache/spark/commit/4c25f2ec2778201b244d79c3531f567341840614).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-179947272
  
**[Test build #2516 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2516/consoleFull)**
 for PR 11051 at commit 
[`3407fd7`](https://github.com/apache/spark/commit/3407fd785ae1c6c52607c96fb084617f2acd3e46).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-179948028
  
**[Test build #2516 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2516/consoleFull)**
 for PR 11051 at commit 
[`3407fd7`](https://github.com/apache/spark/commit/3407fd785ae1c6c52607c96fb084617f2acd3e46).
 * This patch **fails Scala style tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-179904231
  
@davies can you trigger a test?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-179968757
  
**[Test build #2517 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2517/consoleFull)**
 for PR 11051 at commit 
[`4c25f2e`](https://github.com/apache/spark/commit/4c25f2ec2778201b244d79c3531f567341840614).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[jayadevanmurali]

Github user jayadevanmurali commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-179964614
  
@SparkQA Could you please test again


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[jayadevanmurali]

Github user jayadevanmurali commented on the pull request:

https://github.com/apache/spark/pull/10983#issuecomment-179270485
  
@hvanhovell I have created a new PR for this issue with latest code. 
https://github.com/apache/spark/pull/11051. Could you please review the same.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-179270714
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[jayadevanmurali]

GitHub user jayadevanmurali opened a pull request:

https://github.com/apache/spark/pull/11051

[SPARK-12982][SQL] Add table name validation in temp table registration

Add the table name validation at the temp table creation

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jayadevanmurali/spark branch-0.2-SPARK-12982

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/11051.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #11051


commit 290b86ba76e8f6032824c95079748670c2257db0
Author: jayadevanmurali 
Date:   2016-01-31T02:28:52Z

Merge pull request #1 from apache/master

 Update from original

commit 7c7b503f88e0c74e324ef4b2da99f70d2e677a42
Author: jayadevanmurali 
Date:   2016-02-03T14:31:42Z

Update SQLContext.scala

 Add table name validation in temp table registration

commit 3407fd785ae1c6c52607c96fb084617f2acd3e46
Author: jayadevanmurali 
Date:   2016-02-03T14:33:46Z

Update DataFrameSuite.scala

Added test case for validating table name




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on a diff in the pull request:

https://github.com/apache/spark/pull/11051#discussion_r51757080
  
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala 
---
@@ -1291,4 +1291,14 @@ class DataFrameSuite extends QueryTest with 
SharedSQLContext {
   Seq(1 -> "a").toDF("i", "j").filter($"i".cast(StringType) === "1"),
   Row(1, "a"))
   }
+  
+  test("SPARK-12982: Add table name validation in temp table 
registration") {
+val rows = List(Row("foo"), Row("bar"))
+val schema = StructType(Seq(StructField("col", StringType)))
+val rdd = sparkContext.parallelize(rows)
+val df = sqlContext.createDataFrame(rdd, schema)
+assert(intercept[AnalysisException](df.registerTempTable("t~"))
+  .getMessage.contains("NoViableAltException"))
--- End diff --

Catching the analysis exception is fine for now. Lets not rely on an ANTLR 
specific error.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on a diff in the pull request:

https://github.com/apache/spark/pull/11051#discussion_r51756934
  
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala 
---
@@ -1291,4 +1291,14 @@ class DataFrameSuite extends QueryTest with 
SharedSQLContext {
   Seq(1 -> "a").toDF("i", "j").filter($"i".cast(StringType) === "1"),
   Row(1, "a"))
   }
+  
+  test("SPARK-12982: Add table name validation in temp table 
registration") {
+val rows = List(Row("foo"), Row("bar"))
--- End diff --

We can be a bit more concise: ```val df = Seq("foo", 
"bar").map(Tuple1.apply).toDF("col")```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on a diff in the pull request:

https://github.com/apache/spark/pull/11051#discussion_r51757168
  
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala 
---
@@ -1291,4 +1291,14 @@ class DataFrameSuite extends QueryTest with 
SharedSQLContext {
   Seq(1 -> "a").toDF("i", "j").filter($"i".cast(StringType) === "1"),
   Row(1, "a"))
   }
+  
+  test("SPARK-12982: Add table name validation in temp table 
registration") {
--- End diff --

Could you also add a few more different valid & invalid table names?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[jayadevanmurali]

Github user jayadevanmurali commented on a diff in the pull request:

https://github.com/apache/spark/pull/11051#discussion_r51762232
  
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala 
---
@@ -1291,4 +1291,14 @@ class DataFrameSuite extends QueryTest with 
SharedSQLContext {
   Seq(1 -> "a").toDF("i", "j").filter($"i".cast(StringType) === "1"),
   Row(1, "a"))
   }
+  
+  test("SPARK-12982: Add table name validation in temp table 
registration") {
+val rows = List(Row("foo"), Row("bar"))
+val schema = StructType(Seq(StructField("col", StringType)))
+val rdd = sparkContext.parallelize(rows)
+val df = sqlContext.createDataFrame(rdd, schema)
+assert(intercept[AnalysisException](df.registerTempTable("t~"))
+  .getMessage.contains("NoViableAltException"))
--- End diff --

@hvanhovell So we can simply intercept analysis exception instead of 
asserting NoViableAltException. Am I right ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on a diff in the pull request:

https://github.com/apache/spark/pull/11051#discussion_r51765538
  
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala 
---
@@ -1291,4 +1291,14 @@ class DataFrameSuite extends QueryTest with 
SharedSQLContext {
   Seq(1 -> "a").toDF("i", "j").filter($"i".cast(StringType) === "1"),
   Row(1, "a"))
   }
+  
+  test("SPARK-12982: Add table name validation in temp table 
registration") {
+val rows = List(Row("foo"), Row("bar"))
+val schema = StructType(Seq(StructField("col", StringType)))
+val rdd = sparkContext.parallelize(rows)
+val df = sqlContext.createDataFrame(rdd, schema)
+assert(intercept[AnalysisException](df.registerTempTable("t~"))
+  .getMessage.contains("NoViableAltException"))
--- End diff --

Jup


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[jayadevanmurali]

Github user jayadevanmurali commented on a diff in the pull request:

https://github.com/apache/spark/pull/11051#discussion_r51766868
  
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala 
---
@@ -1291,4 +1291,14 @@ class DataFrameSuite extends QueryTest with 
SharedSQLContext {
   Seq(1 -> "a").toDF("i", "j").filter($"i".cast(StringType) === "1"),
   Row(1, "a"))
   }
+  
+  test("SPARK-12982: Add table name validation in temp table 
registration") {
+val rows = List(Row("foo"), Row("bar"))
--- End diff --

@hvanhovell OK I will do the change


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[davies]

Github user davies commented on the pull request:

https://github.com/apache/spark/pull/11051#issuecomment-179394795
  
Jenkins, OK to test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[jayadevanmurali]

Github user jayadevanmurali commented on a diff in the pull request:

https://github.com/apache/spark/pull/11051#discussion_r51766777
  
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala 
---
@@ -1291,4 +1291,14 @@ class DataFrameSuite extends QueryTest with 
SharedSQLContext {
   Seq(1 -> "a").toDF("i", "j").filter($"i".cast(StringType) === "1"),
   Row(1, "a"))
   }
+  
+  test("SPARK-12982: Add table name validation in temp table 
registration") {
--- End diff --

yes @hvanhovell 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[jayadevanmurali]

Github user jayadevanmurali commented on the pull request:

https://github.com/apache/spark/pull/10983#issuecomment-177969053
  
@hvanhovell, Yea I tried to merge my branch 
(https://github.com/jayadevanmurali/spark/tree/branch-0.1-SPARK-SPARK-12982) 
with apache spark master. But I cant see any option to merge by "create pull 
request". That's why I suggest new PR option.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[jayadevanmurali]

Github user jayadevanmurali commented on the pull request:

https://github.com/apache/spark/pull/10983#issuecomment-177942271
  
@hvanhovell the current pull request is based on an outdated code. So I 
would like to create a new pull request on the latest code. Hope that is fine


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on the pull request:

https://github.com/apache/spark/pull/10983#issuecomment-177943412
  
Sure it is. Why not just merge the current master?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on the pull request:

https://github.com/apache/spark/pull/10983#issuecomment-177434727
  
@jayadevanmurali please don't close the PR, your fix is valid. We really 
shouldn't use table names like ```t~``` unless they are quoted using backticks. 
Please update your PR and add a test to ```SQLQuerySuite```.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[jayadevanmurali]

Github user jayadevanmurali commented on the pull request:

https://github.com/apache/spark/pull/10983#issuecomment-177447251
  
Thanks @hvanhovell, Working on test case


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on the pull request:

https://github.com/apache/spark/pull/10983#issuecomment-177448445
  
@jayadevanmurali could you add the test to ```DataFrameSuite``` instead of 
```SQLQuerySuite```? Sorry about the confusion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[jayadevanmurali]

Github user jayadevanmurali commented on the pull request:

https://github.com/apache/spark/pull/10983#issuecomment-177540750
  
@hvanhovell yes sure, no problem


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[jayadevanmurali]

Github user jayadevanmurali commented on the pull request:

https://github.com/apache/spark/pull/10983#issuecomment-177109715
  
@hvanhovell 
I was able to replicate this in spark 2.0.0.

Steps
ayadevan@Satellite-L640:~/spark$ ./bin/spark-shell 
Using Spark's default log4j profile: 
org/apache/spark/log4j-defaults.properties
Setting default log level to "WARN".
To adjust logging level use sc.setLogLevel(newLevel).
Welcome to
    __
 / __/__  ___ _/ /__
_\ \/ _ \/ _ `/ __/  '_/
   /___/ .__/\_,_/_/ /_/\_\   version 2.0.0-SNAPSHOT
  /_/

Using Scala version 2.10.5 (Java HotSpot(TM) 64-Bit Server VM, Java 
1.7.0_80)
Type in expressions to have them evaluated.
Type :help for more information.
16/01/30 14:19:21 WARN NativeCodeLoader: Unable to load native-hadoop 
library for your platform... using builtin-java classes where applicable
16/01/30 14:19:22 WARN Utils: Your hostname, Satellite-L640 resolves to a 
loopback address: 127.0.1.1; using 100.86.225.72 instead (on interface ppp0)
16/01/30 14:19:22 WARN Utils: Set SPARK_LOCAL_IP if you need to bind to 
another address
Spark context available as sc (master = local[*], app id = 
local-1454143767817).
SQL context available as sqlContext.

scala> import org.apache.spark.sql.types.{StringType, StructField, 
StructType}
import org.apache.spark.sql.types.{StringType, StructField, StructType}

scala> import org.apache.spark.sql.{DataFrame, Row, SQLContext}
import org.apache.spark.sql.{DataFrame, Row, SQLContext}

scala> import org.apache.spark.{SparkContext, SparkConf}
import org.apache.spark.{SparkContext, SparkConf}

scala>  val rows = List(Row("foo"), Row("bar"));
rows: List[org.apache.spark.sql.Row] = List([foo], [bar])

scala> val schema = StructType(Seq(StructField("col", StringType)));
schema: org.apache.spark.sql.types.StructType = 
StructType(StructField(col,StringType,true))

scala> val rdd = sc.parallelize(rows);
rdd: org.apache.spark.rdd.RDD[org.apache.spark.sql.Row] = 
ParallelCollectionRDD[0] at parallelize at :32

scala> val df = sqlContext.createDataFrame(rdd, schema)
df: org.apache.spark.sql.DataFrame = [col: string]

scala> df.registerTempTable("t~")

scala> df.sqlContext.dropTempTable("t~")
java.lang.RuntimeException: [1.2] failure: ``.'' expected but `~' found

t~
 ^
at scala.sys.package$.error(package.scala:27)
at 
org.apache.spark.sql.catalyst.SqlParser$.parseTableIdentifier(SqlParser.scala:58)
at org.apache.spark.sql.SQLContext.table(SQLContext.scala:836)
at org.apache.spark.sql.SQLContext.dropTempTable(SQLContext.scala:763)
at $iwC$$iwC$$iwC$$iwC$$iwC$$iwC$$iwC$$iwC.(:39)
at $iwC$$iwC$$iwC$$iwC$$iwC$$iwC$$iwC.(:44)
at $iwC$$iwC$$iwC$$iwC$$iwC$$iwC.(:46)
at $iwC$$iwC$$iwC$$iwC$$iwC.(:48)
at $iwC$$iwC$$iwC$$iwC.(:50)
at $iwC$$iwC$$iwC.(:52)
at $iwC$$iwC.(:54)
at $iwC.(:56)
at (:58)
at .(:62)
at .()
at .(:7)
at .()
at $print()
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
org.apache.spark.repl.SparkIMain$ReadEvalPrint.call(SparkIMain.scala:1045)
at 
org.apache.spark.repl.SparkIMain$Request.loadAndRun(SparkIMain.scala:1326)
at 
org.apache.spark.repl.SparkIMain.loadAndRunReq$1(SparkIMain.scala:821)
at org.apache.spark.repl.SparkIMain.interpret(SparkIMain.scala:852)
at org.apache.spark.repl.SparkIMain.interpret(SparkIMain.scala:800)
at 
org.apache.spark.repl.SparkILoop.reallyInterpret$1(SparkILoop.scala:857)
at 
org.apache.spark.repl.SparkILoop.interpretStartingWith(SparkILoop.scala:902)
at org.apache.spark.repl.SparkILoop.command(SparkILoop.scala:814)
at org.apache.spark.repl.SparkILoop.processLine$1(SparkILoop.scala:657)
at org.apache.spark.repl.SparkILoop.innerLoop$1(SparkILoop.scala:665)
at 
org.apache.spark.repl.SparkILoop.org$apache$spark$repl$SparkILoop$$loop(SparkILoop.scala:670)
at 
org.apache.spark.repl.SparkILoop$$anonfun$org$apache$spark$repl$SparkILoop$$process$1.apply$mcZ$sp(SparkILoop.scala:997)
at 
org.apache.spark.repl.SparkILoop$$anonfun$org$apache$spark$repl$SparkILoop$$process$1.apply(SparkILoop.scala:945)
at 
org.apache.spark.repl.SparkILoop$$anonfun$org$apache$spark$repl$SparkILoop$$process$1.apply(SparkILoop.scala:945)
at 
scala.tools.nsc.util.ScalaClassLoader$.savingContextLoader(ScalaClassLoader.scala:135)
at 

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[jayadevanmurali]

Github user jayadevanmurali commented on a diff in the pull request:

https://github.com/apache/spark/pull/10983#discussion_r51342667
  
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -747,7 +747,7 @@ class SQLContext private[sql](
* only during the lifetime of this instance of SQLContext.
*/
   private[sql] def registerDataFrameAsTable(df: DataFrame, tableName: 
String): Unit = {
-catalog.registerTable(TableIdentifier(tableName), df.logicalPlan)
+catalog.registerTable(SqlParser.parseTableIdentifier(tableName), 
df.logicalPlan)
--- End diff --

Ok I can see the variable definition at line 211 of SqlContext.scala
@transient
 protected[sql] val sqlParser = new SparkSQLParser(getSQLDialect().parse(_))

But this varable is not used anywhare.All methods  use 
Sqlarser.parseTableIdentifier() for example  @Experimental
def createExternalTable(
tableName: String,
source: String,
options: Map[String, String]): DataFrame = {
**val tableIdent = SqlParser.parseTableIdentifier(tableName)**
val cmd =
CreateTableUsing(
tableIdent,
userSpecifiedSchema = None,
source,
temporary = false,
options,
allowExisting = false,
managedIfNoPath = false)
executePlan(cmd).toRdd
table(tableIdent)
}

Correct me if am wrong.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on the pull request:

https://github.com/apache/spark/pull/10983#issuecomment-177137733
  
You are using an older version of the master branch (last commit 25 days 
ago). Your version still has the ```org.apache.spark.sql.catalyst.SqlParser``` 
class. That has been removed since commit 
https://github.com/apache/spark/commit/7cd7f2202547224593517b392f56e49e4c94cabc.

Please update your master, and try again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[jayadevanmurali]

Github user jayadevanmurali commented on the pull request:

https://github.com/apache/spark/pull/10983#issuecomment-177392588
  
Thanks @hvanhovell , Got your point. I updated my code and repeat the 
steps. I was able to replicate this. Please check the steps

jayadevan@Satellite-L640:~/spark$ ./bin/spark-shell
NOTE: SPARK_PREPEND_CLASSES is set, placing locally compiled Spark classes 
ahead of assembly.
Using Spark's default log4j profile: 
org/apache/spark/log4j-defaults.properties
Setting default log level to "WARN".
To adjust logging level use sc.setLogLevel(newLevel).
16/01/31 09:27:57 WARN NativeCodeLoader: Unable to load native-hadoop 
library for your platform... using builtin-java classes where applicable
16/01/31 09:27:57 WARN Utils: Your hostname, Satellite-L640 resolves to a 
loopback address: 127.0.1.1, but we couldn't find any external IP address!
16/01/31 09:27:57 WARN Utils: Set SPARK_LOCAL_IP if you need to bind to 
another address
Spark context available as sc (master = local[*], app id = 
local-1454212680541).
SQL context available as sqlContext.
Welcome to
    __
 / __/__  ___ _/ /__
_\ \/ _ \/ _ `/ __/  '_/
   /___/ .__/\_,_/_/ /_/\_\   version 2.0.0-SNAPSHOT
  /_/
 
Using Scala version 2.11.7 (Java HotSpot(TM) 64-Bit Server VM, Java 
1.7.0_80)
Type in expressions to have them evaluated.
Type :help for more information.

scala> import org.apache.spark.sql.types.{StringType, StructField, 
StructType}
import org.apache.spark.sql.types.{StringType, StructField, StructType}

scala> import org.apache.spark.sql.{DataFrame, Row, SQLContext}
import org.apache.spark.sql.{DataFrame, Row, SQLContext}

scala> import org.apache.spark.{SparkContext, SparkConf}
import org.apache.spark.{SparkContext, SparkConf}

scala> val rows = List(Row("foo"), Row("bar"));
rows: List[org.apache.spark.sql.Row] = List([foo], [bar])

scala> val schema = StructType(Seq(StructField("col", StringType)));
schema: org.apache.spark.sql.types.StructType = 
StructType(StructField(col,StringType,true))

scala> val rdd = sc.parallelize(rows);
rdd: org.apache.spark.rdd.RDD[org.apache.spark.sql.Row] = 
ParallelCollectionRDD[0] at parallelize at :29

scala> val df = sqlContext.createDataFrame(rdd, schema)
df: org.apache.spark.sql.DataFrame = [col: string]

scala> df.registerTempTable("t~")

scala> df.sqlContext.dropTempTable("t~")
org.apache.spark.sql.AnalysisException: NoViableAltException(327@[209:20: ( 
DOT id2= identifier )?])
; line 1 pos 1
  at 
org.apache.spark.sql.catalyst.parser.ParseErrorReporter.throwError(ParseDriver.scala:158)
  at 
org.apache.spark.sql.catalyst.parser.ParseErrorReporter.throwError(ParseDriver.scala:147)
  at 
org.apache.spark.sql.catalyst.parser.ParseDriver$.parse(ParseDriver.scala:95)
  at 
org.apache.spark.sql.catalyst.parser.ParseDriver$.parseTableName(ParseDriver.scala:42)
  at 
org.apache.spark.sql.catalyst.CatalystQl.parseTableIdentifier(CatalystQl.scala:81)
  at org.apache.spark.sql.SQLContext.table(SQLContext.scala:811)
  at org.apache.spark.sql.SQLContext.dropTempTable(SQLContext.scala:738)
  ... 49 elided

So I will close this pull request and raise a new one.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on a diff in the pull request:

https://github.com/apache/spark/pull/10983#discussion_r51254950
  
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -747,7 +747,7 @@ class SQLContext private[sql](
* only during the lifetime of this instance of SQLContext.
*/
   private[sql] def registerDataFrameAsTable(df: DataFrame, tableName: 
String): Unit = {
-catalog.registerTable(TableIdentifier(tableName), df.logicalPlan)
+catalog.registerTable(SqlParser.parseTableIdentifier(tableName), 
df.logicalPlan)
--- End diff --

We have removed SqlParser``` recently. Could you merge/rebase to the 
most recent master, and use the ```sqlParser``` variable for this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10983#issuecomment-176725239
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[jayadevanmurali]

GitHub user jayadevanmurali opened a pull request:

https://github.com/apache/spark/pull/10983

[SPARK-12982][SQL] Add table name validation in temp table registration

Add the table name validation at the temp table creation

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jayadevanmurali/spark 
branch-0.1-SPARK-SPARK-12982

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/10983.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10983


commit ef5d7c72d53d06b517f95201094a21fbb97d0006
Author: jayadevanmurali 
Date:   2016-01-29T11:55:43Z

Update SQLContext.scala

Add the table name validation at the temp table creation




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

[hvanhovell]

Github user hvanhovell commented on the pull request:

https://github.com/apache/spark/pull/10983#issuecomment-176728277
  
@jayadevanmurali I am not sure if the problem described in the JIRA is 
still an issue in the current master. Could you check this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org