[GitHub] spark pull request: [SPARK-13064] Make sure attemptId not none for...
Github user zhuoliu commented on the pull request: https://github.com/apache/spark/pull/12075#issuecomment-217971974 sure, thanks @srowen! Closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13064] Make sure attemptId not none for...
Github user zhuoliu closed the pull request at: https://github.com/apache/spark/pull/12075 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13064] Make sure attemptId not none for...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12075#issuecomment-217800070 OK let's close this PR @zhuoliu --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13064] Make sure attemptId not none for...
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/12075#issuecomment-217768123 @srowen , currently we assume attempt id is `None` when spark application is running on yarn client mode. This assumption is used not only in REST api, but also in history server and yarn extension services. 1. Only changing here will break the consistency for other parts as I mentioned before. 2. Even if we address all the parts related to attempt id, still we may break the backward compatibility, especially for event log file name. So IMHO I suggest not to change the behavior of attempt id unless we have a sufficient reason. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13064] Make sure attemptId not none for...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12075#issuecomment-217511458 OK, so @jerryshao you're fairly sure we shouldn't make this change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13064] Make sure attemptId not none for...
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/12075#issuecomment-203714098 IIUC for all the application running on yarn client mode, the attempt id is None, this assumption are not only existed in REST API, but also in event log, yarn extension service, changed only here may break the consistency of other components. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13064] Make sure attemptId not none for...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12075#issuecomment-203662693 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13064] Make sure attemptId not none for...
GitHub user zhuoliu opened a pull request:
https://github.com/apache/spark/pull/12075
[SPARK-13064] Make sure attemptId not none for Rest API
## What changes were proposed in this pull request?
For some application that does not set attemptId for their attempts, e.g.,
spark-shell applications, we set the default attemptId as Some("1") rather than
None.
## How was this patch tested?
Manually tested.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhuoliu/spark 13064
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12075.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12075
commit b8da260ec70518867c34c834be399fe412622975
Author: zhuol
Date: 2016-03-30T22:08:15Z
[SPARK-13064] Make sure attemptId not none for Rest API
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
