[GitHub] spark pull request: [SPARK-13118][SQL] Regression test for package...

[jodersky]

Github user jodersky commented on the pull request:

https://github.com/apache/spark/pull/11708#issuecomment-197191785
  
Update: there is actually an issue, please see updates description


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13118][SQL] Regression test for package...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11708#issuecomment-197189757
  
**[Test build #53294 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53294/consoleFull)**
 for PR 11708 at commit 
[`f479fcb`](https://github.com/apache/spark/commit/f479fcbe4d5e550896e45f53df538ddfd8ae11f1).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13118][SQL] Regression test for package...

[jodersky]

Github user jodersky commented on a diff in the pull request:

https://github.com/apache/spark/pull/11708#discussion_r56289475
  
--- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoderSuite.scala
 ---
@@ -152,6 +152,8 @@ class ExpressionEncoderSuite extends PlanTest with 
AnalysisTest {
   productTest(InnerClass(1))
   encodeDecodeTest(Array(InnerClass(1)), "array of inner class")
 
+  encodeDecodeTest(Array(Option(InnerClass(1))), "array of optional inner 
class")
--- End diff --

this fails without the change in ScalaReflection


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13118][SQL] Regression test for package...

[jodersky]

Github user jodersky commented on a diff in the pull request:

https://github.com/apache/spark/pull/11708#discussion_r56289468
  
--- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala 
---
@@ -476,7 +476,7 @@ object ScalaReflection extends ScalaReflection {
 // For non-primitives, we can just extract the object from the 
Option and then recurse.
 case other =>
   val className = getClassNameFromType(optType)
-  val classObj = Utils.classForName(className)
+  val classObj = getClassFromType(optType)
--- End diff --

@rxin this was the culprit in your case


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13118][SQL] Regression test for package...

[rxin]

Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/11708#issuecomment-196681717
  
cc @marmbrus 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13118][SQL] Regression test for package...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11708#issuecomment-196618788
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13118][SQL] Regression test for package...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11708#issuecomment-196618792
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53141/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13118][SQL] Regression test for package...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11708#issuecomment-196618415
  
**[Test build #53141 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53141/consoleFull)**
 for PR 11708 at commit 
[`a30f4c5`](https://github.com/apache/spark/commit/a30f4c5e7f4c46e576151316021616800105d3b2).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds the following public classes _(experimental)_:
  * `  case class PackageClass(value: Int)`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13118][SQL] Regression test for package...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11708#issuecomment-196587442
  
**[Test build #53141 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53141/consoleFull)**
 for PR 11708 at commit 
[`a30f4c5`](https://github.com/apache/spark/commit/a30f4c5e7f4c46e576151316021616800105d3b2).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13118][SQL] Regression test for package...

[jodersky]

GitHub user jodersky opened a pull request:

https://github.com/apache/spark/pull/11708

[SPARK-13118][SQL] Regression test for package objects

## What changes were proposed in this pull request?

Add regression test for Dataset's handling of classes defined in package 
objects. The problem described in the JIRA was resolved by some previous, 
unknown refactorings.
This pull request adds a regression test.

## How was this patch tested?
The patch consists of a test itself.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jodersky/spark SPARK-13118-package-objects

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/11708.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #11708


commit a30f4c5e7f4c46e576151316021616800105d3b2
Author: Jakob Odersky 
Date:   2016-03-15T00:35:33Z

Add regression test for Dataset's handling of classes defined in package 
objects




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org